wrong ltr direction for rtl wikis
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	Yamaha5
	May 8 2015, 9:07 AM

Description

After last update some text directs on rtl wikis goes wrong
1-history page for ltr page also is ltr! for example at
https://ar.wikipedia.org/w/index.php?title=%D9%88%D8%AD%D8%AF%D8%A9:Arguments&action=history
or
https://fa.wikipedia.org/w/index.php?title=%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Gadget-Extra-Editbuttons-autoed.js&action=history
the page content is ltr but it's history shouldn't rtl
2-At edit view for these pages class=editOptions (save and preview buttons) should be at right!

see attached image

Details

	Subject	Repo	Branch	Lines +/-
	Apply user interface language on files and non-view pages	mediawiki/core	master	+11 -2

Customize query in gerrit

Related Objects

Mentioned In: T99258: For CSS and JS pages, the direction of #mw-content-text should only be forced to LTR if showing the page content, not history
Mentioned Here: T99258: For CSS and JS pages, the direction of #mw-content-text should only be forced to LTR if showing the page content, not history

Event Timeline

Yamaha5 created this task.May 8 2015, 9:07 AM

Yamaha5 raised the priority of this task from to Needs Triage.

Yamaha5 updated the task description. (Show Details)

Yamaha5 added a project: MediaWiki-General.

Yamaha5 subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2015, 9:07 AM

Bug's snapshot

Yamaha5 triaged this task as High priority.May 8 2015, 9:16 AM

Yamaha5 added a project: I18n.

Yamaha5 set Security to None.

This is a recent regression and it caused bad looking on MediaWiki image pages also.

For example on this page, obvious issues on the page are the image and text behind it and upload history rable should be right aligned but they are not.

It seems someone have changed language content handling of such special pages recently and that caused this bad regression on them

And the issue is not just the fact this is getting wrong RTL or LTR direction, for example if you open up commons on Germany language interface, for example this page, you see mw-content-text element have lang="en" language instead lang="de" and this is the same regression (because dir="" is also set at the same with lang="" attribute and on this regression, both went wrong)

This is probably the cause: https://gerrit.wikimedia.org/r/#/c/208332/

Change 209980 had a related patch set uploaded (by Ebrahim):
Apply user lang on special pages

https://gerrit.wikimedia.org/r/209980

gerritbot added a project: Patch-For-Review.May 10 2015, 4:21 PM

Ladsgroup raised the priority of this task from High to Unbreak Now!.May 10 2015, 10:28 PM

why no one don't care!

I've locally patched commons and fawiki for this so we can delay this for one year even.

matmarex added projects: MediaWiki-Internationalization, MediaWiki-User-Interface.May 17 2015, 9:12 PM

matmarex subscribed.

In T98583#1290727, @Yamaha5 wrote:

why no one don't care!

Sorry, this must have been overlooked. People do actually care; task T99258, which seems to be at least partially about the same issue, had a patch submitted this Friday. It should probably be backported.

matmarex mentioned this in T99258: For CSS and JS pages, the direction of #mw-content-text should only be forced to LTR if showing the page content, not history.May 17 2015, 9:18 PM