Page MenuHomePhabricator
Create Task
Maniphest T98594

Error when visiting Nearby on Wikpedia (all of them)
Closed, ResolvedPublic
Actions

Description

Visiting http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby I see an error and the page does not work at all. Happens in enwiki too.

Chrome
Version 42.0.2311.135 (64-bit)

On Firefox 39 works fine.

On Firefox for Android it doesn't work at all.
On Chrome for Android either.

Error: Module not found: settings Error: Module not found: settings {stack: (...), message: "Module not found: settings"}log @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:176handler @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:153jQuery.Callbacks.fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:45jQuery.Callbacks.self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:46jQuery.Callbacks.self.fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:46mw.track @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:153runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:161execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:162mw.loader.implement @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:168(anonymous function) @ VM110:91(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:4jQuery.extend.globalEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:4mw.loader.work @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20150506T…:164request @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=2015

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendwmf/1.26wmf5+1 -0Adding mobile.settings as dependency for mobile.startup
mediawiki/extensions/MobileFrontendwmf/1.26wmf4+1 -0Adding mobile.settings as dependency for mobile.startup
mediawiki/extensions/MobileFrontendmaster+1 -0Adding mobile.settings as dependency for mobile.startup
Customize query in gerrit

Related Objects

Event Timeline

Jhernandez created this task.May 8 2015, 10:59 AM
Jhernandez raised the priority of this task from to High.
Jhernandez updated the task description. (Show Details)
Jhernandez added a project: Readers-Web-Backlog.
Jhernandez moved this task to Incoming on the Readers-Web-Backlog board.
Jhernandez added a subscriber: Jhernandez.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2015, 10:59 AM
KLans_WMF added a project: Mobile-Web-Sprint-47-Undercover-Brother.May 8 2015, 5:14 PM
KLans_WMF set Security to None.
KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Readers-Web-Backlog board.
• jhobs added a subscriber: • jhobs.May 8 2015, 5:22 PM

I'm getting three scenarios when trying to replicate this problem on desktop. These problems appear to be independent of clearing the cache.

  1. Spinner appears and spins forever.
  2. No pages found nearby. (no idea if this is correct, using desktop may be wonky even with sharing location)
  3. The JS "Module not found" error Jhernandez mentioned in the desription.

The overwhelming majority of the time I was receiving the 3rd scenario.

bmansurov added a subscriber: bmansurov.May 8 2015, 5:27 PM

Cannot reproduce locally on master.

kaldari added a subscriber: kaldari.May 9 2015, 12:02 AM

It looks like this is probably because 'mobile.startup' includes mobile.startup/Schema.js which requires settings, but 'mobile.startup' doesn't explicitly declare mobile.settings as a dependency.

gerritbot added a subscriber: gerritbot.May 9 2015, 12:28 AM

Change 209833 had a related patch set uploaded (by Kaldari):
Adding mobile.settings as dependency for mobile.startup

https://gerrit.wikimedia.org/r/209833

gerritbot added a project: Patch-For-Review.May 9 2015, 12:28 AM
kaldari edited projects, added Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story; removed Mobile-Web-Sprint-47-Undercover-Brother.May 9 2015, 12:28 AM
kaldari moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.
Florian added a subscriber: Florian.May 9 2015, 12:40 AM
gerritbot added a comment.May 9 2015, 12:41 AM

Change 209833 merged by jenkins-bot:
Adding mobile.settings as dependency for mobile.startup

https://gerrit.wikimedia.org/r/209833

kaldari mentioned this in rEMFR95fe74a7ad77: Adding mobile.settings as dependency for mobile.startup.May 9 2015, 12:42 AM
kaldari mentioned this in rMEXTc61b0699647b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Florian added a comment.May 10 2015, 3:58 PM

I assume, that this should be backported @kaldari ?

gerritbot added a comment.May 11 2015, 10:04 AM

Change 210013 had a related patch set uploaded (by Phuedx):
Adding mobile.settings as dependency for mobile.startup

https://gerrit.wikimedia.org/r/210013

gerritbot added a comment.May 11 2015, 10:05 AM

Change 210014 had a related patch set uploaded (by Phuedx):
Adding mobile.settings as dependency for mobile.startup

https://gerrit.wikimedia.org/r/210014

kaldari moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.May 11 2015, 5:08 PM
phuedx removed a project: Patch-For-Review.May 11 2015, 5:10 PM
phuedx closed this task as Resolved.May 11 2015, 6:05 PM
phuedx claimed this task.
phuedx added a subscriber: phuedx.

Signing this off as it's technical. We should get this deployed either tonight or tomorrow afternoon.

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.May 11 2015, 6:05 PM
gerritbot added a comment.May 15 2015, 12:40 AM

Change 210013 abandoned by Kaldari:
Adding mobile.settings as dependency for mobile.startup

Reason:
No longer needed

https://gerrit.wikimedia.org/r/210013

phuedx mentioned this in T99461: Special:Nearby fails with "Module not found" error when there is no location permission.May 18 2015, 4:46 PM
gerritbot added a comment.May 20 2015, 7:46 AM

Change 210014 abandoned by Phuedx:
Adding mobile.settings as dependency for mobile.startup

https://gerrit.wikimedia.org/r/210014

bmansurov removed a subscriber: bmansurov.May 20 2015, 4:57 PM
Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:23 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL