On screens less than 893, content should not match the lead image, but have 55 px margins. Lead images will stretch full width, edge-to-edge on iPads in both portrait and landscape.
Original task T91743
Current:
Design:
Description
Description
Event Timeline
Comment Actions
Where does 893px come from?
Note we define the threshold for mobile as 320px and then tablet as 768px
We should introduce any new numbers.
Comment Actions
@Jdlrobson
768px is portrait width, 893px is landscape width (not including margins)
893 also works as a good max width for desktop.
We've been using this for awhile.
Comment Actions
We've never used 898px before so the team should take the time to consider whether this is the most sensible threshold (e.g. landscape on what? ios? android? blackberry?) rather than rushing into using this number. A short spike should solve that. I'll setup a task.
Comment Actions
@Jdlrobson 768 makes sense as the entry threshold to tablet, but we need a max-width also. iPad landscape is 1024, and with 65px margins on each side you get 894. (Sorry not 893)
I thought it worked pretty well to constrain to 894 on desktop too for consistency, but I think its right to explore desktop more thoroughly.
Thanks Jon
Comment Actions
@Jdlrobson Just to clarify this is mainly to solve the bug that lead images are not full-width on tablets.
Comment Actions
Does that mean the body content would have to accomodate more margin to account for 65px margin on both sides?
Current version of WikidataPageBanner extension already displays full width banner images on all screen sizes -
Does that mean the body content would have to accomodate more margin to account for 65px margin on both sides?