When I generated extension.json for Graph extension, git aced8e127238a25ac8ddae38f0697693811570db, it skipped the GraphDataDomains configuration parameter that was set to the array(). This is very dangerous, as it may be accidentally forgotten when converting other extensions, and cause run-time errors.
Description
Details
Status | Subtype | Assigned | Task | |
---|---|---|---|---|
· · · | ||||
Resolved | None | T87875 Convert all Wikimedia-deployed extensions and skins to use extension registration | ||
Resolved | Legoktm | T98739 convertExtensionToRegistration skips config params set to empty array | ||
· · · |
Event Timeline
Hi could the problem be because It is set like
$$var = array();
where as shoulden it be like
$var = array();
Change 210365 had a related patch set uploaded (by Paladox):
Remove $ from $$var in convertExtensionToRegistration.php
Change 210365 abandoned by Paladox:
Remove $ from $$var in convertExtensionToRegistration.php
Change 210389 had a related patch set uploaded (by Legoktm):
registration: Don't ignore empty array config settings when converting
Change 210389 merged by jenkins-bot:
registration: Don't ignore empty array config settings when converting
Change 212575 had a related patch set uploaded (by Legoktm):
registration: Don't ignore empty array config settings when converting
Change 212575 merged by jenkins-bot:
registration: Don't ignore empty array config settings when converting