Page MenuHomePhabricator
Create Task
Maniphest T98762

Instantly close search in edit collections
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Given I am logged in user who has clicked edit on one of my collections
When I click the search input
And I search for "Mich"
And I click the "Michael Jackson" search result
Then Michael Jackson is added to my collection
And I am taken out of the search overlay
But Michael Jackson is not saved to my collection until I click 'save'

Details

SubjectRepoBranchLines +/-
Updates to editor search panel styling and behaviourmediawiki/extensions/Gathermaster+11 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 11 2015, 5:42 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Gather Sprint Help!, Gather.
Jdlrobson moved this task to In Analysis on the Gather Sprint Help! board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2015, 5:42 PM
Jdlrobson claimed this task.May 11 2015, 5:42 PM
Jdlrobson set Security to None.
Jdlrobson edited a custom field.
• KHammerstein subscribed.May 11 2015, 5:56 PM

Related to T97680 ?

• JKatzWMF moved this task from Needs triage to This Sprint on the Gather board.May 11 2015, 6:00 PM
Jdlrobson removed Jdlrobson as the assignee of this task.May 11 2015, 6:39 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Help! board.
Jdlrobson claimed this task.May 11 2015, 9:36 PM
Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Help! board.
Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Help! board.May 11 2015, 9:52 PM
gerritbot subscribed.May 11 2015, 9:53 PM

Change 210204 had a related patch set uploaded (by Jdlrobson):
Updates to editor search panel styling and behaviour

https://gerrit.wikimedia.org/r/210204

gerritbot added a project: Patch-For-Review.May 11 2015, 9:53 PM
Jdlrobson added a comment.May 11 2015, 10:04 PM
In T98762#1276857, @KHammerstein wrote:

Related to T97680 ?

See last comment on that task.

• Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Help! board.May 13 2015, 11:58 AM
gerritbot added a comment.May 13 2015, 12:00 PM

Change 210204 merged by jenkins-bot:
Updates to editor search panel styling and behaviour

https://gerrit.wikimedia.org/r/210204

Diffusion mentioned this in rMEXTa27c62162cef: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 13 2015, 12:00 PM
• Jhernandez added a parent task: T98542: When searching for and adding multiple pages, search field should clear.May 13 2015, 12:01 PM
Jdlrobson mentioned this in rEGAT03d03dadd3a8: Updates to editor search panel styling and behaviour.May 13 2015, 12:01 PM
• JKatzWMF closed this task as Resolved.May 21 2015, 2:29 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Help! board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL