Page MenuHomePhabricator
Create Task
Maniphest T98833

Special uploads not loading thumbnails anymore
Closed, ResolvedPublic
Actions

Description

Looks like there has been a change to the API.
See: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads/Kaldari
No thumbnails load.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+1 -1Request "small" images in PhotoListApi#getQuery
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 12 2015, 8:11 AM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 8:11 AM
phuedx moved this task from Incoming to Old Unorganized Resolved Tasks on the Readers-Web-Backlog board.May 12 2015, 10:25 AM
phuedx added projects: Mobile-Web-Sprint-47-Undercover-Brother, Gather Sprint Help!.
phuedx set Security to None.
phuedx added a subscriber: phuedx.

I've moved this into the latest Mobile Web and Gather sprints as this is a regression.

Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Help! board.May 12 2015, 10:58 AM
phuedx added a comment.May 12 2015, 3:52 PM

PhotoListApi#getQuery method isn't setting the iiurlwidth parameter as it's referring to a configuration variable that no longer exists, wgMFThumbnailSizes.medium. According to git bisect that constant was removed in 193017.

phuedx moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 3:55 PM
gerritbot added a subscriber: gerritbot.May 12 2015, 3:56 PM

Change 210384 had a related patch set uploaded (by Phuedx):
Request "small" images in PhotoListApi#getQuery

https://gerrit.wikimedia.org/r/210384

gerritbot added a project: Patch-For-Review.May 12 2015, 3:56 PM
phuedx claimed this task.May 12 2015, 3:56 PM
phuedx added a comment.May 12 2015, 4:11 PM

This has been merged.

phuedx moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 4:11 PM
phuedx removed a project: Gather Sprint Help!.
gerritbot added a comment.May 13 2015, 5:27 AM

Change 210384 merged by jenkins-bot:
Request "small" images in PhotoListApi#getQuery

https://gerrit.wikimedia.org/r/210384

Diffusion mentioned this in rMEXT4b7f4223a4a9: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 13 2015, 5:27 AM
Jdlrobson mentioned this in rEMFRd2c685fe535e: Request "small" images in PhotoListApi#getQuery.May 13 2015, 5:28 AM
phuedx closed this task as Resolved.May 19 2015, 1:11 PM
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-47-Undercover-Brother board.
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:27 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL