msgnw:xyz doesn't work with hidden comments
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	FRacco
	May 12 2015, 10:13 AM

Description

I try to include the unexpanded wikitext of a page (this) into another page (this). I use {{msgnw:Namespace:Pagename}}, but I have a problem with hidden comments in the original page. Some are included, others are not! I think comments are an important part of the wikitext, so I think all of them should be shown. Thanks in advance

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+9 -2	Make PPFrame::RECOVER_COMMENTS actually work

Customize query in gerrit

Related Objects

Mentioned In: rMW20cbd0f226a1: Make PPFrame::RECOVER_COMMENTS actually work

Event Timeline

FRacco created this task.May 12 2015, 10:13 AM

FRacco raised the priority of this task from to Needs Triage.

FRacco updated the task description. (Show Details)

FRacco added a subscriber: FRacco.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 10:13 AM

FRacco updated the task description. (Show Details)May 12 2015, 10:20 AM

FRacco set Security to None.

TTO added projects: MediaWiki-Parser, MediaWiki-Templates.May 12 2015, 10:38 AM

TTO added a subscriber: TTO.

I think this is a bug in Preprocessor_DOM::expand() and Preprocessor_Hash::expand(). When the output type is Parser::OT_HTML (so $this->parser->ot['html'] is true), the PPFrame::RECOVER_COMMENTS flag has no effect.

Change 210677 had a related patch set uploaded (by PleaseStand):
Make PPFrame::RECOVER_COMMENTS actually work

https://gerrit.wikimedia.org/r/210677

gerritbot added a project: Patch-For-Review.May 13 2015, 12:32 PM

Sorry, I can't understand the previous message. Can we solve the problem? Thanks in advance

@FRacco: The previous message links to a patch in Gerrit, the code review tool. Once that patch is merged and deployed on servers, this will be fixed.

Aklapper triaged this task as Medium priority.Jun 9 2015, 5:17 PM

Change 210677 merged by jenkins-bot:
Make PPFrame::RECOVER_COMMENTS actually work

https://gerrit.wikimedia.org/r/210677

PleaseStand mentioned this in rMW20cbd0f226a1: Make PPFrame::RECOVER_COMMENTS actually work.Aug 15 2015, 11:04 AM