Page MenuHomePhabricator

msgnw:xyz doesn't work with hidden comments
Closed, ResolvedPublic


I try to include the unexpanded wikitext of a page (this) into another page (this). I use {{msgnw:Namespace:Pagename}}, but I have a problem with hidden comments in the original page. Some are included, others are not! I think comments are an important part of the wikitext, so I think all of them should be shown. Thanks in advance

Event Timeline

FRacco raised the priority of this task from to Needs Triage.
FRacco updated the task description. (Show Details)
FRacco added a subscriber: FRacco.
FRacco set Security to None.

I think this is a bug in Preprocessor_DOM::expand() and Preprocessor_Hash::expand(). When the output type is Parser::OT_HTML (so $this->parser->ot['html'] is true), the PPFrame::RECOVER_COMMENTS flag has no effect.

Change 210677 had a related patch set uploaded (by PleaseStand):
Make PPFrame::RECOVER_COMMENTS actually work

Sorry, I can't understand the previous message. Can we solve the problem? Thanks in advance

@FRacco: The previous message links to a patch in Gerrit, the code review tool. Once that patch is merged and deployed on servers, this will be fixed.

Aklapper triaged this task as Medium priority.Jun 9 2015, 5:17 PM

Change 210677 merged by jenkins-bot:
Make PPFrame::RECOVER_COMMENTS actually work

TTO claimed this task.

Thanks to Kevin for the patch.