- Put cursor on an empty line
- Click link button in toolbar
- Link button is now depressed (correct)
- Click Cancel in link inspector
- Link button is still depressed (incorrect)
This is something in VE core or OOjsUI, so removed the VE-MW-Links project. Annotation inspectors have close actions, but I don't think you can properly go back to the tool and ensure it's deactivated from there when the close action is used...
<MatmaRex> first, i note that when pressing Ctrl+K to open the inspector, the toolbar tool doesn't get activated <Krenair> I feel like I've seen a task for that before <MatmaRex> i'm not sure if we want it to <MatmaRex> but assuming that we do, the best way to fix this seems to emit 'updateState' events on the toolbar, and handle them in each tool (to activate the tool is corresponding dialog is open) <MatmaRex> (and deactivate when closed) <MatmaRex> this way that tool wouldn't have to have access directly to the dialog <MatmaRex> emit 'updateState' events on the toolbar when a dialog is opened/closed*