Page MenuHomePhabricator

Link button remains depressed after canceling out of link inspector in insertion mode
Closed, ResolvedPublic8 Estimated Story Points


  1. Put cursor on an empty line
  2. Click link button in toolbar
  3. Link button is now depressed (correct)
  4. Click Cancel in link inspector
  5. Link button is still depressed (incorrect)

Event Timeline

Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a subscriber: Catrope.

This is something in VE core or OOjsUI, so removed the VE-MW-Links project. Annotation inspectors have close actions, but I don't think you can properly go back to the tool and ensure it's deactivated from there when the close action is used...

<MatmaRex> first, i note that when pressing Ctrl+K to open the inspector, the toolbar tool doesn't get activated
<Krenair> I feel like I've seen a task for that before
<MatmaRex> i'm not sure if we want it to
<MatmaRex> but assuming that we do, the best way to fix this seems to emit 'updateState' events on the toolbar, and handle them in each tool (to activate the tool is corresponding dialog is open)
<MatmaRex> (and deactivate when closed)
<MatmaRex> this way that tool wouldn't have to have access directly to the dialog
<MatmaRex> emit 'updateState' events on the toolbar when a dialog is opened/closed*

Change 221169 had a related patch set uploaded (by Bartosz Dziewoński):
Specify 'associatedWindows' for link and citation tools

Change 221170 merged by jenkins-bot:
Synchronize toolbar buttons state with state of their opened windows

Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.

Change 221169 merged by jenkins-bot:
Specify 'associatedWindows' for link and citation tools