Page MenuHomePhabricator
Create Task
Maniphest T98847

OOjs UI MenuToolGroup clipping breaks when scrolling
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  1. Open VisualEditor
  2. Make the browser too short to show the whole formatting menu
  3. Open the formatting menu
  4. Scroll down
  5. Notice it scrolls erratically when you reach the bottom

Details

SubjectRepoBranchLines +/-
Preserve scroll position in OO.ui.Element.static.reconsiderScrollbarsoojs/uimaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

• TrevorParscal created this task.May 12 2015, 12:24 PM
• TrevorParscal assigned this task to matmarex.
• TrevorParscal raised the priority of this task from to Needs Triage.
• TrevorParscal updated the task description. (Show Details)
• TrevorParscal added a project: OOUI.
• TrevorParscal subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 12:24 PM
matmarex added a comment.May 12 2015, 12:44 PM

Hmm, calling OO.ui.Element.static.reconsiderScrollbars() on anything causes the scroll position to be lost, and that's what causes the funny behavior here.

gerritbot subscribed.May 12 2015, 12:58 PM

Change 210339 had a related patch set uploaded (by Bartosz Dziewoński):
Preserve scroll position in OO.ui.Element.static.reconsiderScrollbars

https://gerrit.wikimedia.org/r/210339

gerritbot added a project: Patch-For-Review.May 12 2015, 12:58 PM
matmarex triaged this task as Medium priority.May 16 2015, 12:47 AM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.May 30 2015, 7:27 PM
Jdforrester-WMF closed this task as Resolved.Jun 3 2015, 9:06 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release, VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Jun 3 2015, 9:08 PM

Change 210339 merged by jenkins-bot:
Preserve scroll position in OO.ui.Element.static.reconsiderScrollbars

https://gerrit.wikimedia.org/r/210339

matmarex mentioned this in rGOJUb6aea7eeeaf2: Preserve scroll position in OO.ui.Element.static.reconsiderScrollbars.Jun 3 2015, 9:08 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Jun 3 2015, 9:12 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.11.4), WMF-deploy-2015-06-16_(1.26wmf10); removed OOjs-UI-next-release.Jun 9 2015, 10:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL