Page MenuHomePhabricator

Alert styles should be conditionally loaded
Closed, ResolvedPublic


alert, errorbox and warningbox classes are loaded on every page load.
They are only used in these places:

  • selected special pages
  • when viewing an old revision (note duplicate code in SkinMinerva and SkinMinervaBeta)

We should thus move these styles into a module that is loaded on special pages and conditionally load it when viewing an old revision.

Event Timeline

Jdlrobson assigned this task to Gilles.
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Florian, Jdlrobson, gerritbot and 3 others.

Change 214365 had a related patch set uploaded (by Jdlrobson):
Load message box styles only when needed

Change 214365 merged by jenkins-bot:
Load message box styles only when needed