Page MenuHomePhabricator
Create Task
Maniphest T98891

Global block log entry is different from the actual global block
Closed, ResolvedPublic
Actions

Description

See https://meta.wikimedia.org/w/index.php?title=Special:Log&type=gblblock&page=User:95.131.110.106/24
and https://meta.wikimedia.org/w/index.php?title=Special:GlobalBlockList&ip=95.131.110.0

95.131.110.0/24 was actually blocked but the log says 95.131.110.106/24. The IP gets IP::sanitizeRange()d in GlobalBlocking::insertBlock() but the logs are inserted in GlobalBlocking::block() which doesn't have sanitizeRange.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GlobalBlockingmaster+1 -1Use $this->address instead of $data['Address'] in SpecialGlobalBlock submission
mediawiki/extensions/GlobalBlockingmaster+262 -368Clean up and make SpecialGlobalBlock use FormSpecialPage
mediawiki/extensions/GlobalBlockingmaster+1 -1Trim reason before inserting to the table
Customize query in gerrit

Revisions and Commits

rEGBL extension-GlobalBlocking
rEGBLd43aab749ad6 Clean up and make SpecialGlobalBlock use FormSpecialPage
rEGBL4065c5cc512e Clean up and make SpecialGlobalBlock use FormSpecialPage
rEGBL5039471a171a Clean up and make SpecialGlobalBlock use FormSpecialPage
rEGBL05ecd35dda51 Clean up and make SpecialGlobalBlock use FormSpecialPage
rEGBL8b18864c223c Clean up and make SpecialGlobalBlock use FormSpecialPage
rEGBLe5e49e0b8ad0 Clean up and make SpecialGlobalBlock use FormSpecialPage

Event Timeline

Glaisher created this task.May 12 2015, 4:19 PM
Glaisher raised the priority of this task from to Medium.
Glaisher updated the task description. (Show Details)
Glaisher added a project: GlobalBlocking.
Glaisher added a subscriber: Glaisher.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 4:19 PM
Glaisher added a comment.May 13 2015, 4:24 AM

Also, reason in log entries are trim()med but the actual reason which gets inserted is not so it is different in that case as well.

Glaisher claimed this task.Dec 18 2015, 4:43 PM
gerritbot added a subscriber: gerritbot.Dec 18 2015, 4:46 PM

Change 260046 had a related patch set uploaded (by Glaisher):
Trim reason before inserting to the table

https://gerrit.wikimedia.org/r/260046

gerritbot added a project: Patch-For-Review.Dec 18 2015, 4:46 PM
gerritbot added a comment.Dec 19 2015, 9:27 AM

Change 210644 had a related patch set uploaded (by Glaisher):
Clean up and make SpecialGlobalBlock use FormSpecialPage

https://gerrit.wikimedia.org/r/210644

gerritbot added a comment.Dec 19 2015, 9:28 AM

Change 260046 abandoned by Glaisher:
Trim reason before inserting to the table

Reason:
Local blocks also doesn't do this. See https://gerrit.wikimedia.org/r/210644

https://gerrit.wikimedia.org/r/260046

gerritbot added a comment.Mar 16 2016, 6:44 PM

Change 210644 merged by jenkins-bot:
Clean up and make SpecialGlobalBlock use FormSpecialPage

https://gerrit.wikimedia.org/r/210644

Glaisher closed this task as Resolved by committing rEGBLe5e49e0b8ad0: Clean up and make SpecialGlobalBlock use FormSpecialPage.Mar 16 2016, 6:46 PM
Glaisher added a commit: rEGBLe5e49e0b8ad0: Clean up and make SpecialGlobalBlock use FormSpecialPage.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 16 2016, 7:00 PM
Glaisher reopened this task as Open.Mar 26 2016, 4:48 PM

Doesn't seem to have been fixed..

Melos globally blocked 189.219.107.183/24 (expiration 16:33, 26 September 2016) with the following comment: Cross-wiki spam: spambot
gerritbot added a comment.Mar 26 2016, 4:53 PM

Change 279715 had a related patch set uploaded (by Glaisher):
Use $this->address instead of $data['Address'] in SpecialGlobalBlock submission

https://gerrit.wikimedia.org/r/279715

gerritbot added a comment.Mar 28 2016, 7:56 PM

Change 279715 merged by jenkins-bot:
Use $this->address instead of $data['Address'] in SpecialGlobalBlock submission

https://gerrit.wikimedia.org/r/279715

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 28 2016, 8:01 PM
Glaisher closed this task as Resolved.Mar 29 2016, 5:58 AM
Glaisher added a commit: rEGBL05ecd35dda51: Clean up and make SpecialGlobalBlock use FormSpecialPage.Apr 28 2016, 2:35 AM
Glaisher added a commit: rEGBL8b18864c223c: Clean up and make SpecialGlobalBlock use FormSpecialPage.
Glaisher added a commit: rEGBL5039471a171a: Clean up and make SpecialGlobalBlock use FormSpecialPage.
Glaisher added a commit: rEGBL4065c5cc512e: Clean up and make SpecialGlobalBlock use FormSpecialPage.
Glaisher added a commit: rEGBLd43aab749ad6: Clean up and make SpecialGlobalBlock use FormSpecialPage.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL