Page MenuHomePhabricator

Global block log entry is different from the actual global block
Closed, ResolvedPublic

Description

See https://meta.wikimedia.org/w/index.php?title=Special:Log&type=gblblock&page=User:95.131.110.106/24
and https://meta.wikimedia.org/w/index.php?title=Special:GlobalBlockList&ip=95.131.110.0

95.131.110.0/24 was actually blocked but the log says 95.131.110.106/24. The IP gets IP::sanitizeRange()d in GlobalBlocking::insertBlock() but the logs are inserted in GlobalBlocking::block() which doesn't have sanitizeRange.

Event Timeline

Glaisher raised the priority of this task from to Medium.
Glaisher updated the task description. (Show Details)
Glaisher added a project: GlobalBlocking.
Glaisher added a subscriber: Glaisher.

Also, reason in log entries are trim()med but the actual reason which gets inserted is not so it is different in that case as well.

Change 260046 had a related patch set uploaded (by Glaisher):
Trim reason before inserting to the table

https://gerrit.wikimedia.org/r/260046

Change 210644 had a related patch set uploaded (by Glaisher):
Clean up and make SpecialGlobalBlock use FormSpecialPage

https://gerrit.wikimedia.org/r/210644

Change 260046 abandoned by Glaisher:
Trim reason before inserting to the table

Reason:
Local blocks also doesn't do this. See https://gerrit.wikimedia.org/r/210644

https://gerrit.wikimedia.org/r/260046

Change 210644 merged by jenkins-bot:
Clean up and make SpecialGlobalBlock use FormSpecialPage

https://gerrit.wikimedia.org/r/210644

Doesn't seem to have been fixed..

Melos globally blocked 189.219.107.183/24 (expiration 16:33, 26 September 2016) with the following comment: Cross-wiki spam: spambot

Change 279715 had a related patch set uploaded (by Glaisher):
Use $this->address instead of $data['Address'] in SpecialGlobalBlock submission

https://gerrit.wikimedia.org/r/279715

Change 279715 merged by jenkins-bot:
Use $this->address instead of $data['Address'] in SpecialGlobalBlock submission

https://gerrit.wikimedia.org/r/279715