Allow partners to override charge-warning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• DFoy
	May 12 2015, 8:55 PM

Description

Charge-warning message must allow per-partner customization in the same means that partner banners work now.
Default translations exist in translateWiki with the ability to override translateWiki within configuration.

Exit interstitial must support one or more hyperlinks in addition to continue / go back buttons.
Interstitial must also continue to support non-Javascript and Javascript versions.

Specific links and wordings TBD.

Existing exit interstitial must work as is for partners with no customization settings in their config JSON.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Implemented per-partner exit warnings	mediawiki/extensions/ZeroBanner	master	+30 -6

Customize query in gerrit

Related Objects

Mentioned In: rEZBAecc789ff9f8b: Implemented per-partner exit warnings
rMEXTe1f0e97ac256: Updated mediawiki/extensions Project: mediawiki/extensions/ZeroBanner…

Event Timeline

• DFoy created this task.May 12 2015, 8:55 PM

• DFoy assigned this task to • jhobs.

• DFoy raised the priority of this task from to High.

• DFoy updated the task description. (Show Details)

• DFoy added a project: Zero.

• DFoy added subscribers: • DFoy, Yurik.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 8:55 PM

• DFoy moved this task from Backlog to Current items to do on the Zero board.May 12 2015, 8:56 PM

Follow-up action from discussion with Dan & Adam: We need to have a discussion around implementation of this. @Yurik would probably have more insight than me on how to implement this since right now we use translatewiki strings and this would require some kind of either new back-end endpoint or modification of the banner injection to include exit warning data for later use.

• DFoy reassigned this task from • jhobs to Yurik.May 20 2015, 6:19 PM

• DFoy set Security to None.

• DFoy edited subscribers, added: • jhobs; removed: Yurik.

• DFoy renamed this task from Per-partner customization of zero exit warning to Per-partner customization of zero possible charge warning.May 20 2015, 6:55 PM

Yurik renamed this task from Per-partner customization of zero possible charge warning to Allow partners to override charge-warning.May 20 2015, 8:49 PM

Yurik updated the task description. (Show Details)

• DFoy moved this task from Current items to do to Ready to develop on the Zero board.May 21 2015, 11:22 PM

• DFoy moved this task from Ready to develop to Current items to do on the Zero board.May 29 2015, 5:38 PM

• DFoy lowered the priority of this task from High to Medium.May 29 2015, 8:53 PM

• DFoy moved this task from Current items to do to Ready to develop on the Zero board.Jun 18 2015, 5:47 PM

• DFoy raised the priority of this task from Medium to High.Jun 18 2015, 5:50 PM

There are two warning strings - for pages and for files (images). The image text shows "Images for {{SITENAME}} are not offered for free by your mobile carrier. Standard data charges may apply.", where as the page warning is "You are about to leave Zero-rated (free) {{SITENAME}}. Standard data charges may apply."

I will only do this for the page warnings for now, but it could be easily expanded later

Yurik moved this task from Ready to develop to Development in progress on the Zero board.Aug 5 2015, 7:47 PM

Change 229577 had a related patch set uploaded (by Yurik):
Implemented per-partner exit warnings

https://gerrit.wikimedia.org/r/229577

gerritbot added a project: Patch-For-Review.Aug 5 2015, 9:49 PM

Yurik moved this task from Development in progress to Development done on the Zero board.Aug 5 2015, 9:52 PM

Change 229577 merged by jenkins-bot:
Implemented per-partner exit warnings

https://gerrit.wikimedia.org/r/229577

Yurik mentioned this in rMEXTe1f0e97ac256: Updated mediawiki/extensions Project: mediawiki/extensions/ZeroBanner….Aug 5 2015, 11:30 PM

Yurik mentioned this in rEZBAecc789ff9f8b: Implemented per-partner exit warnings.

• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 6 2015, 12:00 AM

• jhobs moved this task from Development done to In production / Completed on the Zero board.Sep 28 2015, 4:12 PM