Page MenuHomePhabricator
Create Task
Maniphest T98924

CentralNotice: deploy core change required for campaign mixins
Closed, ResolvedPublic2 Story Points
Actions

Description

This core change is required for Campaign Mixins:

https://gerrit.wikimedia.org/r/#/c/202925/

It changes a method signature that's overridden in several extensions, including CentralNotice. Coordinated patches are ready for all those extensions:

https://gerrit.wikimedia.org/r/#q,I0a10fb0cbf17d095ece493e744296caf13dcee02,n,z
https://gerrit.wikimedia.org/r/#q,I67e957f74d6ca48cfb9a41fb5144bcc78f885e50,n,z
https://gerrit.wikimedia.org/r/#q,Ica3ba32aa2fc76d11a44f391b6edfc871e7fbe0d,n,z
https://gerrit.wikimedia.org/r/#q,Ic63e617f51702c27104e123d4bed91983a726b7f,n,z
https://gerrit.wikimedia.org/r/#q,I0ac775ca286e64825e31a9213b94648e41a5bc30,n,z
https://gerrit.wikimedia.org/r/#q,I816bffa3815e2eab7e88cb04d1b345070e6aa15f,n,z

The best approach will probably to both merge (to master or whatever the beta cluster is synced to) and deploy all of these together.

Related Objects

Event Timeline

AndyRussG created this task.May 12 2015, 9:57 PM
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG added projects: Fundraising Sprint James Brown, MediaWiki-extensions-CentralNotice.
AndyRussG moved this task to Pending Deployment on the Fundraising Sprint James Brown board.
AndyRussG added a subscriber: AndyRussG.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2015, 9:57 PM
AndyRussG claimed this task.May 12 2015, 9:57 PM
AndyRussG set Security to None.
AndyRussG edited a custom field.
gerritbot added a subscriber: gerritbot.May 20 2015, 6:52 PM

Change 202925 had a related patch set uploaded (by AndyRussG):
Add RL context param to ResourceLoaderModule::getDependencies()

https://gerrit.wikimedia.org/r/202925

AndyRussG edited a custom field.May 20 2015, 10:25 PM
gerritbot added a comment.Jun 9 2015, 2:20 AM

Change 202925 merged by jenkins-bot:
resourceloader: Add context param to ResourceLoaderModule::getDependencies

https://gerrit.wikimedia.org/r/202925

AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Lou Reed board.Jun 9 2015, 2:28 AM

All merged! We'll start train-riding to testwiki (2015-06-09) at 18:00 UTC.

Jdforrester-WMF closed this task as Resolved.Jun 9 2015, 2:31 AM
Jdforrester-WMF triaged this task as High priority.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL