Page MenuHomePhabricator

Echo: Mark all as read doesn't work on MW.org
Closed, DeclinedPublic

Description

Clicking "Mark all as read" in Echo notifications doesn't work right now -- I tried it with two different accounts, both Firefox and Chrome. It just sits there.

This is currently broken on production, on mediawiki.org

Event Timeline

DannyH raised the priority of this task from to Unbreak Now!.
DannyH updated the task description. (Show Details)
DannyH subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Please post exact reproduction steps, including the topic name, type of notification, etc., since I can't reproduce.

However, Ori found an exception that may or may not be relevant:

[05/12/15 19:52] <ori> matt_flaschen: 2015-05-12 23:43:21 mw1138 mediawikiwiki exception INFO: [55c5e817] /w/api.php?action=query&format=json&meta=notifications&notsections=alert%7Cmessage&notgroupbysection=1&notmessageunreadfirst=1&notformat=flyout&notlimit=25&notprop=index%7Clist%7Ccount&uselang=en&_=1431467991330   EchoCatchableFatalErrorException from line 513 of /srv/mediawiki/php-1.26wmf5/extensions/Flow/includes/UrlGenerator.php: Catchable fatal error

For me, it works to mark the messages as read, but the per-message "x" links do not vanish as they should.

wUTjtIF.png (435×611 px, 50 KB)

Agree with previous comments - notification counter goes to zero when marked as all read.
Rechecked on https://www.mediawiki.org/wiki/Talk:Sandbox.

DannyH claimed this task.

Yeah, I got it to work after clicking on a notification and then opening the panel again. I can't reproduce. Sorry for the false alarm.