Page MenuHomePhabricator
Create Task
Maniphest T98960

Parsoid should be able to understand HTML entities in links
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Wikitext: Breakfast and "[http:// http://www.librarieswithoutborders.org/ Librairies without borders]" presentation
Becomes in VE: Breakfast and "[http:// http://www.librarieswithoutborders.org/ Librairies without borders]" presentation as text without any link
But Mediawiki makes of it: Breakfast and "Librairies without borders" presentation linking to http://+http//www.librarieswithoutborders.org/

Found at: https://www.mediawiki.org/w/index.php?title=Wikimedia_Hackathon_2015/Program&oldid=1636908

Related Objects

Event Timeline

JanZerebecki created this task.May 13 2015, 2:26 PM
JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added projects: Parsoid, VisualEditor.
JanZerebecki subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2015, 2:26 PM
gerritbot subscribed.Jul 7 2015, 7:38 PM

Change 223384 had a related patch set uploaded (by Arlolra):
T98960: Accept entities in extlink href

https://gerrit.wikimedia.org/r/223384

gerritbot added a project: Patch-For-Review.Jul 7 2015, 7:38 PM
Arlolra triaged this task as Medium priority.Jul 7 2015, 7:43 PM
Arlolra subscribed.
Jdforrester-WMF renamed this task from VE can't handle [http:// http://...] to Parsoid should be able to understand HTML entities in links.Aug 6 2015, 11:18 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:36 AM
Arlolra claimed this task.Aug 27 2015, 8:51 PM
gerritbot added a comment.Aug 27 2015, 10:05 PM

Change 223384 had a related patch set uploaded (by Arlolra):
WIP: Accept entities in extlink href

https://gerrit.wikimedia.org/r/223384

ssastry moved this task from Needs Triage to In Progress on the Parsoid board.Oct 6 2015, 3:25 AM
cscott subscribed.Oct 6 2015, 2:07 PM

This one is weird. That's a totally bogus link, right? It doesn't actually work?

We do a sanity-checking pass after template expansion on the link contents to try to ensure the result actually parses as a URL. I'm guessing embedding a space fails that check -- as well it should.

I'm calling this a bug in the PHP parser for allowing such a thing in the first place.

ssastry moved this task from In Progress to Next Up on the Parsoid board.Dec 17 2015, 5:36 PM
ssastry moved this task from Next Up to Needs Triage on the Parsoid board.Dec 17 2015, 5:44 PM
Arlolra removed a project: Patch-For-Review.Feb 25 2016, 2:03 AM
gerritbot added a comment.Apr 4 2016, 10:40 PM

Change 223384 abandoned by Arlolra:
WIP: Accept entities in extlink href

Reason:
For now ... until I pick it up again.

https://gerrit.wikimedia.org/r/223384

nshahquinn-wmf merged a task: T140201: External link with character-entity brackets renders improperly in Parsoid.Jul 13 2016, 12:38 AM
nshahquinn-wmf added subscribers: nshahquinn-wmf, Zppix.
nshahquinn-wmf added a comment.EditedJul 13 2016, 12:41 AM
In T98960#1705483, @cscott wrote:

This one is weird. That's a totally bogus link, right? It doesn't actually work?

We do a sanity-checking pass after template expansion on the link contents to try to ensure the result actually parses as a URL. I'm guessing embedding a space fails that check -- as well it should.

I'm calling this a bug in the PHP parser for allowing such a thing in the first place.

@cscott, I don't know about the original test case, but if you look at the duplicate I just created and then merged in, the link I'm using is a valid one that works properly in the read view for its intended function (linking to a prepopulated Phabricator form). Of course, it works just as well if you use percent-encoding in place of character entities, which Parsoid does fine with, but my point is that it can happen with valid links :)

Jdforrester-WMF moved this task from TR0: Interrupt to External and Administrivia on the VisualEditor board.Aug 9 2016, 7:40 PM
Arlolra added a comment.Sep 8 2016, 8:50 PM

Another example from https://www.mediawiki.org/w/index.php?title=Parsoid/DumpGrepper&oldid=1054779

[https://bugzilla.wikimedia.org/sho w_bug.cgi?id=43652 Bug]

I should pick this up again ...

Arlolra merged a task: T91405: External link at https://www.mediawiki.org/wiki/OOjs_UI/Elements/Flagged?oldid=1431570 not parsed.Dec 12 2016, 11:17 PM
Arlolra added subscribers: matmarex, ssastry, • MZMcBride and 2 others.
gerritbot added a comment.Jan 6 2017, 8:46 PM

Change 223384 restored by Arlolra:
WIP: Accept entities in extlink href

https://gerrit.wikimedia.org/r/223384

• Elitre subscribed.EditedJan 9 2017, 6:10 PM

See this diff when an unrelated change changed wikilinks formatting (as reported on mediawiki.org). (Is it related? This is undesirable, especially as it's a bit more difficult to read.)

Arlolra merged a task: T95854: Using HTML entities [ and ] instead of per cent encoded characters for [ ] in external links is not recognised by Parsoid.Jan 9 2017, 9:49 PM
Arlolra added subscribers: Raymond, Nnemo.
gerritbot added a comment.Jan 9 2017, 10:52 PM

Change 223384 had a related patch set uploaded (by Arlolra):
T98960: Accept entities in extlink href

https://gerrit.wikimedia.org/r/223384

gerritbot added a project: Patch-For-Review.Jan 9 2017, 10:52 PM
gerritbot added a comment.Jan 19 2017, 3:11 PM

Change 223384 merged by jenkins-bot:
T98960: Accept entities in extlink href and url links

https://gerrit.wikimedia.org/r/223384

Arlolra closed this task as Resolved.Jan 19 2017, 5:42 PM
Stashbot subscribed.Jan 31 2017, 6:58 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-31T18:58:46Z] <arlolra> Updated Parsoid to version 734dc996 (T98960)

• Mholloway mentioned this in T156941: Selecting pronunciation fails when pronunciation filename contains quotes.Feb 1 2017, 8:04 PM
Jdforrester-WMF changed the point value for this task from 0 to 1.Feb 2 2017, 7:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits