Page MenuHomePhabricator

ResourceModules and AutoloadClasses are being stored as attributes even though they're globals
Closed, ResolvedPublic

Event Timeline

Legoktm created this task.May 13 2015, 4:40 PM
Legoktm claimed this task.
Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2015, 4:40 PM
Legoktm set Security to None.

Change 211664 had a related patch set uploaded (by Legoktm):
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211664

The cause of the bug is that they were not being added to $this->processed, but that was kinda fragile so I re-implemented it.

Change 211664 merged by jenkins-bot:
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211664

Change 211998 had a related patch set uploaded (by Paladox):
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211998

Paladox closed this task as Resolved.May 19 2015, 3:13 PM
Paladox added a subscriber: Paladox.

Assumed resolved since patch merged please open again if it was not and changes still need to be done.

Legoktm reopened this task as Open.May 19 2015, 3:15 PM

Change 211998 merged by jenkins-bot:
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211998

Legoktm closed this task as Resolved.May 19 2015, 3:31 PM

Seems this new patch that was merged is causing me some problems. Using metrolook skin under mediawiki 1.26 wmf 7 causes javascript to not work. website at http://en.random-wikisaur.tk