Page MenuHomePhabricator
Create Task
Maniphest T98977

ResourceModules and AutoloadClasses are being stored as attributes even though they're globals
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
registration: Use a static whitelist of keys that are not attributesmediawiki/coreREL1_25+26 -18
registration: Use a static whitelist of keys that are not attributesmediawiki/coremaster+26 -18
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.May 13 2015, 4:40 PM
Legoktm claimed this task.
Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added a project: MediaWiki-Configuration.
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2015, 4:40 PM
Legoktm added a project: MW-1.25-release.May 13 2015, 4:40 PM
Legoktm set Security to None.
gerritbot subscribed.May 18 2015, 6:32 AM

Change 211664 had a related patch set uploaded (by Legoktm):
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211664

gerritbot added a project: Patch-For-Review.May 18 2015, 6:32 AM
Legoktm added a comment.May 18 2015, 6:35 AM

The cause of the bug is that they were not being added to $this->processed, but that was kinda fragile so I re-implemented it.

Legoktm moved this task from Backlog to In Progress on the MediaWiki-Configuration board.May 18 2015, 6:35 AM
gerritbot added a comment.May 19 2015, 3:05 PM

Change 211664 merged by jenkins-bot:
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211664

Legoktm mentioned this in rMWa3f47a59153a: registration: Use a static whitelist of keys that are not attributes.May 19 2015, 3:05 PM
gerritbot added a comment.May 19 2015, 3:13 PM

Change 211998 had a related patch set uploaded (by Paladox):
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211998

Paladox closed this task as Resolved.May 19 2015, 3:13 PM
Paladox subscribed.

Assumed resolved since patch merged please open again if it was not and changes still need to be done.

Legoktm reopened this task as Open.May 19 2015, 3:15 PM
gerritbot added a comment.May 19 2015, 3:30 PM

Change 211998 merged by jenkins-bot:
registration: Use a static whitelist of keys that are not attributes

https://gerrit.wikimedia.org/r/211998

Legoktm mentioned this in rMWfd6cc0e7dd1d: registration: Use a static whitelist of keys that are not attributes.May 19 2015, 3:30 PM
Legoktm closed this task as Resolved.May 19 2015, 3:31 PM
Paladox added a comment.May 21 2015, 11:53 PM

Seems this new patch that was merged is causing me some problems. Using metrolook skin under mediawiki 1.26 wmf 7 causes javascript to not work. website at http://en.random-wikisaur.tk

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits