Page MenuHomePhabricator

HTMLForm fields submit and button should support $wgUseMediaWikiUIEverywhere
Closed, DeclinedPublic

Description

HTMLForm's submit and button fields doesn't get the mediawiki ui classes when $wgUseMediaWikiUIEverywhere is set to true.

Event Timeline

Florian created this task.May 13 2015, 9:05 PM
Florian raised the priority of this task from to Normal.
Florian updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2015, 9:05 PM

Are you saying you want to force it to 'vform' if wgUseMediawikiUIEverywhere is true? It already uses it in getButtons, and indirectly via the form fields themselves.

No :) VForm is a separate layout with mediawiki ui, i want to convert the other layout formats to output mw-ui elements, too, when UseMediaWikiUIEverywhere is enabled (or later without this config).

Argh, it seems i missed something :) HTMLForm doesn't need a specific support for mediawiki.ui, it already uses HTML and Xml classes. I just thought that it has to, because submit and button doesn't have mw ui. So the task should be to add support for these two specific fields.

Florian renamed this task from HTMLForm should support $wgUseMediaWikiUIEverywhere to HTMLForm fields submit and button should support $wgUseMediaWikiUIEverywhere.May 15 2015, 4:46 PM
Florian claimed this task.
Florian updated the task description. (Show Details)
Florian removed a project: Tracking-Neverending.
Florian set Security to None.

Change 211136 had a related patch set uploaded (by Florianschmidtwelzow):
Add support for MediaWiki UI for buttons and submits in HTMLForm

https://gerrit.wikimedia.org/r/211136

Change 211136 abandoned by Florianschmidtwelzow:
Add support for MediaWiki UI for buttons and submits in HTMLForm

Reason:
see T100161

https://gerrit.wikimedia.org/r/211136