Page MenuHomePhabricator

Bundled notification emails for new flow topics have $ signs showing and links not fully-functional
Closed, ResolvedPublic

Description

I received this email today:

2 new topics on [$3 Talk:Beta Features/Hovercards]

The link took me to the page.
It should have taken me to https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topiclist_sortby=newest&fromnotif=1#flow-post-sdcsfo2n9dlgilif

4njynSe.png (384×1 px, 32 KB)

Another example which shows

3 new topics on '''<span class="plainlinks">[$3 Talk:Content translation]</span>'''

bug.png (57×631 px, 6 KB)

Event Timeline

Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added a subscriber: Quiddity.

I would like to see the original email you received with the bad link.

have sent FWD and Original HTML via email

He7d3r set Security to None.
He7d3r updated the task description. (Show Details)

Change 211983 had a related patch set uploaded (by Sbisson):
Add topic URL as 3rd parameter for bundled email message

https://gerrit.wikimedia.org/r/211983

Mattflaschen-WMF lowered the priority of this task from Unbreak Now! to High.May 19 2015, 6:18 PM

Per retrospective

@Quiddity: with the current template from i18n file, fixed to remove the <span>, when $3 is the URL, plaintext emails look like this:

Screen Shot 2015-05-21 at 14.55.29.png (80×770 px, 18 KB)

There is currently no way to specify different templates for HTML vs. plaintext emails but if you tell me what you think the plaintext email should look like, I can try to work in that direction.

Change 211983 merged by jenkins-bot:
Fix notification email

https://gerrit.wikimedia.org/r/211983

DannyH added a subscriber: DannyH.

Resolving this, per Stephane