Page MenuHomePhabricator
Create Task
Maniphest T99267

Text in VE's re-use citation menu should wrap
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently, each citation in the re-use citation menu occupies only one line, and any citations that are wider than the dialog are simply cut off, which often leaves too little content to help editors decide which one to re-use:

Screen Shot 2015-05-15 at 11.18.21.png (370×525 px, 71 KB)

Citations should text wrap onto the next line, possibly being truncated with an ellipsis after taking up three lines.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make sure reference result menu can wrapmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

nshahquinn-wmf created this task.May 15 2015, 6:23 PM
nshahquinn-wmf raised the priority of this task from to High.
nshahquinn-wmf updated the task description. (Show Details)
nshahquinn-wmf added projects: VisualEditor, VisualEditor-MediaWiki-References.
nshahquinn-wmf subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2015, 6:23 PM
nshahquinn-wmf updated the task description. (Show Details)May 15 2015, 6:25 PM
nshahquinn-wmf set Security to None.
Krenair subscribed.May 17 2015, 1:18 PM

That white-space: normal in modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceResultWidget.css is being overridden by the white-space: nowrap rule for .oo-ui-optionWidget.oo-ui-labelElement .oo-ui-labelElement-label

gerritbot subscribed.May 17 2015, 1:25 PM

Change 211523 had a related patch set uploaded (by Alex Monk):
Make sure reference result menu can wrap

https://gerrit.wikimedia.org/r/211523

gerritbot added a project: Patch-For-Review.May 17 2015, 1:25 PM
Krenair claimed this task.May 17 2015, 1:25 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.May 21 2015, 3:00 PM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.May 21 2015, 3:07 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.May 23 2015, 7:17 AM
Jdforrester-WMF edited a custom field.May 23 2015, 9:26 AM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Jun 3 2015, 5:46 PM
Jdforrester-WMF closed this task as Resolved.Jun 4 2015, 10:28 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Jun 4 2015, 10:30 PM

Change 211523 merged by jenkins-bot:
Make sure reference result menu can wrap

https://gerrit.wikimedia.org/r/211523

Krenair mentioned this in rEVEDd39e4c3ee916: Make sure reference result menu can wrap.Jun 4 2015, 10:30 PM
• Forrestbot added a project: WMF-deploy-2015-06-09_(1.26wmf9).Jun 4 2015, 11:00 PM
• Forrestbot subscribed.
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Jun 17 2015, 11:31 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits