Page MenuHomePhabricator

Custom processor implementation broken
Closed, ResolvedPublic

Description

The current implementation of custom processors is broken when it merges the data together:

		foreach ( $this->processors as $processor ) {
			$data = array_merge_recursive( $data, $processor->getExtractedInfo() );
		}

The recursive merge will mess up merging of things like $wgGroupPermissions and anything else where there are common keys. Let's just remove it from 1.25 for now since there are currently no users of it, and re-evaluate how to implement it in 1.26, or whether we even need it.

Event Timeline

Legoktm created this task.May 18 2015, 5:37 AM
Legoktm claimed this task.
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2015, 5:37 AM
Legoktm updated the task description. (Show Details)May 18 2015, 5:48 AM
Legoktm set Security to None.

Change 211661 had a related patch set uploaded (by Legoktm):
registration: Remove implementation of custom processors for now

https://gerrit.wikimedia.org/r/211661

matmarex triaged this task as Unbreak Now! priority.May 19 2015, 11:54 AM
matmarex lowered the priority of this task from Unbreak Now! to High.

Change 211661 merged by jenkins-bot:
registration: Remove implementation of custom processors for now

https://gerrit.wikimedia.org/r/211661

Change 212000 had a related patch set uploaded (by Legoktm):
registration: Remove implementation of custom processors for now

https://gerrit.wikimedia.org/r/212000

Change 212000 merged by jenkins-bot:
registration: Remove implementation of custom processors for now

https://gerrit.wikimedia.org/r/212000

Legoktm closed this task as Resolved.May 19 2015, 3:31 PM