Page MenuHomePhabricator

bfcounts API issues with zero values
Closed, ResolvedPublic

Description

  • Beta features that haven't been activated by anyone yet don't have a "counts" field in the API response. This makes complicated things unnecessarily for the API consumer, beta features in that state should return a "counts" of 0.
  • Beta features that are used by at least 1 person can't ever go back to a "counts" of 0 in the DB (and in the API response, as a result). This is due to the logic in UpdateBetaFeatureUserCountsJob.php which ignores empty results when querying user_properties.

While this might seem insignificant since most beta features are quickly used by > 1 users, it has the potential to confuse developers the first time they use BetaFeatures or admins of very small wikis setting up a new BetaFeature.

Event Timeline

Gilles created this task.May 18 2015, 8:12 AM
Gilles raised the priority of this task from to Needs Triage.
Gilles updated the task description. (Show Details)
Gilles added a project: BetaFeatures.
Gilles added a subscriber: Gilles.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2015, 8:12 AM
Legoktm assigned this task to Quiddity.Jul 16 2015, 3:44 AM
Legoktm set Security to None.

Change 225003 had a related patch set uploaded (by Quiddity):
API: Changing the output if there are zero users for the feature

https://gerrit.wikimedia.org/r/225003

Change 225003 merged by jenkins-bot:
API: Changing the output if there are zero users for the feature

https://gerrit.wikimedia.org/r/225003

Quiddity closed this task as Resolved.Jul 16 2015, 4:12 AM