Like, helluva clippy on mid zoom levels.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
Comment:
Prevent label clipping by increasing all buffers
for the label layers to the maximum. This increases
the tile size somewhat, and we will need to optimize
the exact size at a later time.
Comment Actions
I suspect this is due to having too many labels in that region. Could you reduce their number for that zoom level? E.g. using sql LIMIT?
Comment Actions
LIMIT wouldn't reduce density in a predictable way, I might need to play more with labelgrid parameters.
Comment Actions
Setting to low priority because most of the labels show OK-ish now except for some areas.
Comment Actions
Slightly improved with https://github.com/nyurik/osm2pgsql-osm-bright.tm2source/pull/24
Comment Actions
There being too many labels and labels being cut off are separate issues. Yes, reducing the number of labels will decrease the number of cut off labels, but you can have high label density without cut off labels.
Comment Actions
Well, the user-facing result is the same, that's why it makes sense to keep it in one place IMO. Anyway, https://github.com/nyurik/osm2pgsql-osm-bright.tm2source/pull/28 improves ordering and thus clipping looks much better. Also, it should be faster.
Comment Actions
Data source commit: https://github.com/kartotherian/osm-bright.tm2source/commit/001d2674d0f9f6eb0dbb63347d3d9624d04b1710
Style commit: https://github.com/kartotherian/osm-bright.tm2/commit/44b464d277ee551dc3307e6ce623d40671eb5da9
Together, they improve at least Bay Area significantly for me. Still leaving the style open though because it's not fundamentally resolved.
Comment Actions
Even though I just pushed both latest commits directly to master, moving to Needs review for @Tfinc to look.
Comment Actions
Looking better overall. I'm going to resolve and file new phab tasks if I find some more.
Comment Actions
Firstly, congrats on the beta launch. Via twitter @mxfh directed my attention to: https://maps.wikimedia.org/#16/40.7121/-74.0072 Manhattan Tribeca and Southbridge Tower labels are also clipped.
Comment Actions
i'm sure more labels are clippy, but there is no point to have a generic endless task. Reopen with specific cases (should be added to details, not comment)