Page MenuHomePhabricator
Create Task
Maniphest T99678

Edit pencil icon should support different Android view states
Closed, ResolvedPublic
Actions

Assigned To
• Niedzielski
Authored By
• Niedzielski
May 19 2015, 4:06 PM
Tags
Referenced Files
F180824: download.png
Jun 18 2015, 9:30 PM
F176954: screenshot-2015-06-09-11-02-03-911238089.png
Jun 9 2015, 5:08 PM
F176955: screenshot-2015-06-09-11-05-54-166869426.png
Jun 9 2015, 5:08 PM
F176956: screenshot-2015-06-09-11-05-49-738245437.png
Jun 9 2015, 5:08 PM
F176953: screenshot-2015-06-09-11-01-57-139600749.png
Jun 9 2015, 5:08 PM
Subscribers
Aklapper
Dbrant
Etonkovidova
gerritbot
• Niedzielski
• Vibhabamba

Description

The edit pencil icons are static and do not have visual indication of states the way other Android drawables do. This task is to add at least a pressed state so they don't feel like a mock.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use Material-ish edit pencil backgroundapps/android/wikipediamaster+39 -19
Use Material-ish edit pencil backgroundmediawiki/extensions/MobileAppmaster+25 -5
Add active state to article edit pencil iconsapps/android/wikipediamaster+16 -16
Center edit pencil icon active statemediawiki/extensions/MobileAppmaster+2 -2
Add active state to article edit pencil iconsmediawiki/extensions/MobileAppmaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

• Niedzielski created this task.May 19 2015, 4:06 PM
• Niedzielski raised the priority of this task from to Low.
• Niedzielski updated the task description. (Show Details)
• Niedzielski added a project: Wikipedia-Android-App-Backlog.
• Niedzielski subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2015, 4:06 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.May 19 2015, 4:19 PM
• Niedzielski claimed this task.May 22 2015, 10:26 PM
• Niedzielski added a project: Mobile-App-Sprint-57-Android.
• Niedzielski set Security to None.
• Niedzielski moved this task from To Do to Doing on the Mobile-App-Sprint-57-Android board.
Dbrant edited projects, added Mobile-App-Sprint-58-Android; removed Mobile-App-Sprint-57-Android.May 25 2015, 11:40 AM
• KLans_WMF moved this task from To Do to Doing on the Mobile-App-Sprint-58-Android board.May 25 2015, 11:40 AM
gerritbot subscribed.May 25 2015, 9:40 PM

Change 213760 had a related patch set uploaded (by Niedzielski):
Add active state to article edit pencil icons

https://gerrit.wikimedia.org/r/213760

gerritbot added a project: Patch-For-Review.May 25 2015, 9:40 PM
gerritbot added a comment.May 25 2015, 9:47 PM

Change 213759 had a related patch set uploaded (by Niedzielski):
Add active state to article edit pencil icons

https://gerrit.wikimedia.org/r/213759

• Niedzielski moved this task from Doing to Code Review on the Mobile-App-Sprint-58-Android board.May 25 2015, 9:55 PM
gerritbot added a comment.May 27 2015, 5:53 PM

Change 213759 merged by Mholloway:
Add active state to article edit pencil icons

https://gerrit.wikimedia.org/r/213759

• Niedzielski mentioned this in rEMOBb30e79887374: Add active state to article edit pencil icons.May 27 2015, 5:53 PM
• Mholloway mentioned this in rMEXTf9d4a1ccf362: Updated mediawiki/extensions Project: mediawiki/extensions/MobileApp….May 27 2015, 5:53 PM
gerritbot added a comment.Jun 8 2015, 10:28 PM

Change 216869 had a related patch set uploaded (by Niedzielski):
Center edit pencil icon active state

https://gerrit.wikimedia.org/r/216869

Dbrant edited projects, added Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together; removed Mobile-App-Sprint-58-Android.Jun 9 2015, 1:23 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.
• Niedzielski added a comment.Jun 9 2015, 5:08 PM

Before and after (second) patch shots

Before:

screenshot-2015-06-09-11-05-49-738245437.png (800×480 px, 438 KB)

screenshot-2015-06-09-11-05-54-166869426.png (800×480 px, 438 KB)

After:

screenshot-2015-06-09-11-01-57-139600749.png (800×480 px, 441 KB)

screenshot-2015-06-09-11-02-03-911238089.png (800×480 px, 441 KB)

gerritbot added a comment.Jun 9 2015, 5:11 PM

Change 216869 merged by jenkins-bot:
Center edit pencil icon active state

https://gerrit.wikimedia.org/r/216869

gerritbot added a comment.Jun 9 2015, 5:11 PM

Change 213760 merged by jenkins-bot:
Add active state to article edit pencil icons

https://gerrit.wikimedia.org/r/213760

• Niedzielski mentioned this in rMEXTf6d87d26b425: Updated mediawiki/extensions Project: mediawiki/extensions/MobileApp….Jun 9 2015, 5:11 PM
• Niedzielski mentioned this in rAPAWa4a9a6593f6e: Add active state to article edit pencil icons.
• Niedzielski mentioned this in rEMOBb6fbc3a4d237: Center edit pencil icon active state.Jun 9 2015, 5:15 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 9 2015, 5:43 PM
• Forrestbot subscribed.
Dbrant moved this task from Code Review to Design Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 9 2015, 5:52 PM
• Vibhabamba subscribed.EditedJun 16 2015, 12:27 AM

I haven't seen any patterns of a grey square in the bg representing a pressed state to a user.

These are the kind of things that we should follow material design guidelines on:
See Responsive Interaction: https://www.google.com/design/spec/animation/responsive-interaction.html#

Dbrant subscribed.Jun 16 2015, 11:33 PM

@Niedzielski, After discussing with @Vibhabamba, it will be sufficient to simply change the background highlight to a circle instead of a square. This is probably accomplished in CSS most easily by adding a "border-radius" to your "active" style.

• KLans_WMF moved this task from Design Signoff to Doing on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 17 2015, 5:24 PM
• Vibhabamba added a comment.Jun 17 2015, 9:11 PM

@Niedzielski - Just a quick note on color

One of these values will make us a bit consistent with any future work around responsive interaction
200 #EEEEEE
300 #E0E0E

Taken from - https://www.google.com/design/spec/style/color.html#color-color-palette

gerritbot added a comment.Jun 17 2015, 11:11 PM

Change 219082 had a related patch set uploaded (by Niedzielski):
Use Material-ish edit pencil background

https://gerrit.wikimedia.org/r/219082

gerritbot added a comment.Jun 17 2015, 11:11 PM

Change 219083 had a related patch set uploaded (by Niedzielski):
Use Material-ish edit pencil background

https://gerrit.wikimedia.org/r/219083

gerritbot added a comment.Jun 18 2015, 1:57 PM

Change 219083 merged by jenkins-bot:
Use Material-ish edit pencil background

https://gerrit.wikimedia.org/r/219083

• Niedzielski mentioned this in rMEXT134d580b8ed9: Updated mediawiki/extensions Project: mediawiki/extensions/MobileApp….Jun 18 2015, 1:57 PM
• Niedzielski mentioned this in rEMOBb4405a95637c: Use Material-ish edit pencil background.
Dbrant moved this task from Doing to Design Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 18 2015, 2:04 PM
gerritbot added a comment.Jun 18 2015, 4:05 PM

Change 219082 merged by jenkins-bot:
Use Material-ish edit pencil background

https://gerrit.wikimedia.org/r/219082

• Niedzielski mentioned this in rAPAW4a6df00dbe07: Use Material-ish edit pencil background.Jun 18 2015, 4:05 PM
Dbrant moved this task from Bug Backlog to Current Sprint on the Wikipedia-Android-App-Backlog board.Jun 18 2015, 4:39 PM
• Vibhabamba added a comment.EditedJun 18 2015, 9:05 PM

@Niedzielski Can I request you to add a screenshot?
Would like to have design signoff done before last day of sprint.

• Niedzielski added a comment.Jun 18 2015, 9:30 PM

Here you go!

download.png (1×1 px, 325 KB)

• Vibhabamba added a comment.Jun 18 2015, 9:34 PM

Looks good for now. Signed off by design.

• Vibhabamba moved this task from Design Signoff to QA Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 18 2015, 9:34 PM
Etonkovidova subscribed.Jun 19 2015, 11:04 PM

Checked on 2.0.103-alpha-2015-06-19 on Samsung Tablet Ce0168(Android 4.0.4)
No grayish background is displayed behind the pencil icon.

Dbrant edited projects, added Mobile-App-Sprint-60-Android-Lightning-Round; removed Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together.Jun 24 2015, 5:33 PM
Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-60-Android-Lightning-Round board.
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Dbrant edited projects, added Mobile-App-Sprint-61-Android-Beach-Boys; removed Mobile-App-Sprint-60-Android-Lightning-Round.Jul 7 2015, 7:25 PM
Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-61-Android-Beach-Boys board.
Etonkovidova added a comment.Jul 8 2015, 9:02 PM

Checked 2.0.105-alpha-2015-07-08 on Nexus 5 API 22 x86 and Samsung Galaxy(android 4.3 GT-I9300).

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-61-Android-Beach-Boys board.Jul 8 2015, 9:21 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-61-Android-Beach-Boys board.Jul 15 2015, 12:25 PM
Dbrant closed this task as Resolved.Jul 21 2015, 11:59 AM
Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Jul 21 2015, 12:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits