Page MenuHomePhabricator
Create Task
Maniphest T99757

Blueprint/LSG Table of Contents should be configurable on-wiki, like MediaWiki:Sidebar
Closed, ResolvedPublic
Actions

Description

Blueprint.php hardcodes the set of pages that display in the Blueprint skin's nifty pop-up TOC. That's inflexible and prevents reuse outside of the #LivingStyleGuide.

Instead a message string should drive it, just like the sidebar in other skins. I think Blueprint can reuse PHP skin code like Skin->buildSidebar() or BaseTemplate->getSidebar() to parse a similar structure to MediaWiki:Sidebar.

Since Blueprint will only be in use in certain namespaces on mediawiki.org, it might be more flexible it to try the message key blueprint-namespacenum-sidebar before falling back to blueprint-sidebar.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clean up blueprint left navmediawiki/skins/Blueprintmaster+50 -31
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedVolker_ET111117 [EPIC] Enhance accessibility of OOUI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users
 ResolvedNoneT88023 Create landmarks for screen reader
 Resolved• SpageT307 Announcing the Developer Hub prototype release
 Resolved• SpageT299 Release the Developer Hub prototype
 Resolved• SpageT306 Featuring the first three APIs in the Developer Hub
 ResolvedoriT334 Document RCStream in the Developer Hub
 DeclinedNoneT302 API sandboxes for the Developer Hub
 ResolvedNoneT300 Select the three APIs featured at the Developer Hub prototype
 DeclinedNoneT88755 Improve MediaWiki API example behavior
 ResolvedAnomieT89229 API Help should generate [try in ApiSandbox] link to Special:ApiSandbox#action=params from getExamples()
 OpenNoneT89318 Replace on-wiki API documentation with Special:ApiHelp transclusion
 OpenNoneT89768 Language support in Special:ApiHelp and its transclusion.
 OpenNoneT90528 Generated API Help doesn't indicate the MediaWiki versions that support a module and parameters.
 Resolved• SpageT89680 Template:ApiEx on mw.org should have a link to "[view in ApiSandbox]".
 DeclinedNoneT335 Document the Content API in the Developer Hub
 ResolvedjeropbrendaT359 Document the Wikidata API in the Developer Hub
 OpenNoneT89863 [Task] Merge on-wiki Wikibase/API documentation into Wikibase apihelp strings.
 DeclinedQgilT303 Setup the Developer Hub prototype
 Resolved• SpageT98164 prototype Data and developer hub with Blueprint skin
 ResolvedQgilT101099 Developer Relations Roadmap
 ResolvedQgilT113030 Developer Relations quarterly review Jul-Sep 2015
 ResolvedQgilT101100 Engineering Community quarterly goals for July-September 2015
 Resolved• SpageT101441 Goal: Integrate the new Web APIs hub with mediawiki.org
 Resolved• SpageT305 Developer Hub homepage
 DeclinedNoneT317 "Terms of Use" must be prominently featured in the Developer Hub
 Resolved• SpageT301 Define the look&feel of the Developer Hub
 DeclinedNoneT93062 Define the navigation elements of the Web APIs hub
 Resolved• SpageT92941 Define personas for dev.wikimedia.org
 Resolved• SpageT92945 Reflect in dev.wikimedia.org what Wikimedia offers to developers
 DeclinedNoneT103986 issues with Data and Developer Hub prototype (tracking)
 DeclinedNoneT110835 `blueprint-left-nav` message doesn't seem to be localizable
 DeclinedNoneT93610 Put WikimediaUI Style Guide on mediawiki.org
 DeclinedNoneT93613 Deploy Blueprint on mediawiki.org as optional and experimental skin
 Resolved• PrtksxnaT99757 Blueprint/LSG Table of Contents should be configurable on-wiki, like MediaWiki:Sidebar
 Resolved• PrtksxnaT103784 The Blueprint sidebar on devhub prototype is missing Discussion link
 Resolved• PrtksxnaT104288 Blueprint skin has no footer or replacement (so no copyright)
 Resolved• SpageT104672 Convert Blueprint to core's HTML templating
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)
 ResolvedNoneT110988 Blueprint assumes personal_urls[0] contains username
 DeclinedNoneT104673 Remove Blueprint's use of bootstrap
 ResolvedNoneT107662 Add bootstrap source files with components currently in use at Blueprint
 ResolvedQgilT104694 Community support for deploying Blueprint in mediawiki.org as optional/experimental skin
 ResolvedVolker_ET109135 Change `#searchInput` to `type="search"` and add `<label>`.
 Resolved• violettoT112308 Blueprint should include skip-to-nav and skip-to-content links
 ResolvedVolker_ET119444 Integrate CSS mixin for screen reader and keyboard-only users into core
 ResolvedVolker_ET112342 Make Blueprint fully localizable
 DeclinedNoneT112487 Blueprint HTML output lacks headings (document) structure
 ResolvedNoneT110983 Blueprint sidebar reuses #firstHeading id
 ResolvedVolker_ET107213 Blueprint should make use of HTML5 <header> and <main> element with correct ARIA roles
 DeclinedNoneT113208 Consolidate CSS background images implementation with core mixins or ResourceLoaderImageModule
 ResolvedVolker_ET104213 No icon for "View source" and "Edit" in sidebar
 ResolvedVolker_ET113296 Keyboard selector (IMESelector) not correctly viewed on main search in Blueprint
 ResolvedVolker_ET107026 Cleanup `font` properties and let section edit link `.mw-editsection` use sans-serif font
ResolvedVolker_ET116722 Align Blueprint to Jenkins' composer.json validation
 ResolvedPastakhovT114463 Blueprint skin does not render all what it should
 ResolvedNoneT103452 Blueprint skin does not render page indicators
 ResolvedPastakhovT116130 "Undefined index: userpage" error when user is logged out
 ResolvedNoneT117843 The link of sidebar menu is directed to server root instead of wiki homepage
 ResolvedVolker_ET118113 Address FOUC of Toc in Blueprint
 ResolvedNoneT114212 Do not put the role="search" on the form element
 ResolvedVolker_ET121840 Remove obsolete LivingStyleGuide.php from Blueprint
 ResolvedVolker_ET122117 Bootstrap's CSS rule "box-sizing: border-box;" breaks VE toolbar
 ResolvedVolker_ET122753 Blueprint should use MediaWiki core's Less mixins

Event Timeline

• Spage created this task.May 20 2015, 1:11 AM
• Spage raised the priority of this task from to Needs Triage.
• Spage updated the task description. (Show Details)
• Spage added a project: Blueprint.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 1:11 AM
• Spage added a parent task: T93613: Deploy Blueprint on mediawiki.org as optional and experimental skin.May 20 2015, 1:13 AM
• Spage updated the task description. (Show Details)May 20 2015, 11:39 PM
• Spage set Security to None.
Qgil added subscribers: Qgil, • violetto, Volker_E, Wikimedia Design Style Guide.EditedJun 11 2015, 11:03 AM

This is a problem for T101441: Goal: Integrate the new Web APIs hub with mediawiki.org only if Codex aims to be deployed in mediawiki.org at the same time, right? (T93610) Otherwise it would be used only for #dev.wikimedia.org and we could hardcoded in the way that pleases us.

I mean, the right solution is to solve this task and make the ToC configurable, but if this best scenario is not feasible we still have feasible alternatives to avoid this task blocking T101441.

Qgil added a parent task: T93610: Put WikimediaUI Style Guide on mediawiki.org.Jun 11 2015, 11:05 AM
Qgil mentioned this in T93610: Put WikimediaUI Style Guide on mediawiki.org.Jun 11 2015, 11:11 AM
• violetto added a subscriber: • Prtksxna.Jun 11 2015, 11:25 AM

cc @Prtksxna

• Spage added a comment.Jun 17 2015, 6:46 PM
In T99757#1356237, @Qgil wrote:

This is a problem for T101441: Goal: Integrate the new Web APIs hub with mediawiki.org only if Codex aims to be deployed in mediawiki.org at the same time, right? (T93610) Otherwise it would be used only for #dev.wikimedia.org and we could hardcoded in the way that pleases us.

Yes. git master would have the TOC for the Data and developer hub, and http://living-style-guide.wmflabs.org/ would maintain a local branch with its TOC. If we did T93610: Put WikimediaUI Style Guide on mediawiki.org then we'd have to figure out how to configure two Blueprint TOCs on one wiki.

BTW, PHP is building a sidebar even if Blueprint doesn't use it:

#2  Skin->buildSidebar() called at [/home/spage/projects/core/includes/skins/SkinTemplate.php:447]
gerritbot subscribed.Jul 1 2015, 10:08 AM

Change 205217 had a related patch set uploaded (by Prtksxna):
Clean up blueprint left nav

https://gerrit.wikimedia.org/r/205217

gerritbot added a project: Patch-For-Review.Jul 1 2015, 10:08 AM
gerritbot added a comment.Jul 1 2015, 10:16 AM

Change 205217 merged by jenkins-bot:
Clean up blueprint left nav

https://gerrit.wikimedia.org/r/205217

• werdna mentioned this in rSKIN8c96d06ef015: Updated mediawiki/skins Project: mediawiki/skins/Blueprint….Jul 1 2015, 10:16 AM
• Prtksxna mentioned this in rSBLUfb74ed324176: Clean up blueprint left nav.Jul 1 2015, 10:18 AM
• Prtksxna closed this task as Resolved.Jul 1 2015, 10:19 AM
• Prtksxna claimed this task.
• Prtksxna added a subscriber: • werdna.

@werdna had fixed this for the LSG, see Mediawiki:Blueprint-left-nav, but the code never made it to master. Rebased to incorporate @Spage's changes and merged.

• Prtksxna moved this task from Backlog to Done on the Blueprint board.Jul 3 2015, 4:44 AM
Danny_B added a project: Wikimedia Design Style Guide.Jul 3 2016, 9:26 PM
Danny_B removed a subscriber: Wikimedia Design Style Guide.
Volker_E removed a project: Patch-For-Review.Mar 16 2017, 12:22 AM
Volker_E removed subscribers: • violetto, • Spage.
Volker_E triaged this task as Low priority.May 20 2017, 1:07 AM
Volker_E removed a project: Wikimedia Design Style Guide.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits