Upstream: https://we.phorge.it/T16451
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | Aklapper | T99759 Meme audio doesn't stop with preview regenerate | |||
| Open | brennen | T410849 Update to Phorge/Arcanist upstream (2026.xx) |
I've included this upstream along other planned improvements to sounds: https://secure.phabricator.com/T13292.
Fixing this will require changes in
https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252Fstable/webroot/rsrc/js/core/behavior-audio-source.js
and/or
https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252Fstable/src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php
if anyone felt like diving into that.
Obviously we do not end up anymore in PhabricatorImageMacroRemarkupRule once the markup for preview does not match anymore the regex in apply(), so we do not end up either in behavior-audio-source.js to potentially stop the noise.
I believe removing the feature to set looped audio is the way to go; that would also require updating all rows listed under SELECT id as macroId, audioPHID as audioFilePhid, audioBehavior FROM phabricator_file.file_imagemacro WHERE audioBehavior = "audio:loop";
Well, Firefox 146 tells me in the Console that
- Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. behavior-audio-source.js:95:22
- Uncaught (in promise) DOMException: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
...on pages viewing such memes already embedded.
But the meme sound is still played though when in Comment Preview, a bunch of times on top of each other when scrolling.
Bad news: the issue was wider then expected. Not happening during just previews.
but... Good news! upstream had two proposals:
We were really tempted to go for the option n. 1 and kill loops in general... but, interestingly, this was still not fixing the case if the one-shot audio waas a veeeeeeeeeeeeeery long mp3.
Now. THE Good news: this means the specific rickroll playing in loop since 10 years in the Firefox tab of the working laptop of @Aklapper, will be stopped, as soon as this specific task will be closed 🥳 congratulations to that Phorge tab!
Just to clarify: to do not scare the WMF meme department: when this task will be closed, this means everybody could still design a rickroll audio loop (if the meme department approves it), AND, changing preview will just do not loop it forever anymore 🌈
FAQ
OK but how to stop audio in a preview? → Just change preview!
OK but how to stop audio in a published comment? → Just scroll away! (yes, tanks to epriestley, scrolling away was normally sufficient to decrease/stop the meme volume 🤯 - thanks again for this feature...)