DOMUtils.isTplOrExtToplevelNode only looks for a Parsoid-assigned about id. However, these ids are assigned for ExpandedAttr scenarios as well. While, strictly speaking, that type is also a result of using transclusions for attributes, we should review uses of these helper to make sure there are no unintended consequences because of this nuance. We had one crasher in section offsets patch because of this. It is possible there is some other lurking issue elsewhere. We should perhaps clarify the helper name, functionality, and uses to eliminate this nuance.
Description
Description
Event Timeline
ssastry subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 4:56 PM2015-05-20 16:56:23 (UTC+0)
ssastry set Security to None.
Arlolra renamed this task from Technical Debt: Review uses of DOMUtils.isTplOrExtToplevelNode in codebase to Review uses of DOMUtils.isTplOrExtToplevelNode in codebase.Jun 3 2015, 6:58 PM2015-06-03 18:58:11 (UTC+0)
ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Sep 20 2018, 5:16 PM2018-09-20 17:16:33 (UTC+0)