Page MenuHomePhabricator
Create Task
Maniphest T99818

Invalid titles just lead to InvalidArgumentException
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

E.g. https://en.wikibooks.org/wiki/a& -

2015-05-20 19:22:07 mw1049 enwikibooks exception INFO: [5224434d] /wiki/a&   InvalidArgumentException from line 240 of /srv/mediawiki/php-1.26wmf6/includes/Message.php: $key must be a string or an array
#0 /srv/mediawiki/php-1.26wmf6/includes/GlobalFunctions.php(1433): Message->__construct()
#1 /srv/mediawiki/php-1.26wmf6/includes/title/MalformedTitleException.php(44): wfMessage()
#2 /srv/mediawiki/php-1.26wmf6/includes/MediaWiki.php(117): MalformedTitleException->__construct()
#3 /srv/mediawiki/php-1.26wmf6/includes/MediaWiki.php(130): MediaWiki->parseTitle()
#4 /srv/mediawiki/php-1.26wmf6/includes/MediaWiki.php(518): MediaWiki->getTitle()
#5 /srv/mediawiki/php-1.26wmf6/includes/MediaWiki.php(431): MediaWiki->main()
#6 /srv/mediawiki/php-1.26wmf6/index.php(46): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): include()
#8 {main} {"private":false}

Seems to only be on non-wikipedias, so wmf6 regression?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make MalformedTitleException errorMessage non-nullmediawiki/coremaster+2 -2
Pass a message key to MalformedTitleException constructormediawiki/corewmf/1.26wmf7+1 -1
Pass a message key to MalformedTitleException constructormediawiki/corewmf/1.26wmf6+1 -1
Pass a message key to MalformedTitleException constructormediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.May 20 2015, 7:23 PM
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added a project: Wikimedia-production-error.
Krenair subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 7:23 PM
Krenair renamed this task from Some URLs just lead to InvalidArgumentException to Invalid titles just lead to InvalidArgumentException.May 20 2015, 7:23 PM
Krenair added a project: MediaWiki-General.
Krenair set Security to None.
Ciencia_Al_Poder updated the task description. (Show Details)May 20 2015, 7:29 PM
Ciencia_Al_Poder added a project: Regression.
Krenair added subscribers: Anomie, daniel, matmarex.May 20 2015, 7:30 PM

Appears to have been caused by https://gerrit.wikimedia.org/r/#/c/209303/

Anomie added a comment.May 20 2015, 7:36 PM

Indirectly. MalformedTitleException::__construct() is documented to take a string as its first parameter, but MediaWiki::parseTitle() is passing null instead.

gerritbot subscribed.May 20 2015, 7:49 PM

Change 212331 had a related patch set uploaded (by Anomie):
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212331

gerritbot added a project: Patch-For-Review.May 20 2015, 7:49 PM
Umherirrender subscribed.May 20 2015, 7:55 PM

just calling "new MalformedTitleException()" would also throw this error (Call style before 1.26), because the default value of $errorMessage is null

In my opinion the call Title::newFromTextThrow( $title ); before the changed line should already have a correct MalformedTitleException thrown, but that acutally is not happen.

Anomie added a comment.May 20 2015, 8:01 PM
In T99818#1299821, @Umherirrender wrote:

just calling "new MalformedTitleException()" would also throw this error (Call style before 1.26), because the default value of $errorMessage is null

Before 1.26 the constructor was inherited from Exception, which takes an optional (but recommended) string message as its first parameter. Wikibase is doing this; I don't see any other uses of this class in extensions in Gerrit.

gerritbot added a comment.May 20 2015, 8:10 PM

Change 212331 merged by jenkins-bot:
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212331

Anomie mentioned this in rMWf0b510f9d947: Pass a message key to MalformedTitleException constructor.May 20 2015, 8:10 PM
Umherirrender added a comment.May 20 2015, 8:16 PM
In T99818#1299821, @Umherirrender wrote:

In my opinion the call Title::newFromTextThrow( $title ); before the changed line should already have a correct MalformedTitleException thrown, but that acutally is not happen.

Title::newFromTextThrow decode the & and than it is a valid title, therefore that call does not throw a MalformedTitleException.

Earlier in the code path Title::newFromURL is used, which does not decode html entity and therefore gets an invalid title and returning null. This null than triggers the call to Title::newFromTextThrow, but than the title is decoded and no invalid title is detected, going further to the now changed line.

gerritbot added a comment.May 21 2015, 12:29 AM

Change 212487 had a related patch set uploaded (by Ori.livneh):
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212487

gerritbot added a comment.May 21 2015, 12:30 AM

Change 212490 had a related patch set uploaded (by Ori.livneh):
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212490

gerritbot added a comment.May 21 2015, 12:36 AM

Change 212487 merged by Ori.livneh:
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212487

gerritbot added a comment.May 21 2015, 12:36 AM

Change 212490 merged by Ori.livneh:
Pass a message key to MalformedTitleException constructor

https://gerrit.wikimedia.org/r/212490

ori mentioned this in rMWadacd7b35c6f: Pass a message key to MalformedTitleException constructor.May 21 2015, 12:36 AM
ori mentioned this in rMWb13721b5cbd8: Pass a message key to MalformedTitleException constructor.
ori closed this task as Resolved.May 21 2015, 12:40 AM
ori claimed this task.
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:32 PM
• demon triaged this task as Medium priority.Jul 9 2015, 4:40 PM
gerritbot added a comment.Jun 21 2017, 1:22 PM

Change 360399 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Make MalformedTitleException errorMessage non-null

https://gerrit.wikimedia.org/r/360399

gerritbot added a comment.Jun 21 2017, 7:42 PM

Change 360399 merged by jenkins-bot:
[mediawiki/core@master] Make MalformedTitleException errorMessage non-null

https://gerrit.wikimedia.org/r/360399

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 21 2017, 8:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits