Page MenuHomePhabricator

Remove all "All rights reserved" copyright verbage from tops of .h and .m files.
Closed, ResolvedPublic


We do not reserve all rights.

We should remove all comments from the tops of files. We already have a license file in the repo that explains this. notes in the source files themselves are either redundant or conflicting.

Event Timeline

Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd moved this task to Needs Triage on the Wikipedia-iOS-App-Backlog board.
Mhurd subscribed.

@Mhurd true, I've been thinking that we need to setup our own WMF file templates. using Stencil, for example. How do you feel about us filing a task to do this and find/replace all non-copyleft copyright statements?

Sorry, by "filing a task" I meant: "update this description to something like:

  • update all file copyright statements
  • add script (and/or makefile goal) to install our WMF file templates onto the user's machine"
BGerstle-WMF raised the priority of this task from Low to Medium.Feb 2 2016, 6:09 PM
BGerstle-WMF lowered the priority of this task from Medium to Lowest.Feb 2 2016, 6:22 PM
JMinor raised the priority of this task from Lowest to Low.Apr 13 2016, 8:00 PM
JMinor subscribed.

Yeah, this just seems like a code template(s) we never updated or customized. This is not tied to a release, so I'm not going to move it into a version board, but I did bump priority slightly as it seems like a basic find/replace and we really do not reserve all rights, nor do we want to :P

You'll find that "All rights reserved" is common practice even in many open source projects.

If it's ok if we just have *no* copyright headers that would be ideal :)

We could write a test that checks for these and fails to build until they're removed.

I have nothing against having whatever headers we need to use (although I'm partial to "Copyright (c) 2016 Wikimedia Foundation. Provided under MIT-style license; please copy and modify!"), but the main thing that would be nice is at least having consistency - presently some say "All rights reserved" and some are like the one I pasted and some files have no copyright headers...

@JMinor Word is we are doing this as we go. Do we need this ticket?

JoeWalsh claimed this task.
JoeWalsh subscribed.

I added this to our format script - automatically removes leading licenses. Closing.