Page MenuHomePhabricator
Create Task
Maniphest T99851

in Special:ContentTranslation, deleting a whole section heading adds an unnecessary <br> in the end
Closed, DuplicatePublic1 Estimated Story Points
Actions

Description

To reproduce:

  1. Start translating https://en.wikipedia.org/wiki/William_Daniel_Phillips
  2. Click the "Biography" section heading.
  3. Press Ctrl-A to select the whole heading. Press delete the heading's text. If you inspect the element, you'll see that the text disappears and is replaced by <br />
  4. Type a new heading: "Biografia". If you inspect the heading, you'll see that the <br /> is in the end of the text.
  5. Publish the article.

Expected:

== Biografia ==

Actual:

== Biografia<br>
 ==

This also causes the heading to be displayed incorrectly.

I'm not sure whether this is something that must be fixed in ContentTranslation or auto-normalized by Parsoid.

Tested in Firefox on Fedora.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Publish preprocessing: Remove the empty br tags inserted by Firefoxmediawiki/extensions/ContentTranslationmaster+8 -1
Remove unnecessary <br> from the end of text using .replace()mediawiki/extensions/ContentTranslationmaster+12 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.May 20 2015, 10:44 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, Parsoid.
Amire80 added subscribers: Amire80, santhosh.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 10:44 PM
Amire80 renamed this task from in Special:ContentTranslation, deleting a whole section heading adds an unnecessary <br /> in the end to in Special:ContentTranslation, deleting a whole section heading adds an unnecessary <br> in the end.May 20 2015, 10:44 PM
Amire80 set Security to None.
Amire80 added a comment.May 21 2015, 6:25 AM

This seems to happen in all paragraphs and not just section headings, but in usual <p> paragraphs it doesn't cause messy syntax output.

santhosh added a comment.May 22 2015, 11:27 AM

Defective by design https://bugzilla.mozilla.org/show_bug.cgi?id=414223 :)

santhosh added a comment.May 22 2015, 11:30 AM

I think we need to clean it up as a preprocessing step before save/publish

gerritbot subscribed.May 22 2015, 11:46 AM

Change 212774 had a related patch set uploaded (by Santhosh):
Publish preprocessing: Remove the empty br tags inserted by Firefox

https://gerrit.wikimedia.org/r/212774

gerritbot added a project: Patch-For-Review.May 22 2015, 11:46 AM
santhosh claimed this task.May 25 2015, 4:05 AM
santhosh triaged this task as Medium priority.
santhosh added a project: ContentTranslation-Release6.
santhosh edited projects, added: ContentTranslation-Release5; removed: ContentTranslation-Release6.May 25 2015, 8:09 AM
Pginer-WMF moved this task from Backlog to Bugs on the ContentTranslation-Release5 board.May 25 2015, 8:48 AM
gerritbot added a comment.May 25 2015, 3:56 PM

Change 213580 had a related patch set uploaded (by Amire80):
Remove unnecessary <br> from the end of text using .replace()

https://gerrit.wikimedia.org/r/213580

gerritbot added a comment.May 27 2015, 6:44 AM

Change 213580 abandoned by Amire80:
Remove unnecessary <br> from the end of text using .replace()

Reason:
Santhosh's patch is better.

https://gerrit.wikimedia.org/r/213580

gerritbot added a comment.May 27 2015, 7:06 AM

Change 212774 merged by jenkins-bot:
Publish preprocessing: Remove the empty br tags inserted by Firefox

https://gerrit.wikimedia.org/r/212774

Diffusion mentioned this in rMEXT172abe48f5cb: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….May 27 2015, 7:06 AM
santhosh mentioned this in rECTXc42ea4f56624: Publish preprocessing: Remove the empty br tags inserted by Firefox.May 27 2015, 7:06 AM
santhosh closed this task as Resolved.May 27 2015, 7:18 AM
santhosh added a project: LE-Sprint-87.
santhosh moved this task from Backlog to Done on the LE-Sprint-87 board.
santhosh closed this task as a duplicate of T97942: Section titles contains a br-tag if edited.Jun 8 2015, 8:14 AM
santhosh edited a custom field.Jun 9 2015, 8:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits