Page MenuHomePhabricator

Missing watch stars on Mediawiki.org, also icons for side rail
Closed, ResolvedPublic

Description

On mw.org now, since today's deployment:

The icons for the watch stars are missing from the topic header, as well as the icons for the side rail.

On Chrome, if you click the star to subscribe to a post, you get the no-JS version, which takes you to a separate page and then dumps you on a "This has been added to your watchlist" page.

On Firefox, you can still click the blank icon to subscribe & unsubscribe from a topic.

I'm putting this in the current sprint, because the Chrome subscribe/unsubscribe experience is really annoying.

Chrome:

Firefox:

See also T99873: Wrong star icons. The difference is that shows an icon, but the wrong one.

Event Timeline

DannyH created this task.May 20 2015, 11:03 PM
DannyH raised the priority of this task from to High.
DannyH updated the task description. (Show Details)
DannyH moved this task to Ready for next sprint on the Collaboration-Team-Triage board.
DannyH added a subscriber: DannyH.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 11:03 PM
DannyH updated the task description. (Show Details)May 20 2015, 11:05 PM
DannyH set Security to None.

I can see all the icons on mw.org with both chrome and firefox. I am testing on https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards

However, I also get the no-js experience with chrome for subscribing and unsubscribing to a topic. I see this in the console when it happens:

[FLOW]  Error in component handler: interactiveHandler TypeError: Cannot read property '0' of undefined {stack: (...), message: "Cannot read property '0' of undefined"} [jQuery.Event]mw.flow.debug.FlowComponent.debug 
@ VM780:176(anonymous function) 
@ VM780:188emitWithReturn 
@ VM780:188FlowComponentEventsMixin.getDispatchCallback 
@ VM780:189jQuery.event.dispatch 
@ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=92bBvFuR:65jQuery.event.add.elemData.handle 
@ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=92bBvFuR:60

I can also see the stars in Firefox, so that might have been a temporary fluke? I'm marking this one as duplicate of T100406: Watch / unwatch present no-js experience in Chrome
Feel free to reopen if the problem persists.

matthiasmullie closed this task as Resolved.May 27 2015, 2:12 PM
matthiasmullie claimed this task.