Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Create pages instead of messing with MessageCache in SpamBlacklist tests | mediawiki/extensions/Flow | master | +5 -10 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Flow is hackily doing the following to override two messages:
$msgCache = \MessageCache::singleton(); $msgCache->enable(); $msgCache->replace( 'Spam-blacklist', implode( "\n", $this->blacklist ) ); $msgCache->replace( 'Spam-whitelist', implode( "\n", $this->whitelist ) ); // That only works if the spam blacklist is really reset
Two things:
- Why is the core patch breaking this usage?
- We should refactor SpamBlacklist to allow for easier mocking/testing. We can override the 'blacklist' by messing with internal properties of the \SpamBlacklist instance, but not the whitelist.
Comment Actions
Change 212493 had a related patch set uploaded (by Legoktm):
Create pages instead of messing with MessageCache in SpamBlacklist tests
Comment Actions
Change 212493 merged by jenkins-bot:
Create pages instead of messing with MessageCache in SpamBlacklist tests