Page MenuHomePhabricator
Create Task
Maniphest T99888

Link adaptation does not happen when the language code involved has a different domain name
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Example:

http://en.wikipedia.org/w/api.php?action=query&format=json&titles=Nepali_language&prop=langlinks&lllang=bh&redirects=true

Returns the corresponding link for the given title. But the following does not

http://en.wikipedia.org/w/api.php?action=query&format=json&titles=Nepali_language&prop=langlinks&lllang=bho&redirects=true

bh is the domain of wiki with content language bho

Same is true for following language names to domain name mappings

bho: 'bh', Bhojpuri. bho.wikipedia.org does not exist. bh.wikipeda.org exists.
'crh-latn': 'crh', crh-latn.wikipedia.org does not exist. crh.wikipeda.org exists.
gsw: 'als',
sgs: 'bat-smg',
'be-tarask': 'be-x-old',
vro: 'fiu-vro',
rup: 'roa-rup',
lzh: 'zh-classical',
nan: 'zh-min-nan',
yue: 'zh-yue'

Details

SubjectRepoBranchLines +/-
Fixes when language code and domain differmediawiki/extensions/ContentTranslationmaster+34 -23
Customize query in gerrit

Related Objects

Event Timeline

santhosh created this task.May 21 2015, 11:15 AM
santhosh raised the priority of this task from to High.
santhosh updated the task description. (Show Details)
santhosh added projects: ContentTranslation, ContentTranslation-Release6.
santhosh subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2015, 11:15 AM
santhosh renamed this task from Link adapation does not happen when the language code involved has a differen name to Link adapation does not happen when the language code involved has a differen domain name.May 21 2015, 11:16 AM
santhosh set Security to None.
KartikMistry subscribed.May 21 2015, 11:29 AM
santhosh edited projects, added ContentTranslation-Release5; removed ContentTranslation-Release6.May 25 2015, 8:08 AM
Pginer-WMF moved this task from Backlog to Bugs on the ContentTranslation-Release5 board.May 25 2015, 8:47 AM
santhosh added a project: LE-Sprint-88.Jun 10 2015, 6:20 AM

I believe https://gerrit.wikimedia.org/r/#/c/212250/ fixed this. We can verify this and close

santhosh added a comment.Jun 10 2015, 6:27 AM

A quick test showed me that this is not fixed. API parameter llang need to be specially constructed in these cases.

santhosh edited a custom field.Jun 10 2015, 6:27 AM
santhosh claimed this task.Jun 10 2015, 11:19 AM
gerritbot subscribed.Jun 10 2015, 11:21 AM

Change 217251 had a related patch set uploaded (by Santhosh):
Fix: Link adapation does not happen when language code and domain differs

https://gerrit.wikimedia.org/r/217251

gerritbot added a project: Patch-For-Review.Jun 10 2015, 11:21 AM
santhosh moved this task from Backlog to In Review on the LE-Sprint-88 board.Jun 10 2015, 11:22 AM
Nemo_bis subscribed.Jun 16 2015, 8:42 AM

Perhaps the proper fix is to fix sitematrix (T99059) and ask it for domains, or something like that. Hardcoding current domains in more places adds technical debt and will make T21986 harder to fix.

Amire80 renamed this task from Link adapation does not happen when the language code involved has a differen domain name to Link adaptation does not happen when the language code involved has a different domain name.Jun 17 2015, 3:55 PM
gerritbot added a comment.Jun 22 2015, 6:30 AM

Change 217251 merged by jenkins-bot:
Fixes when language code and domain differ

https://gerrit.wikimedia.org/r/217251

Diffusion mentioned this in rMEXT3bf9850d4886: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jun 22 2015, 6:30 AM
Amire80 mentioned this in rECTXb8b2d430475e: Fixes when language code and domain differ.Jun 22 2015, 6:31 AM
Liuxinyu970226 subscribed.Jun 22 2015, 8:27 AM
• Forrestbot added a project: WMF-deploy-2015-06-23_(1.26wmf11).Jun 22 2015, 8:40 PM
• Forrestbot subscribed.
santhosh moved this task from In Review to Done on the LE-Sprint-88 board.Jun 23 2015, 5:51 AM
Amire80 closed this task as Resolved.Jun 23 2015, 8:14 AM
Amire80 removed a project: Patch-For-Review.
Amire80 moved this task from Needs Triage to CX5 on the ContentTranslation board.
Liuxinyu970226 unsubscribed.Jun 23 2015, 8:38 AM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits