Page MenuHomePhabricator

Mobile App shouldn't reference MobileFrontend files in a hacky way
Closed, ResolvedPublic

Description

We are doing some maintenance and re-organising where some of our styles live
See https://gerrit.wikimedia.org/r/#/c/212567/

In doing this I noticed that I can't merge this due to:
ResourcesTest::testFileExistence with data set #1102 ('/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/MobileApp/../MobileFrontend/less/reset.less', 'mobile.app.pagestyles.android', '../MobileFrontend/less/reset.less')

Please do not reference MobileFrontend styles in this way so that we can get our patchset merged without it being a breaking change...

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

@Dbrant has a patch that fixes this. We worked on this in Lyon hackathon. Can you submit?

Change 213402 had a related patch set uploaded (by Dbrant):
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213402

Change 213431 had a related patch set uploaded (by Dbrant):
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213431

Change 213402 abandoned by Dbrant:
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213402

Change 213431 merged by jenkins-bot:
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213431