Page MenuHomePhabricator
Create Task
Maniphest T99921

Mobile App shouldn't reference MobileFrontend files in a hacky way
Closed, ResolvedPublic
Actions

Description

We are doing some maintenance and re-organising where some of our styles live
See https://gerrit.wikimedia.org/r/#/c/212567/

In doing this I noticed that I can't merge this due to:
ResourcesTest::testFileExistence with data set #1102 ('/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/MobileApp/../MobileFrontend/less/reset.less', 'mobile.app.pagestyles.android', '../MobileFrontend/less/reset.less')

Please do not reference MobileFrontend styles in this way so that we can get our patchset merged without it being a breaking change...

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileAppmaster+6 -25No longer explicitly refer to .less files from MobileFrontend.
mediawiki/extensions/MobileAppmaster+6 -25No longer explicitly refer to .less files from MobileFrontend.
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 21 2015, 4:22 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: MediaWiki-extensions-MobileApp, Mobile-App-Sprint-54-iOS, Mobile-App-Sprint-54-Android.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2015, 4:22 PM
Jdlrobson added projects: Readers-Web-Backlog, Blocked-on-Mobile-Apps.May 21 2015, 4:22 PM
Jdlrobson set Security to None.
Jdlrobson mentioned this in rEMFR0561e2f27364: Separate reset stylesheet from chrome styles.May 24 2015, 4:16 PM
Jdlrobson mentioned this in rMEXT087e7408edda: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Jdlrobson assigned this task to Dbrant.May 24 2015, 4:36 PM

@Dbrant has a patch that fixes this. We worked on this in Lyon hackathon. Can you submit?

gerritbot added a subscriber: gerritbot.May 24 2015, 9:02 PM

Change 213402 had a related patch set uploaded (by Dbrant):
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213402

gerritbot added a project: Patch-For-Review.May 24 2015, 9:02 PM
gerritbot added a comment.May 24 2015, 9:06 PM

Change 213431 had a related patch set uploaded (by Dbrant):
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213431

gerritbot added a comment.May 24 2015, 9:09 PM

Change 213402 abandoned by Dbrant:
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213402

Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Readers-Web-Backlog board.May 25 2015, 8:22 AM
gerritbot added a comment.May 25 2015, 8:59 AM

Change 213431 merged by jenkins-bot:
No longer explicitly refer to .less files from MobileFrontend.

https://gerrit.wikimedia.org/r/213431

Diffusion mentioned this in rMEXT82094a8bcb4d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileApp….May 25 2015, 8:59 AM
Dbrant mentioned this in rEMOB52ca7495eb6c: No longer explicitly refer to .less files from MobileFrontend..May 25 2015, 9:00 AM
Jdlrobson closed this task as Resolved.May 27 2015, 7:52 PM
• KLans_WMF moved this task from To Do to Done on the Mobile-App-Sprint-54-Android board.Jun 12 2015, 6:13 PM
• Phabricator_maintenance moved this task from 2017-18 Q3 to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:18 AM
Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptMar 7 2018, 1:18 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL