In T238242#5661272, @Jdlrobson wrote:

Is this a problem in MultimediaViewer of the routing library mediawiki.router?

Change 550772 had a related patch set uploaded (by Cstone; owner: Cstone):
[mediawiki/extensions/DonationInterface@master] Monthly convert: variant 008, different appeal paragraph text

I wrote about this topic at T234665#5655122. The summary is that I think OAuth 2.0 grant_type=client_credentials can be authenticated using session cookies. From the client's point of view, fetching an access token using client_credentials and submitting it back in order to authenticate a write request is basically the same as using a CSRF token. In OAuth 2.0, there's no MAC calculation, tokens are just "bearer" tokens which are replayed back to the server without modification, so clients are much simpler to implement.

Cannot reproduce. https://pl.wiktionary.org/wiki/; opens for me in Firefox 70. Which browser is this about?

Please test:

Change 550760 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Monthly convert: variant 007, change different amt link

@Urbanecm can I ask you to make it public? (I can too, but I feel like I shouldn't go around you)

This issue has been resolved: https://github.com/wikimedia/apps-android-wikipedia/pull/763

This is going first to @RHo for her to assess. @RHo -- if you agree that this should be changed on mobile, please say so here, and then I'll put it somewhere in the priority stack.

Thanks @Rxy!

Change 550757 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Monthly Convert: Variant 006, alternate button text

Change 539124 merged by jenkins-bot:
[mediawiki/core@master] special.version.css: Replace problematic BIDI attribute with dir

I'm not sure if we really have to change this, given that the browser bug was apparently fixed in Chromium 77, but this approach also works correctly, so let's just do it.

Hey @JTannerWMF I think the concern was simply whether enabling this additional functionality would possibly have a negative performance impact at scale. I don't think anyone on Security-Team is super concerned it will, just thought it might be worth running it by the Performance-Team just to be safe. I'll go ahead and resolve this particular task and leave it to you whether you want to run this by anyone else. Please let me know if you need anything else from me!

Thanks @alexhollender for clarification. In case I've been unclear in the task description I see a flat hierarchy currently as best option too – because we're installing a level that we barely explain in the components itself, nor is it usually used in context of applying our components. But the expanded variant seemed to be my understanding of our conversation as alternative option as well.

If you look at the file, it has around 50M lines, not all of Wikidata items change every month.

hi @Catrope - I am unable to get this error to show up but can you please advise whether the position is as per my comment on this task T235043#5662071 ?
Happy to leave in Design-review for now but think the same feedback applies here, and for the "End of suggestions card"...
cc @MMiller_WMF in case you prefer to make all of these fit into a single SE module UI fixes card or have another suggestion on how to break this work up.

Wikimedia Technical Conference
Atlanta, GA USA
November 12 - 15, 2019

I 'll be bold and resolve this since we now have fixed b). We can always reopen and evaluate if a) becomes an issue (aka I am going with 3.)

Minor visual bugs:

• Height of card should not alter when no suggestions are found. This can be done by adding more space above the "No suggestions found" header
• There should ~8px more space between the header "No suggestions found" and the graphic

In T234652#5662068, @darthmon_wmde wrote:

@debt notes are done =)

@debt notes are done =)

Completed auto-reimage of hosts:

['cloudcephosd1001.wikimedia.org']

Change 546792 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

Change 546791 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add 'warningbox' class for onSpecialContributionsBeforeMainOutput

In T238270#5661958, @suffusion_of_yellow wrote:

@JJMC89: That makes sense, in theory. But is it really impossible to edit EC-protected pages from Huggle? If not, EC should still be part of the rights.

Change 467552 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Put overhauled icon on baseline and unify code with Vector's

Change 550769 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@wmf/1.35.0-wmf.5] Restore CirrusSearchBuildDocumentParse hook

In T237887#5653650, @Daimona wrote:

Exactly, thanks! I just forgot one thing: adding a @fixme comment right above the if, saying something like:

@fixme Temporary stopgap for T237887

Just in case that code survives for more than expected.

@Etonkovidova Please give this another take. @Nikerabbit and myself have resolved this side-by-side.

hi @Catrope - there's a few minor style issues on the desktop version of the overlays which I've listed below (will keep all style issues for the mobile version of overlays tracked on the T236854).

The paper version of this seems to have gone missing from the window?

@ti_infotrad Could you try out the patch above and confirm that it also works the same?

Change 550766 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Exactly match collapsible logic of jquery.makeCollapsible

Context-driven testing about testing best practices - the discussion topic

Script wmf-auto-reimage was launched by jeh on cumin1001.eqiad.wmnet for hosts:

['cloudcephosd1001.wikimedia.org']

The log can be found in /var/log/wmf-auto-reimage/201911132244_jeh_88199.log.

Please, find the slides on Wikimedia Commons under the Category "Wikimedia Technical Conference 2019, day 2" here

Yeah, we should just make our selectors exactly match jquery.makeCollapsible.styles.less, like you did.

One cluster of things that seems like low hanging fruit (useful and easy to do without dedicated staff time) is conventions for Gerrit / wiki sync:

• Introduce a norm of linking to all affected documentation pages from gerrit changesets
• Have a maintenance template for tracking pages which will be affected by a pending patch
  • Maybe make a parser function for telling whether a patch is still pending (more effort but still not crazy to have it as community-maintained code)
  • alternatively as a poor man's version use Tool-extjsonuploader and Lua tables for syncing that data

In T237013#5658149, @GoranSMilovanovic wrote:

@Ladsgroup

My attempt at a logico-historical approach:

Step 1. You have produce a first data set of ORES score predictions that included all items.
Step 2. I have produced the Wikidata Quality Report based on that data set.
Step 3. You have produced an update of ORES score predictions.
Claim A. The update produced in Step 3. does not encompass the ORES score predictions for all items, but only for those items that have received a revision between steps 1. and 3.

The central question is: is my statement in Claim A. correct?

@Niharika @Prtksxna Sorry, another question!

In T234632#5661464, @Anomie wrote:

I see "The definition and code for the basic MediaWiki environment should live in the core repo." is listed as an action item, but I see little in the notes to justify that.

@JJMC89: That makes sense, in theory. But is it really impossible to edit EC-protected pages from Huggle? If not, EC should still be part of the rights.

Wikimedia Technical Conference
Atlanta, GA USA
November 12 - 15, 2019

Change 550763 merged by Jhedden:
[operations/puppet@production] install_server: add boot partition to cloudcephosd config