Page MenuHomePhabricator
Feed Advanced Search

Aug 16 2023

isaacl added a comment to T343906: Nesting headings in templates messes with the TOC bolding feature.

Note I reported the original issue at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_207#Vector_2022_table_of_contents:_bolded_heading_differing_from_current_scroll_position . As I identified in that posting, the bolded heading is not random, but one within the collapsed section of text.

Aug 16 2023, 5:13 PM · Community Feedback (Web), Desktop Improvements (Vector 2022)
isaacl added a comment to T343906: Nesting headings in templates messes with the TOC bolding feature.

Another example: compare https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Clarification_and_Amendment&oldid=1167627265 with https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Clarification_and_Amendment&oldid=1167874333

Aug 16 2023, 5:10 PM · Community Feedback (Web), Desktop Improvements (Vector 2022)

Oct 1 2022

isaacl added a comment to T120794: Create redirect when moving modules.

Also, would we like to support localized #REDIRECT or keep it in English?

English is sufficient, since the audience are Lua programmers rather than encyclopedic authors. Lua is English.

My major concern is that someone encounters the module link and asks which bloody fool wrote a module of one silly line.

Oct 1 2022, 9:04 PM · User-notice-archive, MediaWiki CodeJam Dec 2023, MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), Platform Engineering (Icebox), User-DannyS712, Scribunto

Jul 1 2022

isaacl added a comment to T241524: Parser function for loading gadgets.

I don't think the comparison to TemplateStyles regarding security risk is fully apt. I think the worst that can happen with style rules is that the real destination of a link can be obscured. This can be a problem but the damage is constrained to things that can happen when you visit some arbitrary URL. Malicious Javascript, on the other hand, runs in the context of the client and can do anything the Javascript API allows.

Jul 1 2022, 12:54 AM · Patch-Needs-Improvement, MediaWiki-extensions-Gadgets

Apr 28 2021

isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

Here is another example of a diff that hangs, also with a error message in the console:
jQuery.Deferred exception: Cannot read property 'type' of undefined TypeError: Cannot read property 'type' of undefined

Apr 28 2021, 4:07 AM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs

Apr 12 2021

isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

I tried creating a minimal test case, but haven't succeeded so far. These two diffs don't hang:

Apr 12 2021, 8:53 PM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs
isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

Here's a slightly different example, where an editor added an {{anchor}} template within a description list and the visual diff output hangs:

Apr 12 2021, 8:17 PM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs

Mar 27 2021

isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

As an interim step, can the exception be caught and some recovery action be taken?

Mar 27 2021, 6:16 PM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs

Mar 26 2021

isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

I created some test cases to try to isolate the problem.

Mar 26 2021, 9:22 PM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs

Mar 22 2021

isaacl added a comment to T278186: Visual diff crashes on a page with <s> tags spanning multiple list items (weird nesting).

Note although I did not keep track of other instances, I have seen other cases where mis-nested markup, similar to that in the example, have resulted in hanging. After identifying this commonality, I started the thread linked above.

Mar 22 2021, 9:39 PM · Verified, Editing-team (Kanban Board), Parsoid, MediaWiki-Parser, VisualEditor, VisualEditor-VisualDiffs

Feb 21 2020

isaacl added a comment to T120794: Create redirect when moving modules.

Is there any update on the status of this task? This would enable renaming a deployed module seamlessly, without having to resort to a copy-and-paste move to the new module name, followed by redirecting the old module to the new one.

Feb 21 2020, 8:47 PM · User-notice-archive, MediaWiki CodeJam Dec 2023, MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), Platform Engineering (Icebox), User-DannyS712, Scribunto

May 5 2019

isaacl added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

@isaacl mentions: "I'm still having the opposite issue that I mentioned before: diffs being marked as read even though they weren't, but on occasion I also see the issue that everyone else is complaining about regarding diffs that have been read"

Maybe I do know why. Does this still happen in safemode?

May 5 2019, 5:24 PM · Growth-Team-Filtering, Growth-Team, User-kostajh, Regression, User-notice, MediaWiki-Watchlist