Page MenuHomePhabricator
Feed Advanced Search

Jul 7 2023

Andreg-p created T341318: Regression: Math Popups Showing plain HTML.
Jul 7 2023, 5:28 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1), Math, Page-Previews

Jul 6 2023

Andreg-p added a comment to T275246: Populate rev_actor and rev_comment_id.

@Izno I thought so too at first but our rev_actor is not zeroed. That looks fine.

Jul 6 2023, 5:59 PM · MW-1.39-release, MediaWiki-Core-Revision-backend, MW-1.38-release, Platform Engineering Roadmap, Code-Health-Objective, Platform Team Initiatives (Revision Storage Schema Improvements), Technical-Debt
Andreg-p added a comment to T275246: Populate rev_actor and rev_comment_id.

@matmarex Unfortunately no. Here is part of the log, it says revision_comment_temp does not exist, so nothing to do.

Jul 6 2023, 1:26 PM · MW-1.39-release, MediaWiki-Core-Revision-backend, MW-1.38-release, Platform Engineering Roadmap, Code-Health-Objective, Platform Team Initiatives (Revision Storage Schema Improvements), Technical-Debt
Andreg-p added a comment to T275246: Populate rev_actor and rev_comment_id.

I suggest running a query on every wiki to make sure there is no empty rev_comment_id left. I tried running:

ladsgroup@mwmaint1002:~$ foreachwikiindblist all mysql.php -- -e "select count(*) from revision where rev_comment_id = 0;"

But that got super slow even in medium size wikis, don't want to run it on wikidata, specially on production.

Jul 6 2023, 11:52 AM · MW-1.39-release, MediaWiki-Core-Revision-backend, MW-1.38-release, Platform Engineering Roadmap, Code-Health-Objective, Platform Team Initiatives (Revision Storage Schema Improvements), Technical-Debt

Dec 23 2022

Andreg-p added a comment to T313331: Make code in the intersection from math and wikibase testable.

@Physikerwelt we implemented many tests already. I think we just forget to close this task. Can be closed, in my opinion.

Dec 23 2022, 5:20 AM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Math

Dec 9 2022

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@Physikerwelt - we're interested in testing this on the beta cluster prior to next week's train. Is there any way we can test this and do QA?

Dec 9 2022, 5:59 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Nov 22 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson Thank you very much. That was the missing piece. From our site, everything is running again. Following your changes, it seems we are close to an end on your site too?

Nov 22 2022, 6:17 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Nov 21 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson I updated our patch according to your changes and was able to make it work again (based on your patchset 20).

Nov 21 2022, 2:44 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Nov 16 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Physikerwelt I haven't. Thanks for pointing that out. I will check if that change works tomorrow.

Nov 16 2022, 10:04 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Nov 15 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson @phuedx For now, it is not our goal to be able to rewrite the gadget. In fact, we just want to utilize the popups as they are right now and show additional information about a mathematical expression (similar to the previews for links). In the far future, it might be interesting to have more possibilities in order to make finer, task-specific adjustments on the popups but that's all out of scope for now. In fact, the little WIP demo by @Jdlrobson entirely fits our needs already.

Nov 15 2022, 6:31 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Aug 26 2022

Andreg-p added a comment to T314986: Consider converting all texvcjs string type args to a new type.

I'm ok with that. However, for me 'param' is not really intuitively a wrapper for strings. Maybe Text or MathText or TexText or something like that? Maybe even as simple as TexString might work?

Aug 26 2022, 9:26 AM · Math, Texvcjs

Aug 1 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson @phuedx What can we do to move this forward?

Aug 1 2022, 4:47 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Jul 27 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@phuedx Considering the popup extension will be opened up for potentially more types of popups, a more selective enable/disable mechanism might be the right choice. But from our Math perspective, it does not make much of a difference.

Jul 27 2022, 7:44 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Jul 15 2022

Andreg-p added a comment to T312893: Agree on properties used for parts of math expressions.

Consider https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/710329/, I think we can close this issue?

Jul 15 2022, 12:05 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Math
Andreg-p added a comment to T312893: Agree on properties used for parts of math expressions.

@TheDJ sorry for that and thanks for the tip.

Jul 15 2022, 12:04 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Math
Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson I implemented everything on our side and it looks good so far:

Emc-Screenshot.jpeg (720×1 px, 146 KB)
Jacobi-Screenshot.jpeg (720×1 px, 158 KB)

Jul 15 2022, 8:33 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews
Andreg-p added a comment to T312893: Agree on properties used for parts of math expressions.

@Physikerwelt Supporting option 2 would not be too complicated. The issue I see is that in the near future, somebody comes up with a new idea on how to represent the elements of a formula and we need implement another option again. This is very much a never ending story where we (our Math extension) is always trying to catch the new trend on Wikidata to keep things running. And the people on Wikidata are not aware of our system that depends on the correct setup and use.

Jul 15 2022, 7:58 AM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Math
Andreg-p added a comment to T312893: Agree on properties used for parts of math expressions.

I confirm that https://www.wikidata.org/wiki/Q30204 is modeled correctly using the "new" scheme.

Jul 15 2022, 6:00 AM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Math
Andreg-p added a comment to T312893: Agree on properties used for parts of math expressions.

if we can replace P527 with P9758 and everything works as it did before, we can close this issue right away?

Jul 15 2022, 5:51 AM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Math

Jul 8 2022

Andreg-p added a comment to T233099: [For visibility] Page previews should be externally extendable.

@Jdlrobson Sorry for the delay. I finally find time to focus on this issue and have taken over Moritz's progress so far. I am keen to work on this now until its done.

Jul 8 2022, 8:58 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Web-Team-Backlog (Kanbanana-2022-23-Q2), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Page-Previews

Jun 10 2022

Andreg-p added a comment to T310249: Review stalled Math Patches in Gerrit.

@Physikerwelt, I plan to work on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/710329 in 2 weeks. I hope to finish by 15th July. Shouldn't take too long but based on my previous experiences, it's hard to foresee all difficulties.

Jun 10 2022, 9:07 AM · Patch-For-Review, Math

Mar 12 2021

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@Physikerwelt @alexhollender This seems to be a valid option for me. However, somebody should confirm that an additional pop-up library is acceptable. Otherwise, we run into a dead-end again.

Mar 12 2021, 8:28 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Dec 15 2020

Andreg-p closed T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account as Resolved.
Dec 15 2020, 3:41 AM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit
Andreg-p added a comment to T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.

Thank you so much, everybody.
And once more, sorry for the mess!

Dec 15 2020, 3:40 AM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit

Dec 14 2020

Andreg-p added a comment to T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.

In my naivety, I was hoping to avoid the procedure by just creating another account. Obviously not my smartest move :) I'm sorry for the mess!

Dec 14 2020, 2:35 PM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit
Andreg-p added a comment to T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.

@hashar
I noticed that the problem was the 2FA for AndreG-P. It is broken for this account. Unfortunately, after I reset the password for AndreG-P, it is still asking for the 2FA which does not work. So I cannot change the e-mail for AndreG-P because I cannot enter the account settings without 2FA.

Dec 14 2020, 12:55 PM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit
Andreg-p added a comment to T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.

@hashar
Thank you very much. That explains the problem a little bit. However, I am still not able to solve it.

Dec 14 2020, 10:20 AM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit
Andreg-p added a comment to T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.

@Aklapper In https://gerrit.wikimedia.org/r/login I enter the same credentials that I am using at https://wikitech.wikimedia.org/ to login.
But on https://gerrit.wikimedia.org/r/login, I got an "Authentication failed."

Dec 14 2020, 9:21 AM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit
Andreg-p created T270064: Cannot login gerrit.wikimedia.org with wikitech.mediawiki.org account.
Dec 14 2020, 8:55 AM · Trust-and-Safety, cloud-services-team (Kanban), Gerrit

Jul 20 2020

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@Physikerwelt @alexhollender This seems to be a valid option for me. However, somebody should confirm that an additional pop-up library is acceptable. Otherwise, we run into a dead-end again.

Jul 20 2020, 6:52 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Jun 23 2020

Andreg-p added a comment to T231970: Add information about the new API endpoint and the special page to mw.org's Extension:Math.

@Physikerwelt A description of the special page Special:MathWikibase.

Jun 23 2020, 6:02 AM · Documentation, Math

Apr 10 2020

Andreg-p added a comment to T245343: texvcjs should not replace $\omicron$ with $\mathrm{o}$ .

@Physikerwelt According to this post "omicron not working in latex" from 2015:

Apr 10 2020, 9:50 AM · Math, Community-consensus-needed, User-Physikerwelt, Texvcjs

Mar 16 2020

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@alexhollender, I'm sorry for my late response. I have trouble setting up my new system to the point when I created the popups. So let me explain the concept a bit more in detail. Clicking on the popup will lead to a special page with all information, e.g. for the mass-energy equivalence it is this page: Special:MathWikibase&qid=Q35875

ScreenshotSpecialPage.png (510×779 px, 28 KB)

Mar 16 2020, 5:34 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Feb 10 2020

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@alexhollender yes the picture is up to date.
I updated the picture in the issue description also.

Feb 10 2020, 11:01 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews
Andreg-p updated the task description for T208758: Display popups for annotated <math> tags without touching popups extension code.
Feb 10 2020, 10:57 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Nov 28 2019

Andreg-p added a comment to T229939: Implement wikidata entity selector in OOUI input field.

@thiemowmde Thank you. The problem is, I thought I did that already. I load the modules in the special page:
https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/src/SpecialMathWikibase.php#L64

		$output->addModules( [ 'ext.math.wikibase.scripts' ] );
Nov 28 2019, 10:42 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Wikidata, OOUI, Math

Oct 18 2019

Andreg-p closed T229939: Implement wikidata entity selector in OOUI input field, a subtask of T208758: Display popups for annotated <math> tags without touching popups extension code, as Resolved.
Oct 18 2019, 8:23 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews
Andreg-p closed T229939: Implement wikidata entity selector in OOUI input field as Resolved.
Oct 18 2019, 8:23 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Wikidata, OOUI, Math
Andreg-p changed the status of T208758: Display popups for annotated <math> tags without touching popups extension code from Stalled to Open.
Oct 18 2019, 8:20 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Sep 4 2019

Andreg-p added a parent task for T231970: Add information about the new API endpoint and the special page to mw.org's Extension:Math: T208758: Display popups for annotated <math> tags without touching popups extension code.
Sep 4 2019, 8:48 AM · Documentation, Math
Andreg-p added a subtask for T208758: Display popups for annotated <math> tags without touching popups extension code: T231970: Add information about the new API endpoint and the special page to mw.org's Extension:Math.
Sep 4 2019, 8:48 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews
Andreg-p created T231970: Add information about the new API endpoint and the special page to mw.org's Extension:Math.
Sep 4 2019, 8:47 AM · Documentation, Math

Aug 26 2019

Andreg-p added a comment to T229939: Implement wikidata entity selector in OOUI input field.

Thank you for the hint. Patch set 5 should include all necessary changes to close this task: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/527556/

Aug 26 2019, 5:17 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Wikidata, OOUI, Math

Aug 6 2019

Andreg-p added a comment to T229939: Implement wikidata entity selector in OOUI input field.

@Physikerwelt an autocompletion on wiki data IDs? I would understand if we allow textual inputs here and then activate auto-completion based on the words. Such as "mass-energy" and the first suggestion would be "equivalence". But I cannot imagine an auto-completion just based on the IDs. The only use case I can imagine is that the auto-completion only shows IDs that actually contain mathematical expressions. But I have no clue how to implement that now.

Aug 6 2019, 5:10 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Wikidata, OOUI, Math

Jul 30 2019

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

Hi everybody, I'm close to a prototype now. I created an extra API endpoint in the math extension and send requests to this endpoint if the user hovers over annotated math in the Popups extension.

Jul 30 2019, 8:55 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Jul 3 2019

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

Another update.
After I requested some help from the #wikimedia-tech IRC channel it seems to be better not to use special pages to fetch the data from wikidata but extend the popups extension so that it performs the fetch from wikidata by its own. The problem is that special pages do not contain "text" in a sense that the TextExtracts extension can extract this text. The mods in the IRC channel mentioned changing the TextExtracts extension would be a major re-engineering effort. Since the popups extension handles page previews and reference previews differently already, it would make sense to just add a special case for wikidata previews to the extensions. It's questionable if the popups extension should handle math specific content, but it seems to be the best option we have.

Jul 3 2019, 4:14 PM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Jul 2 2019

Andreg-p updated subscribers of T208758: Display popups for annotated <math> tags without touching popups extension code.

@thiemowmde do have an idea why we cannot fetch text via TextExtracts from special pages? I want to visualize as special page in a popup but the result from mw.Api.get does not return text from special pages.

Jul 2 2019, 6:42 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Jul 1 2019

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

I was able to detect the problems that avoid visualizing special pages.
The type of special pages is previewTypes.TYPE_GENERIC but the code currently only supports the cases in line 135 in src/ui/renderer.js.

Jul 1 2019, 1:09 PM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Jun 28 2019

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

I needed to create a Title object from a special page. The popup extension I'm using use the javascript API. So I need an object of mw.Title (https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title) from a special page. However, I'm not able to generate the right Title... Does somebody know how to do it?

Jun 28 2019, 6:40 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Nov 9 2018

Andreg-p added a comment to T208758: Display popups for annotated <math> tags without touching popups extension code.

@Aklapper Yes, it's not really a fix but kind of an extension we (@Physikerwelt) and I are planning to accomplish.

Nov 9 2018, 4:44 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews

Nov 5 2018

Andreg-p created T208758: Display popups for annotated <math> tags without touching popups extension code.
Nov 5 2018, 6:37 PM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Math, Platform Team Workboards (Clinic Duty Team), Page-Previews