On Friday, I was able to reproduce the problem locally: When I reveal the IPs for a temp account whose data is expired, only one of the occurrences is shown as "no longer available" (i.e. expired), but reloading the page then shows both as expired.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Sep 30 2025
Sep 29 2025
Sep 25 2025
In T386925#11212288, @Djackson-ctr wrote:I am noticing that for any special pages with more than one "Show IP" button for the same expired temporary account, when the user selects one of the "Show IP" buttons it will display no longer available for the "Show IP" button that was selected, but the remaining "Show IP" buttons will display unavailable.
However, if I were to then reload the page then it will display the remaining "Show IP" buttons as no longer available.Is this the expected behavior for this new code, or should the user not have to reload the page to get the new verbiage to show for the remaining "Show IP" buttons?
Sep 23 2025
Sep 19 2025
Sep 18 2025
Sep 17 2025
Sep 16 2025
I did a minor update in the existing patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1126672/4 and verified locally the request fails if the reason is not provided.
Sep 15 2025
Things missing for this task are being handled in T404215: Add a dialog to change the status associated with a suggested investigation & T404216: Update the status of a suggested investigations case in the table pager when the dialog is closed.
Sep 10 2025
An initial implementation is here, but it is missing tests etc https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1185881
Sep 4 2025
The patch is being merged now. As it does not have any user-facing methods, I'm skipping QA and closing the ticket directly.
Sep 3 2025
Submitted a patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1184502 with a new method to get and set the status of an existing investigation that is now ready for review.
Sep 2 2025
Aug 28 2025
Checking https://test.wikipedia.org/wiki/Special:Version, the CheckUser version there is 2.5 (e322528) 10:21, 25 August 2025, which means the latest fix should be deployed there.
Aug 25 2025
Aug 22 2025
Aug 21 2025
As agreed, I'm reworking the former patch, splitting it into separate patches first and then reworking the former one, so moving this back to 'In Progress'.
I've submitted an additional patch to fix requests to the batch endpoint in case AbuseFilter is not loaded in the wiki making use of IP Reveal, since the new abuseLogIds request parameter won't be recognized as a valid property from the JSON request payload in that case: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1180820
Aug 20 2025
Aug 19 2025
Aug 18 2025
Aug 14 2025
After the recent changes, tests from CheckUserUserInfoCardServiceTest are passing in my local environment but failing when they are run in Jenkins.
Aug 13 2025
+2, I've reviewed both patches and they look ok for me
Aug 12 2025
I've rebased the patch and is ready for review again.
Aug 6 2025
Note it doesn't seem possible to support this properly in Special:Log when revealing an IP for the first time until T399712: IPReveal: Remove the log endpoint and use the batch mechanism instead gets done and makes that page use the batch endpoint instead of /v0/temporaryaccount/~2025-123/logs/123: When the local storage is empty, clicking to show an IP for the first time still shows "unavailable" instead of "no longer available".
Aug 1 2025
(Note: The log endpoint does not seem to be used by WMF code anymore so it seems safe to drop it altogether instead of depecating it first)
An initial patch has been merged that tags the TemporaryAccountRevisionHandler as deprecated and removes a code path from the frontend code that was already unreachable.
The patch fixing this issue is being merged right now, so moving the ticket forward for QA.
I see all patches associated with this task have been already merged, and T390051#11043496 suggests the cause for the error was already found and fixed by those patches (1173962). Should this be moved forward for QA?
Jul 31 2025
Filed T400901: Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount for replacing usages of the /revision endpoint in PageTriage, which is needed in order to completely drop the endpoint in CheckUser.
Tests are passing again and all the issues previously raised during the code review have been addressed, so this may go back to code review now.
Jul 30 2025
The patch associated with the frontend subtask for this ticket is being merged right now, so I'm closing that ticket and moving this one QA.
The patch for this ticket got upvoted and is being merged right now, so I'm closing this ticket and moving the parent to QA.
The frontend patch was updated based on the feedback provided so far, moving this back to code review.
I'm happy to pick up this ticket, but I prefer to do so after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567 gets merged so we don't lose time handling merge conflicts in the IP Reveal code (this will require changes in modules/ext.checkUser.tempAccounts/rest.js which is already being modified in that patch, which is currently in review).
I'm happy to pick up this ticket, but I prefer to do so after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567 gets merged so we don't lose time handling merge conflicts in the IP Reveal code (this will require changes in modules/ext.checkUser.tempAccounts/rest.js which is already being modified in that patch, which is currently in review).
Jul 28 2025
I've rebased the previous patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1164992 and is now ready for review again. Tests are failing after the rebase, I've drafted the patch.
I've updated the patch to make the existing addIpRevealButtons() handle log entries from the Abuse Filter log page appropriately, made the dispatcher run a small stub that extracts the log IDs using a custom CSS selector targeting AF log IDs, and updated tests, so the patch can be reviewed now.
Jul 23 2025
I'm reworking the previous patch to use a different approach, tests are still pending.
Jul 22 2025
I have a working implementation for the frontend changes ready, pending tests: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567
The patch is being merged now and this task can be cirectly closed, since it will be tested as part of the QA for the parent task T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.