Moving to merged and waiting after getting an okay from Robin offline :-)
Sat, Oct 23
Fri, Oct 22
Thu, Oct 21
Tue, Oct 19
Mon, Oct 18
@SNowick_WMF - The selection_token issue was fixed a few weeks ago. So the errors you are seeing are only on the old revision id , the newest revision has no errors.. Let us discuss this tomorrow during our sync, and if it all checks out we can close this one out. :)
@SNowick_WMF This is unblocked and in beta for analyzing >=2.7.50378-beta-2021-10-13 version.
Sat, Oct 16
Hi @SNowick_WMF Thank you for the detailed notes on this. It was very helpful.
Fri, Oct 15
I have fixed all the issues. However, there is not much we can do about the 04) back button jump as it is an issue with the component itself, and 01) the keyboard adapting issue is very device specific, and was not happening on any of my devices... but I have put in a blind fix to hide the soft keyboard when we go to the filters screen... but if that doesnt check-out on your end, there wont be much to do there either. Rest should work .
Could you please test it from the PR: https://github.com/wikimedia/apps-android-wikipedia/pull/2898/checks since it is still in review.
Thu, Oct 14
Wed, Oct 13
Hi @schoenbaechler thank you for reviewing. I have fixed all issues but for the back button jumping. I feel it is a bug with the out of the box SearchView we are using, but will discuss this with the other engineers to see if there is a way to fix it...
Thu, Oct 7
When there are 0 filters, the "No results" indicator text is shown, but I have hidden the empty image
Tue, Oct 5
@schoenbaechler The above issues are fixed.. Please check and move the ticket.
Thu, Sep 30
Thank you @SNowick_WMF . Updated the revisionId.
Wed, Sep 29
Hi @schoenbaechler quick question
Thank you @JTannerWMF for confirming
@schoenbaechler this is ready for design review in parallel :)
Tue, Sep 28
@SNowick_WMF and I discussed this, and we feel fully equipped to analyze the final outcome 30 days after bell icon is in production. Shay please take a look once more and confirm.
@SNowick_WMF and I met to discuss analytics wiring for this, and here are the things we will be tracking:
- Click on "Search Notifications"
- Clicks on Filter icon
- Changes to filter types: An event sent only when the user makes changes to the filters. Which will also give us a chance to measure how many users did not change the filter preferences, if we analyze 2) in conjunction with 3).
Unable to reproduce this on Samsung Tab A. Closing this out.
Sep 27 2021
I implemented the filter changes. And the filter icon and count colors and text look good now.. but only one case in which the empty text doesnt make much sense. It is when there are no filters in place, and search yields no results:
Sep 24 2021
Hi @schoenbaechler Please try now... I have pulled in the list view changes too so it is easier to test. Please let me know if it is still giving problems. Build is correct.. my bad.. I hadnt updated it with list view changes
Sep 22 2021
Sep 21 2021
Sep 20 2021
One more question @schoenbaechler. Should the search be case-insensitive. Eg: when user searches "you" should only "you" be highlighted, or "You" as well?
Hi @schoenbaechler Few qs wrt the filter:
Sep 17 2021
@JTannerWMF Thank you for looking into this.
Sep 15 2021
Sep 14 2021
Sep 8 2021
This is finally done after 55 kotlin conversions.. Moving to code review... In hindsight should have blocked this until all conversions were done 😅
Sep 7 2021
Sep 2 2021
@SNowick_WMF Perfect! thank you for checking! Closing this.
Aug 26 2021
Aug 25 2021
Hi @SNowick_WMF ... I went through all the errors and here are the findings. The fixes that I have put in I will push to beta, but will try to track the few that we discussed this morning.