Page MenuHomePhabricator
Feed Advanced Search

Dec 4 2015

Hardikj added a comment to T120257: Investigate RESTBase as a possible storage solution for wikitext "errors" and issues that are found by Parsoid.

The web service for linter lives here, if it helps - https://github.com/hardikj/lintbridge/blob/master/server.js#L127

Dec 4 2015, 1:55 PM · Services (watching), RESTBase, Parsoid

May 19 2015

Hardikj added a comment to T99696: cleanup and refactor test/index.js.

Ideas below are inspired from the directory structure of the tests in restbase

May 19 2015, 11:05 PM · RESTBase-Cassandra
Hardikj claimed T99696: cleanup and refactor test/index.js.
May 19 2015, 6:58 PM · RESTBase-Cassandra

May 13 2015

Hardikj moved T89888: Support 'static' columns in SQLite3 module back-end for RESTBase from Backlog to In progress on the RESTBase board.
May 13 2015, 11:37 PM · RESTBase

Apr 8 2015

Hardikj committed rGRES778d4fa0efea: Implement request templating for service requests.
Implement request templating for service requests
Apr 8 2015, 4:34 PM
Marko Obrovac <marko.obrovac@gmail.com> committed rGRES90602215377e: Implement request templating for service requests (authored by Hardikj).
Implement request templating for service requests
Apr 8 2015, 4:34 PM
Hardikj committed rGRES4d34201661b3: Add offline test mode / config flag.
Add offline test mode / config flag
Apr 8 2015, 4:34 PM
Hardikj committed rGRES76763cfcd245: Enable tests for proxy handler.
Enable tests for proxy handler
Apr 8 2015, 4:34 PM
Hardikj committed rGRES8d864051e99c: run swagger specs test before server restart.
run swagger specs test before server restart
Apr 8 2015, 4:34 PM
Hardikj committed rGRES6e77ce382e99: Added post handler to test proxy handler and a test for it.
Added post handler to test proxy handler and a test for it
Apr 8 2015, 4:34 PM
Hardikj committed rGRESad43296798bf: sort system tables in test-cleandb and fix typo in config.
sort system tables in test-cleandb and fix typo in config
Apr 8 2015, 4:34 PM
Hardikj committed rGRESbb9e4633f6c6: add org_wikipedia_en_T_test101_rev to test-cleanupdb.sh.
add org_wikipedia_en_T_test101_rev to test-cleanupdb.sh
Apr 8 2015, 4:34 PM
Hardikj committed rGRESe387c83dac98: Run few tests after restarting restbase.
Run few tests after restarting restbase
Apr 8 2015, 4:34 PM
Hardikj committed rGRES995420463b61: Support refrences like {request.paramns.domain} in urls for proxy handlers.
Support refrences like {request.paramns.domain} in urls for proxy handlers
Apr 8 2015, 4:34 PM
Hardikj committed rGRES8c65e5cac845: Improved request parsing for declarative proxy handlers.
Improved request parsing for declarative proxy handlers
Apr 8 2015, 4:34 PM
Hardikj committed rGRESc42ed724d9f9: Made declarative handler distinguish literals from refrences.
Made declarative handler distinguish literals from refrences
Apr 8 2015, 4:34 PM
Hardikj committed rGRES4da509cc8a9e: request parsing for declarative proxy handler.
request parsing for declarative proxy handler
Apr 8 2015, 4:34 PM
Hardikj committed rGRES066943320bef: First pass of interpreter for declarative handlers.
First pass of interpreter for declarative handlers
Apr 8 2015, 4:34 PM
Hardikj committed rGRESe2a0b78b15f4: First pass of interpreter for declarative handlers.
First pass of interpreter for declarative handlers
Apr 8 2015, 4:34 PM
Hardikj committed rGRESdcaec6149aa6: Adding a design docs for declarative proxy handlers.
Adding a design docs for declarative proxy handlers
Apr 8 2015, 4:34 PM
Hardikj committed rGRESb8634c50e5fd: Second Pass on declarative proxy handlers doc.
Second Pass on declarative proxy handlers doc
Apr 8 2015, 4:34 PM
Hardikj committed rGRES8ed6d3697f99: Use this instead of req for __depth lookup.
Use this instead of req for __depth lookup
Apr 8 2015, 4:34 PM
Hardikj committed rGRESe7ad7fa4ec65: Made monitoring code use yaml config.
Made monitoring code use yaml config
Apr 8 2015, 4:34 PM
Hardikj committed rGRES76aae9e5a438: Merge branch 'logging'.
Merge branch 'logging'
Apr 8 2015, 4:34 PM
Hardikj committed rGRES58317de619e5: Tracking error responses for Statsd.
Tracking error responses for Statsd
Apr 8 2015, 4:34 PM
Hardikj committed rGRESe4fbe6a94107: Proper config & logging via bunyan (authored by GWicke).
Proper config & logging via bunyan
Apr 8 2015, 4:34 PM
Hardikj committed rGRES0bf1b2dfb6ed: Log request times to StatsD.
Log request times to StatsD
Apr 8 2015, 4:34 PM
Hardikj committed rGPARde4c1fcf76fe: linter should not lint white spaces as ignored table attr.
linter should not lint white spaces as ignored table attr
Apr 8 2015, 4:28 PM
Hardikj committed rGPAR100478c13487: Turn on linter on html generated by transclusions.
Turn on linter on html generated by transclusions
Apr 8 2015, 4:28 PM
Hardikj committed rGPARb1a73b2545d9: Add a basic test suite for linter.
Add a basic test suite for linter
Apr 8 2015, 4:28 PM
Hardikj committed rGPARc5985f033b9c: Dont run linter on subpipelines. (authored by ssastry).
Dont run linter on subpipelines.
Apr 8 2015, 4:28 PM
Hardikj committed rGPAR57bb9f10bb04: Lint images with bogus options.
Lint images with bogus options
Apr 8 2015, 4:28 PM
Hardikj committed rGPARea92833b379b: fixed a bug in dom.linter and added a new linter test for it.
fixed a bug in dom.linter and added a new linter test for it
Apr 8 2015, 4:28 PM
Hardikj committed rGPARd5701452925b: Split Mixed Template into Multi Template and Mixed Content.
Split Mixed Template into Multi Template and Mixed Content
Apr 8 2015, 4:28 PM
Hardikj committed rGPARf16f162c883b: Lint Obsolete HTML tags.
Lint Obsolete HTML tags
Apr 8 2015, 4:28 PM
Hardikj committed rGPAR378e71ac5b9f: Added a new --lint option for parse.js to enable linting.
Added a new --lint option for parse.js to enable linting
Apr 8 2015, 4:28 PM
Hardikj committed rGPAR8ba27317290d: fixed --lint option and added wiki url to linter json output.
fixed --lint option and added wiki url to linter json output
Apr 8 2015, 4:28 PM
Hardikj committed rGPAR286e65e1e4b5: Some minor fixup in linter.
Some minor fixup in linter
Apr 8 2015, 4:28 PM
Hardikj committed rGPARefec88cbb1ca: Moved registerLoggingBackends function from ParsoidConfig to mediawiki.Utils.
Moved registerLoggingBackends function from ParsoidConfig to mediawiki.Utils
Apr 8 2015, 4:27 PM
Hardikj committed rGPAR3fbaac03ea06: Added linter backend and lint output for a few scenarios.
Added linter backend and lint output for a few scenarios
Apr 8 2015, 4:27 PM
Hardikj committed rGPAR340308985633: We should be consistent with the value of autoInserted flags.
We should be consistent with the value of autoInserted flags
Apr 8 2015, 4:27 PM

Mar 3 2015

Hardikj added a comment to T89888: Support 'static' columns in SQLite3 module back-end for RESTBase.

This have been implemented here https://github.com/wikimedia/restbase-mod-table-sqlite/pull/1

Mar 3 2015, 1:22 AM · RESTBase

Feb 19 2015

Hardikj added a comment to T89888: Support 'static' columns in SQLite3 module back-end for RESTBase.

@mobrovac I like your idea about having one static table for multiple data table. But here is the original Idea that I discussed with @GWicke yesterday on IRC which include one to one mapping for static and data table.

Feb 19 2015, 4:58 PM · RESTBase

Feb 18 2015

Hardikj created T89888: Support 'static' columns in SQLite3 module back-end for RESTBase.
Feb 18 2015, 9:08 PM · RESTBase

Feb 9 2015

Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

Yup, that makes sense to me.

Feb 9 2015, 4:14 PM · SQLite, RESTBase
Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

I posted the link to the repo for the current work in my first comment here - https://phabricator.wikimedia.org/T88191#1016968

Feb 9 2015, 3:42 PM · SQLite, RESTBase
Hardikj added a comment to T78212: Determine license for RESTBase code.

Yes, Apache2 sounds like a good option to me too.

Feb 9 2015, 3:35 PM · Software-Licensing, RESTBase

Feb 7 2015

Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

Current Status: Create table, Get and Put path seems to work fine for the most used cases.
Next Task: refine secondary index creation

Feb 7 2015, 8:58 PM · SQLite, RESTBase
Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

In cassandra we use "insert" only for 'if not exists', or when no non-primary-key attributes are specified and "update" for other cases (upsert). Since "update" query also perform insert this is handled easily by cassandra. But, In sqlite3 a "update" query don't perform insert if the row doesn't exists.

Actually, if not exists is used only for table creation inside the Cassandra module. However, since this is a purely-Cassandra construct, I wouldn't rely on it.

Feb 7 2015, 5:50 AM · SQLite, RESTBase

Feb 5 2015

Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

To use insert or replace, http://sqlite.org/lang_conflict.html.

Hmmm, replace is too destructive, IMHO, as it triggers cascading deletes in case a PK exists.

Feb 5 2015, 8:10 AM · SQLite, RESTBase
Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

My vote is to the first option here, this includes

Feb 5 2015, 3:36 AM · SQLite, RESTBase
Hardikj added a comment to T88191: SQLite3 storage module back-end for RESTBase.

Current work on this is hosted here https://github.com/hardikj/restbase-mod-table-sqlite

Feb 5 2015, 2:39 AM · SQLite, RESTBase

Jan 12 2015

Hardikj closed T75815: Investigate float test failures as Resolved.
Jan 12 2015, 8:27 PM · RESTBase-Cassandra
Hardikj closed T85574: Add coverage tracking for restbase-cassandra & improve coverage as Resolved.
Jan 12 2015, 8:26 PM · RESTBase-Cassandra
Hardikj closed T85640: Paging support as Resolved.
Jan 12 2015, 8:26 PM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase

Jan 5 2015

Hardikj added a comment to T85640: Paging support.

I just opened a pull request which currently handle most of the stuff https://github.com/wikimedia/restbase-cassandra/pull/52

Jan 5 2015, 9:07 PM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase
Hardikj added a comment to T85640: Paging support.

Basically, any request that has more results than provided in the first page (so with a limit higher than the page size) should have the next link

Jan 5 2015, 8:14 PM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase
Hardikj added a comment to T85640: Paging support.

just a found this comment in the test which suggest to use "from" in the GET request
https://github.com/wikimedia/restbase-cassandra/blob/master/test/index.js#L535

Jan 5 2015, 1:04 AM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase

Jan 4 2015

Hardikj added a comment to T85640: Paging support.

Another thing to decide on would be how would be initiate the paging request?

Jan 4 2015, 11:47 PM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase

Jan 3 2015

Hardikj claimed T85640: Paging support.
Jan 3 2015, 10:09 PM · RESTBase-release-1.0, RESTBase-API, RESTBase-Cassandra, RESTBase

Dec 31 2014

Hardikj added a comment to T78194: Public entry point for RESTBase.

big +1 to rest.wikimedia.org or rest.api.wikimedia.org

Dec 31 2014, 7:26 PM · SRE, Patch-For-Review, RESTBase-API, RESTBase

Dec 30 2014

Hardikj added a comment to T75815: Investigate float test failures.

float seems to be working fine now.
I just sent a pull request to enable float type in restbase-cassandra https://github.com/wikimedia/restbase-cassandra/pull/49#

Dec 30 2014, 3:35 PM · RESTBase-Cassandra

Dec 29 2014

Hardikj claimed T75815: Investigate float test failures.
Dec 29 2014, 6:50 PM · RESTBase-Cassandra
Hardikj added a comment to T75808: Schema compatibility checking / schema evolution / migration on table creation for table that already exists.

first pass on this is implemented here https://github.com/wikimedia/restbase-cassandra/pull/47

Dec 29 2014, 6:29 PM · Services, RESTBase-Cassandra

Dec 16 2014

Hardikj added a comment to T76734: Test against the HTTP interface.

All the tests except "simple delete query" now use HTTP interface.

Dec 16 2014, 11:08 PM · Services, RESTBase-Cassandra

Dec 15 2014

Hardikj closed T76885: Testing: Add offline test mode / config flag as Resolved.
Dec 15 2014, 10:09 PM · RESTBase
Hardikj added a comment to T76734: Test against the HTTP interface.

Implemented here https://github.com/wikimedia/restbase-cassandra/pull/31

Dec 15 2014, 7:44 PM · Services, RESTBase-Cassandra
Hardikj claimed T76734: Test against the HTTP interface.
Dec 15 2014, 7:44 PM · Services, RESTBase-Cassandra
Hardikj claimed T75808: Schema compatibility checking / schema evolution / migration on table creation for table that already exists.
Dec 15 2014, 7:39 PM · Services, RESTBase-Cassandra

Dec 12 2014

Hardikj added a comment to T76735: Test restarting restbase.

do we need to do more work on this or else I can mark this as resolved?

Dec 12 2014, 10:48 PM · RESTBase, RESTBase-Cassandra
Hardikj added a comment to T78410: Move Parsoid and RESTBase testing from Travis CI to our Jenkins.

+1, this would be really useful.

Dec 12 2014, 6:55 PM · Platform Team Legacy (Later), Parsoid-Tests, Parsoid, Continuous-Integration-Infrastructure, RESTBase

Dec 11 2014

Hardikj claimed T76885: Testing: Add offline test mode / config flag.
Dec 11 2014, 6:57 AM · RESTBase