Page MenuHomePhabricator
Feed Advanced Search

Jan 17 2016

marcoil committed rIVDI5223360b4cfa: Use a handlebars partial to render the summary text.
Use a handlebars partial to render the summary text
Jan 17 2016, 4:06 PM
marcoil committed rIVDI3f446cda64d1: Use internal base64 decoder to save PNG diff file and use the correct….
Use internal base64 decoder to save PNG diff file and use the correct…
Jan 17 2016, 4:05 PM

Aug 13 2015

marcoil created T108952: References with "equal" entities in their name aren't considered equal when numbering them.
Aug 13 2015, 3:11 PM · Parsoid, VisualEditor-MediaWiki-References, VisualEditor

Jul 16 2015

marcoil removed a watcher for Parsing-Team--ARCHIVED: marcoil.
Jul 16 2015, 3:07 PM

Jun 29 2015

marcoil added a comment to T51904: Support "substituting" templates in transclusion dialog.

I'm not sure the parsoid API from T73161 is quite what we were looking for. The idea had been to allow the user to mark a template to be substituted upon save, but with this we'd have to substitute an entire transclusion (immediately?)

Jun 29 2015, 6:53 AM · MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), VisualEditor, VisualEditor-EditingTools

Jun 16 2015

TheDJ awarded T69540: Produce/preserve the metadata about additional ResourceLoader modules required by extension tags a Grey Medal token.
Jun 16 2015, 10:35 AM · Parsoid, WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering

Jun 15 2015

marcoil committed rGPAR7f9ad2472b4c: Include RL style modules from parser functions in <head>.
Include RL style modules from parser functions in <head>
Jun 15 2015, 6:52 PM

Jun 9 2015

marcoil removed a member for Service-Architecture: marcoil.
Jun 9 2015, 3:35 PM
marcoil removed a watcher for Service-Architecture: marcoil.
Jun 9 2015, 3:35 PM
marcoil removed a watcher for Parsoid: marcoil.
Jun 9 2015, 3:21 PM
marcoil placed T49136: Create tests for subpage support up for grabs.
Jun 9 2015, 2:09 PM · Parsoid-Tests, Parsoid
marcoil closed T56342: Add a performance stat for serialized DOM without data-parsoid to the rt_testing server as Declined.

The new performance counters integrated into Parsoid supersede this.

Jun 9 2015, 2:09 PM · Parsoid, Parsoid-Tests
marcoil placed T60025: Unify Parsoid testing with a single top-level test.js script up for grabs.
Jun 9 2015, 2:08 PM · Parsoid, Parsoid-Tests
marcoil placed T88291: Templates with template name coming from expansion don't get data-mw target assigned up for grabs.
Jun 9 2015, 2:08 PM · Parsoid
marcoil placed T57438: Test DOM fragment reuse in round-trip testing up for grabs.
Jun 9 2015, 2:07 PM · Parsoid, Parsoid-Tests
marcoil placed T57588: Improve html2html newline normalization up for grabs.
Jun 9 2015, 2:07 PM · Parsoid, Parsoid-Tests
marcoil placed T71870: Enable DOM editing of transclusion parameters up for grabs.
Jun 9 2015, 2:07 PM · Parsoid, Parsoid-DOM
marcoil placed T72096: Category links seem to be always localized on roundtripping up for grabs.
Jun 9 2015, 2:06 PM · Parsoid
marcoil placed T76962: Self-closing HTML tags shouldn't be accepted up for grabs.
Jun 9 2015, 2:06 PM · Parsoid
marcoil placed T85937: Parallelize template or template parameter expansion up for grabs.
Jun 9 2015, 2:04 PM · Parsoid
marcoil placed T86271: Existing categories that are preceded by new/modified content should be forced onto a new line up for grabs.
Jun 9 2015, 2:04 PM · Patch-For-Review, Parsoid-Serializer, Parsoid

Jun 8 2015

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT46be27247a26: Updated mediawiki/extensions Project: mediawiki/extensions/Cite… (authored by marcoil).
Updated mediawiki/extensions Project: mediawiki/extensions/Cite…
Jun 8 2015, 9:03 PM

Jun 5 2015

marcoil committed rMW8929182a67ef: Expose RL modules and js config vars in action=expandtemplates.
Expose RL modules and js config vars in action=expandtemplates
Jun 5 2015, 4:17 PM

Jun 2 2015

marcoil updated subscribers of T69540: Produce/preserve the metadata about additional ResourceLoader modules required by extension tags.

A little status update:

Jun 2 2015, 5:08 PM · Parsoid, WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering

May 27 2015

marcoil added a comment to T100209: Copied reference is malformed - page cannot be saved or switched to source editing.

This also happened in the Catalan Wikipedia, there's a transcript of the error at https://ca.wikipedia.org/wiki/Topic:Shssmsofmcgkqhmv .

May 27 2015, 9:56 AM · VisualEditor-MediaWiki-References, VisualEditor-CopyPaste, VisualEditor

May 26 2015

marcoil committed rGPAR6bdbbca48255: T73161: Support subst: of transclusion blocks.
T73161: Support subst: of transclusion blocks
May 26 2015, 10:58 PM
marcoil closed T93824: HTML tags represented with escaped < and > chars aren't always nowikied properly as Resolved.

Deployed in https://www.mediawiki.org/wiki/Parsoid/Deployments#Monday.2C_May_18.2C_2015_around_1:10pm_PST:_Y_Deployed_8ed3e503

May 26 2015, 10:21 AM · Patch-For-Review, Parsoid-Serializer, Parsoid-Nowiki, Parsoid

May 21 2015

marcoil added a comment to T86782: Use CSS to style Parsoid's Cite extension output.

Note that there are usecases where we need to display the references in two languages in same wiki page. CX has to show source language content and target language content with two different references style. So if we load the style based on content language, we get style for only one language. How to solve this issue?

May 21 2015, 1:57 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), User-notice-archive, Epic, WMF-deploy-2015-07-07_(1.26wmf13), WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering, RESTBase, Collaboration-Team-Triage, StructuredDiscussions, Language-Team, Patch-For-Review, Cite, Parsoid

May 19 2015

marcoil committed rGPAR4d6b87b76f18: T94509: Add mw:DisplaySpace to typeof for nbsp before colon.
T94509: Add mw:DisplaySpace to typeof for nbsp before colon
May 19 2015, 5:27 PM

May 14 2015

marcoil added a comment to T98995: Extension and transclusion content is no longer being reused from cache for parse jobs from the job queue.

We could just concatenate the target and the arguments in wikitext, or even just serialize it back to wikitext at that point (which would take more time).

May 14 2015, 10:03 AM · Platform Team Legacy (Watching / External), Services (watching), Parsoid

May 13 2015

marcoil committed rGPAR10392facfc68: T93824: Put escaped HTML tags inside <nowiki>.
T93824: Put escaped HTML tags inside <nowiki>
May 13 2015, 5:25 PM
marcoil added a comment to T93824: HTML tags represented with escaped < and > chars aren't always nowikied properly.

Are we sure about the second case (&lt;a&gt;…)? Given that explicit <a> tags aren't allowed in wikitext, Parsoid already encodes it correctly:

echo '&lt;a rel="mw:ExtLink" href="http://www.google.com"&g t;Google&lt;/a&gt;' | node parse --html2html
…
<p data-parsoid='{"dsr":[0,59,0,0]}'>&lt;a rel="mw:ExtLink" href="http://www.google.com">Google&lt;/a></p>
May 13 2015, 3:55 PM · Patch-For-Review, Parsoid-Serializer, Parsoid-Nowiki, Parsoid
marcoil claimed T93824: HTML tags represented with escaped < and > chars aren't always nowikied properly.
May 13 2015, 3:16 PM · Patch-For-Review, Parsoid-Serializer, Parsoid-Nowiki, Parsoid

May 12 2015

marcoil committed rGPAR23b233c40683: T96090: Allow quotes as template targets.
T96090: Allow quotes as template targets
May 12 2015, 2:36 PM

May 7 2015

marcoil added a comment to T94509: Space before colon in French is wrapped in mw:Placeholder wrapper.

What's the special type for it? mw:DisplaySpace?

May 7 2015, 3:08 PM · Parsoid-DOM, Parsoid

May 6 2015

marcoil claimed T96090: {{''}} is parsed as plain text, not a transclusion.
May 6 2015, 3:18 PM · Parsoid, VisualEditor 2014/15 Q4 blockers

May 1 2015

marcoil closed T70511: VisualEditor: Adding nowiki tags in unrelated edit as Resolved.

I'm unable to reproduce. I suppose this was fixed in the round of nowiki work last quarter. Please reopen if seen again.

May 1 2015, 10:05 AM · VisualEditor 2014/15 Q4 blockers, Parsoid-Nowiki, Parsoid, VisualEditor

Apr 30 2015

marcoil claimed T70511: VisualEditor: Adding nowiki tags in unrelated edit.

Investigating…

Apr 30 2015, 4:04 PM · VisualEditor 2014/15 Q4 blockers, Parsoid-Nowiki, Parsoid, VisualEditor
marcoil added a comment to T94509: Space before colon in French is wrapped in mw:Placeholder wrapper.

On IRC discussions, it was argued that mw:Entity wasn't the best typeof to use in this case. A fer other possibilities were discussed, including:

  • Create a new typeof like mw:DisplayHack, mw:SpaceBeforeColon, etc.
  • Add a new typeof to an exiting one, i.e. typeof="mw:Placeholder mw:DisplayHack".
  • Just have VE not treat this case as a mw:Placeholder and allow the user to delete them.
Apr 30 2015, 9:26 AM · Parsoid-DOM, Parsoid

Apr 29 2015

marcoil added a comment to T86782: Use CSS to style Parsoid's Cite extension output.

Preliminary patches are available in gerrit. They are all considered WIP, but pushing them to get early feedback on the general approach.

Apr 29 2015, 4:45 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), User-notice-archive, Epic, WMF-deploy-2015-07-07_(1.26wmf13), WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering, RESTBase, Collaboration-Team-Triage, StructuredDiscussions, Language-Team, Patch-For-Review, Cite, Parsoid

Apr 28 2015

marcoil added a comment to T97141: PDF export on el.wp returns content from random other Wikipedias and not from article itself.

Seems related to T97155.

Apr 28 2015, 1:50 PM · OCG-PDFRenderer

Apr 27 2015

marcoil added a comment to T86782: Use CSS to style Parsoid's Cite extension output.

For completeness, here's a screenshot with VE editing the new HTML and CSS, patched so that it copies the new HTML over:

cite_test_ve_new_css_patched.png (923×867 px, 62 KB)

As shown, the links are styled using CSS so that special groups are shown (like ɑ and β).

Apr 27 2015, 6:03 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), User-notice-archive, Epic, WMF-deploy-2015-07-07_(1.26wmf13), WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering, RESTBase, Collaboration-Team-Triage, StructuredDiscussions, Language-Team, Patch-For-Review, Cite, Parsoid

Apr 24 2015

marcoil added a comment to T86782: Use CSS to style Parsoid's Cite extension output.

A little update after the latest patch available at https://gerrit.wikimedia.org/r/#/c/170936/, which includes the new stuff done in master such as using data-mw.body.id, removing state from the Cite extension, etc.

Apr 24 2015, 4:09 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), User-notice-archive, Epic, WMF-deploy-2015-07-07_(1.26wmf13), WMF-deploy-2015-06-09_(1.26wmf9), Parsoid-Rendering, RESTBase, Collaboration-Team-Triage, StructuredDiscussions, Language-Team, Patch-For-Review, Cite, Parsoid
marcoil closed T95794: Unnecessary nowiki in an indent-pre block as Resolved.

Deployed in https://www.mediawiki.org/wiki/Parsoid/Deployments#Wednesday.2C_April_22.2C_2015_around_1:05pm_PST:_Y_Deployed_3311936a.

Apr 24 2015, 10:13 AM · Patch-For-Review, Parsoid-Nowiki, Parsoid

Apr 21 2015

marcoil claimed T94509: Space before colon in French is wrapped in mw:Placeholder wrapper.
Apr 21 2015, 10:44 AM · Parsoid-DOM, Parsoid

Apr 20 2015

marcoil committed rGPAR6e1776294e0e: T95794: Enforce <pre> for all lines when escaping wikitext.
T95794: Enforce <pre> for all lines when escaping wikitext
Apr 20 2015, 3:53 PM
marcoil claimed T95794: Unnecessary nowiki in an indent-pre block.

It just needs to replace "\n" with "\n " and tokenize it.

Apr 20 2015, 10:04 AM · Patch-For-Review, Parsoid-Nowiki, Parsoid

Apr 17 2015

marcoil added a comment to T95794: Unnecessary nowiki in an indent-pre block.

After a little investigation: in wts.escapeWikitext.js, WEHP.hasWikitextTokens calls the tokenizer with the right SOL state, but the second line is tokenized to a listItem TagTk, which provokes it being surrounded with <nowiki>s. Maybe there should be a way for the tokenizer to act differently if the whole text is in pre?

Apr 17 2015, 3:56 PM · Patch-For-Review, Parsoid-Nowiki, Parsoid

Apr 10 2015

marcoil committed rGPAR15bee80b08e5: Bug fix serializing nested refs (authored by ssastry).
Bug fix serializing nested refs
Apr 10 2015, 9:36 AM

Apr 8 2015

marcoil committed rGPARd98169ce32f2: Fix crash in dom.processRefs.js for <ref>s in <references>.
Fix crash in dom.processRefs.js for <ref>s in <references>
Apr 8 2015, 4:28 PM
marcoil committed rGPARd75e953d930d: [parserTests] Ensure manual selser changes have a clean DOM.
[parserTests] Ensure manual selser changes have a clean DOM
Apr 8 2015, 4:28 PM
marcoil committed rGPARda3f62454f0d: T93973: Remove state from Cite extension.
T93973: Remove state from Cite extension
Apr 8 2015, 4:28 PM
marcoil committed rGPARa65fb323cd22: [roundtrip-test] Use API v2 for doubleRoundtripDiff too.
[roundtrip-test] Use API v2 for doubleRoundtripDiff too
Apr 8 2015, 4:28 PM
marcoil committed rGPAR7fa0cd271b19: [roundtrip-test] T93315: Use API v2 pagebundles to get wt2html.
[roundtrip-test] T93315: Use API v2 pagebundles to get wt2html
Apr 8 2015, 4:28 PM
marcoil committed rGPARe77a61fa75c7: T63165: Ensure reference index is reset at the end of document.
T63165: Ensure reference index is reset at the end of document
Apr 8 2015, 4:28 PM
marcoil committed rGPARa9dd0d2cbdbe: T73708: Serialize category redirects with a ':'.
T73708: Serialize category redirects with a ':'
Apr 8 2015, 4:28 PM
marcoil committed rGPAR54de4d8e198f: [parserTests] T72722: Support manual changes in selser tests.
[parserTests] T72722: Support manual changes in selser tests
Apr 8 2015, 4:28 PM
marcoil committed rGPAR082d0c94f94e: T53961: Improve escaping and nowikiing template arguments.
T53961: Improve escaping and nowikiing template arguments
Apr 8 2015, 4:28 PM
marcoil committed rGPAR81ac37d0d2bd: Sync parserTests with core tests.
Sync parserTests with core tests
Apr 8 2015, 4:28 PM
marcoil committed rGPAR43f1977adbd9: T71482: Convert | to {{!}} in template parameters.
T71482: Convert | to {{!}} in template parameters
Apr 8 2015, 4:28 PM
marcoil committed rGPARf997f0bd21ab: T71950: Output <nowiki> closer to quotes.
T71950: Output <nowiki> closer to quotes
Apr 8 2015, 4:28 PM
marcoil committed rGPARba99c99e1eb9: T72582: Change how LST <section>s are output.
T72582: Change how LST <section>s are output
Apr 8 2015, 4:28 PM
marcoil committed rGPAR7608aeabdc1e: Deal with chameleon nodes that change output based on surroundings (authored by ssastry).
Deal with chameleon nodes that change output based on surroundings
Apr 8 2015, 4:28 PM
marcoil committed rGPARb442a12c83a8: Add missing 'about' attributes in Cite tests.
Add missing 'about' attributes in Cite tests
Apr 8 2015, 4:28 PM
marcoil committed rGPAR47ddba73a5f6: T88017: Remove more cases of data-parsoid.src from mw:Extensions.
T88017: Remove more cases of data-parsoid.src from mw:Extensions
Apr 8 2015, 4:28 PM
marcoil committed rGPAR08643f53428b: T88290: Keep separate content for multiple <ref>s with same name.
T88290: Keep separate content for multiple <ref>s with same name
Apr 8 2015, 4:28 PM
marcoil committed rGPAR35b729b56fa2: T88290: Only output <ref> contents in <references>.
T88290: Only output <ref> contents in <references>
Apr 8 2015, 4:28 PM
marcoil committed rGPAR5189bcb7fb17: T88660: Emit reflists for <ref> with no explicit <references>.
T88660: Emit reflists for <ref> with no explicit <references>
Apr 8 2015, 4:28 PM
marcoil committed rGPARdcba4032057c: T88019: Remove unnecessary <meta> transclusion tags.
T88019: Remove unnecessary <meta> transclusion tags
Apr 8 2015, 4:28 PM
marcoil committed rGPAR7fce14bea1b4: Internal expander: Pass along the inTemplate flag.
Internal expander: Pass along the inTemplate flag
Apr 8 2015, 4:28 PM
marcoil committed rGPARa74ce50d8be5: Don't remove <meta>s with data-mw.
Don't remove <meta>s with data-mw
Apr 8 2015, 4:28 PM
marcoil committed rGPAR8ef6de9387eb: T72960: Fix serializing new links with "./" in content string.
T72960: Fix serializing new links with "./" in content string
Apr 8 2015, 4:28 PM
marcoil committed rGPAR1b01b25d82b6: Move isValidDSR from wts.utils.js to mediawiki.Util.js.
Move isValidDSR from wts.utils.js to mediawiki.Util.js
Apr 8 2015, 4:28 PM
marcoil committed rGPAR021b379abcfe: Don't use data-parsoid.src to serialize magicword page properties.
Don't use data-parsoid.src to serialize magicword page properties
Apr 8 2015, 4:28 PM
marcoil committed rGPAR4417d887da86: Fix test "Definition Lists: Mixed Lists: Test 11".
Fix test "Definition Lists: Mixed Lists: Test 11"
Apr 8 2015, 4:28 PM
marcoil committed rGPAR31cf423c51ed: T86902: Add new local setting for CSS modules load URI.
T86902: Add new local setting for CSS modules load URI
Apr 8 2015, 4:28 PM
marcoil committed rGPAR10cecf5c8f42: T86902: Switch debug off for ResourceLoader modules loading.
T86902: Switch debug off for ResourceLoader modules loading
Apr 8 2015, 4:28 PM
marcoil committed rGPARcef3ef8cb9d1: T73412: Preserve blank template parameters.
T73412: Preserve blank template parameters
Apr 8 2015, 4:28 PM
marcoil committed rGPAR839e7af8be58: [Cite] Generate the same ids for <ref>s and notes as Cite.php.
[Cite] Generate the same ids for <ref>s and notes as Cite.php
Apr 8 2015, 4:28 PM
marcoil committed rGPAR320caa300d2e: T72786: Re-enable stripping data-parsoid for template content.
T72786: Re-enable stripping data-parsoid for template content
Apr 8 2015, 4:28 PM
marcoil committed rGPAR86fbda81ddff: Infer extension name from typeOf if data-mw not present.
Infer extension name from typeOf if data-mw not present
Apr 8 2015, 4:28 PM
marcoil committed rGPAR73685fe1c206: Add mocha tests for accessing the Parsoid API through HTTP.
Add mocha tests for accessing the Parsoid API through HTTP
Apr 8 2015, 4:28 PM
marcoil committed rGPAR8e396a2423ce: Improve apiServer.js to support multiple mock and Parsoid servers.
Improve apiServer.js to support multiple mock and Parsoid servers
Apr 8 2015, 4:28 PM
marcoil committed rGPAR003554b96192: Remove unnecessary require of Buffer.
Remove unnecessary require of Buffer
Apr 8 2015, 4:28 PM
marcoil committed rGPAR5c2450a10f42: Bug 67657: Add normalized parameter names to templates.
Bug 67657: Add normalized parameter names to templates
Apr 8 2015, 4:28 PM
marcoil committed rGPARd4567e9f107c: Bug 72136: Comply with the 'body' API parameter.
Bug 72136: Comply with the 'body' API parameter
Apr 8 2015, 4:28 PM
marcoil committed rGPAR8398ef5286ab: Fix inserting category links from non-parser function extensions.
Fix inserting category links from non-parser function extensions
Apr 8 2015, 4:28 PM
marcoil committed rGPARc4ae060af704: Bug 71490: Set prop 'wikitext' when calling action=expandtemplates.
Bug 71490: Set prop 'wikitext' when calling action=expandtemplates
Apr 8 2015, 4:28 PM
marcoil committed rGPARae7d29826a6f: Move rt-server summary text to a partial.
Move rt-server summary text to a partial
Apr 8 2015, 4:28 PM
marcoil committed rGPAR6266eef6f61e: Bug 70196: Add categories added directly from extensions.
Bug 70196: Add categories added directly from extensions
Apr 8 2015, 4:28 PM
marcoil committed rGPAR74a3eec380a8: Bug 70196: Add all categories from action=parse.
Bug 70196: Add all categories from action=parse
Apr 8 2015, 4:28 PM
marcoil committed rGPARdeed30b2448d: Bug 69240: Make lang-links sol-transparent.
Bug 69240: Make lang-links sol-transparent
Apr 8 2015, 4:28 PM
marcoil committed rGPAR87eddc75ae6b: Bug 67540 - Load extension CSS modules.
Bug 67540 - Load extension CSS modules
Apr 8 2015, 4:28 PM
marcoil committed rGPARcfcc3b889508: Fix trailing whitespace.
Fix trailing whitespace
Apr 8 2015, 4:28 PM
marcoil committed rGPARf14dfee4e979: Bug 68421: Parsoid is not graceful about an empty template call {{ }}.
Bug 68421: Parsoid is not graceful about an empty template call {{ }}
Apr 8 2015, 4:28 PM
marcoil committed rGPAR1445723e9206: rt-client: Removed unnecessary and wrong setting of Content-Length.
rt-client: Removed unnecessary and wrong setting of Content-Length
Apr 8 2015, 4:28 PM
marcoil committed rGPAR8e989f51d048: Bug 49762: Logging - emit structured logs via node-bunyan.
Bug 49762: Logging - emit structured logs via node-bunyan
Apr 8 2015, 4:28 PM
marcoil committed rGPAR1134073db5db: Fix starting newline problems in rt selser testing.
Fix starting newline problems in rt selser testing
Apr 8 2015, 4:27 PM
marcoil committed rGPAR91e8b5272d4d: Fix various problems with rt selser results.
Fix various problems with rt selser results
Apr 8 2015, 4:27 PM
marcoil committed rGPARb809ac760ce3: Bug 56601: Keep number of rt selser errors in new column in stat table.
Bug 56601: Keep number of rt selser errors in new column in stat table
Apr 8 2015, 4:27 PM