Page MenuHomePhabricator
Feed Advanced Search

Today

daniel added a comment to T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter.

I have found the reason for triple lookups of content; the third lookup, performed from within the Abstract Filter extension, is to determine whether or not the revision is a redirect or not.

Tue, Oct 15, 10:01 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a comment to T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter.

Thank you for investigating, Ariel!

Tue, Oct 15, 9:58 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Yesterday

daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Pinging Performance-Team since they own WANObjectCache.

Mon, Oct 14, 3:22 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

I put this up for SWAT in 3 hours: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/542963

Mon, Oct 14, 3:15 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net

Sat, Oct 12

daniel added a comment to T231580: Implement GET Revision Comparison.

The handler for this route doesn't seem to check read permissions for the pages it is comparing. That means it could be used to bypass per-page read permissions. The DifferenceEngine class responsible for showing diffs in the UI does apply these checks, though I note that ApiComparePages seems to be lacking them as well.

Sat, Oct 12, 8:58 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Fri, Oct 11

daniel added a comment to T231588: Implement GET Page Revision.

On the patch @BPirkle asked:

Thank you Daniel. Was that comment informational, or did you see something we need to change?

Fri, Oct 11, 1:46 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T234636: Wikimedia Technical Conference 2019 Session: API Integration Testing.

@daniel sure I'd be happy to help!

I've updated the task, making the two of you leaders.

Fri, Oct 11, 1:36 PM · User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019
daniel moved T233146: Cannot enable 2FA on testwiki from External Code Review Needed to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Oct 11, 11:24 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Operations, MediaWiki-extensions-OATHAuth
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Is there any chance that the Memcache server has incorrect clock setting (or NTP failing its updates) ?

Fri, Oct 11, 11:01 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

I got bored of just kicking the failing test can down the road after 5 supporting backports to REL1_32 and REL1_33 to help this change

Fri, Oct 11, 10:05 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Another message duplicated:
"<strong>$1</strong> a été effacé."

Fri, Oct 11, 10:02 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

There's somthing strange in your Memcache query; "rev_user_text:" is empty for many ones. Aren't revisions supposed to be associated to a user ?

Fri, Oct 11, 10:01 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

I'd be very interested to know whether the code in https://gerrit.wikimedia.org/r/542325 would pass on your live system. Of course, the test doesn't use the real cache setup. So to test that, you'd have to run equivalent code in eval.php. This would introduced a handful of orphan rows into the text table each time you run it. Not great, but maybe ok for a one-off?

Fri, Oct 11, 9:43 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel updated the task description for T218395: Create RestrictionStore service.
Fri, Oct 11, 9:06 AM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Contractor Workboard)
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

It seems that we have enough information to pinpoint the cause.

Fri, Oct 11, 8:52 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T231345: Curator reads revision metadata .

Should this user story mention that unauthorized users should be unable to read this data?

Fri, Oct 11, 8:05 AM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (User Stories), Story
daniel added a comment to T231588: Implement GET Page Revision.

A quick heads up on permission checks when serving content, because I didn't see any permission checks in the patch:

Fri, Oct 11, 8:02 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel updated subscribers of T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

A quick search tells me that the new SqlBlobStore::getBlobBatch method is the *only* code that uses WANObjectCache::getMultiWithUnionSetCallback(). So that code hasn't previously been exercised. I suspect it might be buggy. It does have decent test coverage, but still...

Fri, Oct 11, 7:40 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Fri, Oct 11, 12:16 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net

Thu, Oct 10

daniel added a comment to T233092: CI: Create a way to share a secret between MediaWiki and the testing framework..

Has the new version of quibble been deployed everywhere?
Should CI on the api-testing repo now be using the hardcoded secret?

Thu, Oct 10, 8:39 PM · Release-Engineering-Team-TODO, Patch-For-Review, Quibble, Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

For the record, I still have no clue how the cache gets corrupted, and no good idea for investigating it.
I wonder what the cache keys look like. maybe they are too long, and they get truncated somehow? That would do it.

Thu, Oct 10, 7:55 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235027: Translate does not update content page when saving units.

We have seen some mystery problems that may be related... I can't find it right now, @Anomie would know.

Are the mystery problems anything like T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs?

Thu, Oct 10, 4:15 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), MediaWiki-extensions-Translate
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Slightly less insane option:
$wgMainWANCache = CACHE_NONE;

Thu, Oct 10, 4:13 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

@Nikerabbit a hacky way to investigate: in SqlBlobStore::getBlob, rip out the caching code. should look something like this:

Thu, Oct 10, 4:11 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

@Nikerabbit: Try this:

SELECT rev_text_id, slots.*, content.* FROM revision LEFT JOIN slots ON (slot_revision_id = rev_id) LEFT JOIN content ON(content_id = slot_content_id) WHERE rev_id = 7714145;
Thu, Oct 10, 4:06 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

When investigating btw, beware that diffs are cached, and there is no simple way to purge that cache.
So even once the actual issue has been fixed, you will see bad diffs.

Thu, Oct 10, 4:04 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

@Nikerabbit what version are you running? I merged some changes against the Language class the other day. Though I don't see how that would mess with page history.

Thu, Oct 10, 4:03 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

I checked the database for https://translatewiki.net/w/i.php?title=MediaWiki:Wm-license-cecill-text/fr&oldid=7714145

select old_text from bw_text, bw_revision where rev_id = 7714145 and rev_text_id = old_id\G
*************************** 1. row ***************************
old_text: Cette œuvre est un [[{{int:wm-license-free-software-wiki-link}}|logiciel libre]] ; elle peut être redistribuée ou modifiée selon les termes de la licence [[{{int:wm-license-cecill-wiki-link}}|CeCILL]].
Le texte de cette licence est consultable sur [{{int:wm-license-cecill-full-link}} www.cecill.info].

I'm not sure how the slots and content play role in this, but it seems that it is not corrupted in the text table at least. Where am I supposed to see content_address?

Thu, Oct 10, 4:00 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Anyway on the affected wikis, some users start getting insulted or banned even if they did not make the breaking changes.
Havoc starts spreading to random places, and the user's history is now definitely wrong for what they really did.

Thu, Oct 10, 3:55 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a project to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs: Core Platform Team Workboards (Clinic Duty Team).
Thu, Oct 10, 3:53 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Two things to investigate:

  1. kill the cache and see if that fixes things
  2. look at the content_address in the database and the content in the corresponding text row. The association pattern is: [revision]<--[slots]-->[content]-->[text].
Thu, Oct 10, 3:52 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

If this has anything to do with our changes to SqlBlobStore, my primary suspect is the caching logic. getBlobBatch() uses WANObjectCache::makeMultiKeys and WANObjectCache::getMultiWithUnionSetCallback. If anything went wrong with these cache keys, that would explain your observation.

Thu, Oct 10, 3:49 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

That does sound scary. But I'm not aware of recent changes to how revision content gets loaded.
We added bulk code, but the code path is nearly entirely separate. They converge in SqlBlobStore::getBlob calling SqlBlobStore::fetchBlobs(). That code landed in master on August 30, see
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/532449. I'm not aware of any change to the "normal" content loading since then. We only worked on the bulk code, as far as I am aware.

Thu, Oct 10, 3:46 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Language-Team (Language-2019-October-December), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, affects-translatewiki.net
daniel updated the task description for T193613: Establish stable interface policy for PHP code (was: strategy for PHP interface changes).
Thu, Oct 10, 3:11 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel added a comment to T193613: Establish stable interface policy for PHP code (was: strategy for PHP interface changes).

I'm thinking about the generated documentation that may now be confusing to newcomers / people who haven't read this policy yet. For example, if you have two public methods, and one of them is annotated with @stable while the other is not. I would read the documentation and use any public method and expect it to be stable unless something jumped out at me telling me not to make this assumption. So, ideally, docs would color/explain both annotated methods and public methods that are not annotated.

Thu, Oct 10, 1:49 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel moved T232485: RFC: Core REST API namespace and version from Under discussion to Last Call on the TechCom-RFC board.

Per the TechCom meeting on October 9, this RFC is entering the Last Call period. If there are no pertienent concerns raised and left unaddressed by October 23, this RFC will be approved as proposed.

Thu, Oct 10, 1:17 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel renamed T235168: Clarify which methods on RevisionStore enforce audience checks when accessing content from WikiPage::getDeletionUpdates pretends to get content with RevisionRecord::RAW but it actually doesn't to Carify which methods on RevisionStore enforce audience checks when accessing content.
Thu, Oct 10, 1:15 PM · MediaWiki-Revision-backend, Patch-For-Review, Core Platform Team
daniel added a comment to T235168: Clarify which methods on RevisionStore enforce audience checks when accessing content.

$rev->getSlots() returns raw slots, with no audience checks. So while the parameter in getContent( RevisionRecord::RAW ) is incorrect, the code still does the right thing.

Thu, Oct 10, 1:00 PM · MediaWiki-Revision-backend, Patch-For-Review, Core Platform Team
daniel added a project to T235165: Introduce ContentHandlerRegistry: MediaWiki-ContentHandler.
Thu, Oct 10, 11:18 AM · MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel created T235165: Introduce ContentHandlerRegistry.
Thu, Oct 10, 11:18 AM · MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel moved T181555: Remove use of PHP serialization in revision storage from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Thu, Oct 10, 9:40 AM · Core Platform Team, MediaWiki-Revision-backend, Patch-For-Review
daniel moved T221159: FY18/19 TEC1.6 Q4: Improve or replace the usage of GTID_WAIT with pt-heartbeat in MW from Inbox to Triage Meeting Inbox on the Core Platform Team board.

Not sure what CPT can do here. Tagging for triage.

Thu, Oct 10, 9:39 AM · Core Platform Team, Performance-Team (Radar), User-mobrovac, Services (watching), Goal, Core Platform Team Legacy (Watching / External), Wikimedia-Rdbms, DBA
daniel removed a project from T221159: FY18/19 TEC1.6 Q4: Improve or replace the usage of GTID_WAIT with pt-heartbeat in MW: Patch-For-Review.

Patch was merged, removing the patch for review tag.

Thu, Oct 10, 9:39 AM · Core Platform Team, Performance-Team (Radar), User-mobrovac, Services (watching), Goal, Core Platform Team Legacy (Watching / External), Wikimedia-Rdbms, DBA

Wed, Oct 9

daniel added a comment to T235027: Translate does not update content page when saving units.

Could the opposite happen as well: it would not find the latest revision, and then fetch stale content (penultimate)?

Wed, Oct 9, 3:54 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), MediaWiki-extensions-Translate
daniel updated subscribers of T235027: Translate does not update content page when saving units.

To investigate, any errors reported in the StatusValue returned by the calls to getContentBlobsForBatch() could be logged. We currently just ignore them.

Wed, Oct 9, 3:13 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), MediaWiki-extensions-Translate
daniel added a comment to T231671: [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed.

@daniel, you now have the epic as a subtask of the user story. It should be the other way around. Are we missing an engineering task here?

Wed, Oct 9, 2:37 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel added a comment to T230607: stop using page_content_model.

Does this imply that the current MCR schema migration initiative is focused only on the revision table and that there will need to be a separate page table schema migration activity later?

Wed, Oct 9, 2:34 PM · CPT Initiatives (MCR), Structured-Data-Backlog, Structured Data Engineering, Schema-change
daniel merged T235065: Manage FileBackendGroup as a service object into T234228: Convert FileBackendGroup into a service.
Wed, Oct 9, 12:53 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2))
daniel merged task T235065: Manage FileBackendGroup as a service object into T234228: Convert FileBackendGroup into a service.
Wed, Oct 9, 12:53 PM · CPT Initiatives (Decoupling (CDP2))
daniel renamed T235066: Deprecate static FileJournal::factory() from Deprecate statix FileJournal::factory() to Deprecate static FileJournal::factory().
Wed, Oct 9, 12:50 PM · CPT Initiatives (Decoupling (CDP2))
daniel created T235066: Deprecate static FileJournal::factory().
Wed, Oct 9, 12:50 PM · CPT Initiatives (Decoupling (CDP2))
daniel created T235065: Manage FileBackendGroup as a service object.
Wed, Oct 9, 12:45 PM · CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter.

@daniel/@Pchelolo was this task moved to the Done column in error? I see that it still has a patch set open.

Wed, Oct 9, 9:33 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a comment to T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization.

@Mooeypoo @daniel @Krinkle - Any of y'all want to be session leaders or facilitators for this? Feel free to ping other folks as well.

Wed, Oct 9, 9:30 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Tue, Oct 8

daniel updated subscribers of T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization.
Tue, Oct 8, 10:16 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
daniel added a comment to T234636: Wikimedia Technical Conference 2019 Session: API Integration Testing.

@kostajh I just volunteered to lead this. Want to be the co-lead?

Tue, Oct 8, 10:14 PM · User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019
daniel added a comment to T234995: Testing for Core REST API.

The api-testing has abstractions and some tests set up for Action API, so we would probably need to invest a bit into setting it up for REST API routes as well before we can write actual tests.
One possible concern I have for using it right away is that the REST API seem to not yet be very stable, and moving the tests into a separate repo adds a little bit of overhead when changing the API.. I think we should start off the right track and invest in supporting REST routes in api tester.

Tue, Oct 8, 8:53 PM · CPT Initiatives (API Integration Tests)
daniel added a comment to T231588: Implement GET Page Revision.

Any thoughts or concerns there?

Please just return the HTML from the default parser.

Tue, Oct 8, 8:15 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel created T234921: Factor group membership management out of User class.
Tue, Oct 8, 1:01 PM · CPT Initiatives (Decoupling (CDP2))
daniel moved T214267: Name of slots should be localized in diff from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:58 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Tech Debt), StructuredDataOnCommons, I18n, Wikidata
daniel moved T203061: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:58 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Debian, MediaWiki-General
daniel moved T220160: getRedirectTarget should not automatically load revision content in all cases from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:58 AM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, Regression, MediaWiki-Revision-backend, Dumps-Generation
daniel moved T220353: Unable to create redirect on dewiki - fatal DBQueryError from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:58 AM · Core Platform Team Workboards (Clinic Duty Team), User-Marostegui, MediaWiki-Revision-backend, Wikimedia-production-error, MediaWiki-Redirects
daniel moved T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:58 AM · Core Platform Team Workboards (Clinic Duty Team), good first bug, MediaWiki-Logging
daniel moved T225366: "Fatal exception: MediaWiki\Revision\InvalidArgumentException" when trying to move user JS page on en.wp from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-Revision-backend, Wikimedia-production-error
daniel moved T225574: The SiteConfiguration class (wgConf) should not skip extraction if default is specified as null from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Configuration
daniel moved T170184: Refactor anti-spam/vandalism checks out of EditPage.php from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Technical-Debt, MediaWiki-Page-editing
daniel moved T205361: Make an HTML dump of the output of the CodeReview extension on MediaWiki.org from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-extensions-CodeReview
daniel moved T201749: Config script still sets "en_US.utf8" to "$wgShellLocale" for MW 1.30+ from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MediaWiki-Installer, MediaWiki-Configuration
daniel moved T215918: Integration testing for email from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), TechCom
daniel moved T226644: WikiPage::isRedirect and WikiPage::getRedirectTarget() seemingly disagree from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend
daniel moved T134461: Evaluate increased memtable_cleanup_threshold values from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), User-Eevans, Cassandra
daniel moved T154240: Update the template's configuration documentation from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), User-Clarakosi, Google-Code-In-2016, good first bug, service-template-node, User-mobrovac
daniel moved T202352: Convert MultiHttpClient to use Guzzle from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), MediaWiki-General
daniel moved T201628: Cannot edit subpages on third-party wiki, probably due to percent-encoding of URIs from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor
daniel moved T205675: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given" from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Technical-Debt, MediaWiki-General, Multi-Content-Revisions (Reactive), Wikimedia-production-error
daniel moved T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database! from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.32-release, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Wikimedia-production-error
daniel moved T221763: Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y. from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Wikimedia-production-error, Regression
daniel moved T216504: page-links-change stream is assigning template propagation events to the wrong edits from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), The-Wikipedia-Library, MediaWiki-extensions-WikimediaEvents, Internet-Archive
daniel moved T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
daniel moved T220246: Management of Cassandra schema and keyspace/table configuration from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Patch-For-Review, User-WDoran, Core Platform Team Workboards (Clinic Duty Team), serviceops-radar
daniel moved T227739: Contention on User::getActorId ? from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Wikimedia-database-error, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MediaWiki-User-management
daniel moved T228763: stubs are produced with xml:space="preserve" in the text tag; this is new behavior for the July 20th run of the xml/sql dumps from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Dumps-Generation
daniel moved T210548: gzip-encoded page properties can't be exported from the API from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Maps (Kartographer), MediaWiki-API
daniel moved T229092: Investigate migrateActors script failing due to duplicate empty actor_name from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Maintenance-scripts
daniel moved T228911: restInPeace: transaction round 'LinksUpdate::doUpdate' still running from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · MediaWiki-General, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-Page-derived-data, Wikimedia-production-error
daniel moved T229137: Create grafana alerts for RESTBase from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · RESTBase, Core Platform Team Workboards (Clinic Duty Team)
daniel moved T151399: Make service-template-node more modular from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), service-template-node
daniel moved T176693: Cannot override basePath in the Swagger spec from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), HyperSwitch
daniel moved T228848: Remove trailing newline from log messages from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Debug-Logger
daniel moved T206032: api_path log property doesn't show the correct domain from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), User-Clarakosi, good first bug, HyperSwitch
daniel moved T205936: Unable to view some pages due to fatal RevisionAccessException: "Failed to load data blob from tt" from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Technical-Debt, Multi-Content-Revisions (Reactive), Wikimedia-production-error
daniel moved T160993: MysqlUpdater::doWatchlistUpdate is very slow from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Growth-Team, MediaWiki-Watchlist, Patch-For-Review, MediaWiki-Installer
daniel moved T225097: "JobExecutor not loaded" error for BounceHandlerJob on wikitech.wikimedia.org from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-BounceHandler, WMF-JobQueue, wikitech.wikimedia.org, Wikimedia-production-error
daniel moved T224209: Orphaned entries in categorylinks from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-derived-data, Wikimedia-database-error, MediaWiki-Categories
daniel moved T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, Commons, Wikimedia-production-error
daniel moved T229176: API allusers: Is it intended that all users are returned when an invalid value for augroup is specified? from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
daniel moved T124274: Add structure tests to verify hook and extension functions are valid callbacks from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), good first bug, MediaWiki-Core-Testing
daniel moved T35732: action=userrights: give error when user is not allowed to change userrights from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
daniel moved T230667: Old files stored with an invalid base36 fa_sha1 hash with leading 0 from Inbox to Backlog on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:57 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Core Platform Team Workboards (Clinic Duty Team), Commons, MediaWiki-File-management