Page MenuHomePhabricator
Feed Advanced Search

Fri, Feb 26

daniel moved T263301: Old image unexpectedly overwritten by a revision several years later (after Internal server error) from Ready to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 26, 11:14 AM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WMF-JobQueue, Wikimedia-production-error, MediaWiki-Uploading
daniel moved T257755: Changing the PostgreSQL MediaWiki schema to use BYTEA where MySQL uses VARBINARY / VARCHAR BINARY would break SQL queries from Tech Planning Review to Tracking/Watching on the Platform Engineering board.

Moving to tracking/watching. Per Tim's comment, there is a clear recommendation now. I'm assuming Amir is going to work on it, and we can lend a hand i need be. If this is not the case, we'll have to think about how to prioritize this and route it through the team boards.

Fri, Feb 26, 11:00 AM · Platform Engineering, Wikimedia-Rdbms, PostgreSQL
daniel added a project to T275847: Grand Hook Revamp: Epic.
Fri, Feb 26, 9:35 AM · Epic, MediaWiki-Core-Hooks, MW-1.37-release, Platform Engineering Roadmap Decision Making
daniel created T275847: Grand Hook Revamp.
Fri, Feb 26, 9:35 AM · Epic, MediaWiki-Core-Hooks, MW-1.37-release, Platform Engineering Roadmap Decision Making

Thu, Feb 25

daniel updated the task description for T275772: Create an easy way to determine whether the wiki is private, and whether it is read only..
Thu, Feb 25, 4:11 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel updated the task description for T275768: Mark Authority as stable.
Thu, Feb 25, 3:54 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T272519: Implement private wiki read permission in a way that works with Authority from High to Medium.
Thu, Feb 25, 2:13 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel triaged T275768: Mark Authority as stable as High priority.
Thu, Feb 25, 2:12 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel triaged T275770: Introduce AuthorityFactory as High priority.
Thu, Feb 25, 2:12 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel triaged T275772: Create an easy way to determine whether the wiki is private, and whether it is read only. as Medium priority.
Thu, Feb 25, 2:12 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T275768: Mark Authority as stable from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.
Thu, Feb 25, 2:12 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel moved T275770: Introduce AuthorityFactory from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.
Thu, Feb 25, 2:12 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T275772: Create an easy way to determine whether the wiki is private, and whether it is read only. from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.
Thu, Feb 25, 2:12 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel created T275772: Create an easy way to determine whether the wiki is private, and whether it is read only..
Thu, Feb 25, 2:11 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel created T275770: Introduce AuthorityFactory.
Thu, Feb 25, 2:03 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel added a project to T275768: Mark Authority as stable: MW-1.36-release.
Thu, Feb 25, 1:59 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel added a subtask for T231930: Introduce Authority objects to represent the user performing a given action: T275768: Mark Authority as stable.
Thu, Feb 25, 1:59 PM · tech-decision-forum, Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel added a parent task for T275768: Mark Authority as stable: T231930: Introduce Authority objects to represent the user performing a given action.
Thu, Feb 25, 1:59 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel added a project to T275768: Mark Authority as stable: MediaWiki-User-management.
Thu, Feb 25, 1:58 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel created T275768: Mark Authority as stable.
Thu, Feb 25, 1:58 PM · MW-1.36-release, MediaWiki-User-management, Platform Team Workboards (MW Expedition)
daniel added a comment to T251588: EditPage save hooks pass an entire `EditPage` object.

Codesearch shows 22 extensions that use these hooks: https://codesearch.wmcloud.org/extensions/?q=EditFilter%7CEditPage%3A%3AattemptSave%7CEditFilterMergedContent%7CEditPage%3A%3AattemptSave%3Aafter&i=nope&files=extension%5C.json&excludeFiles=&repos=

Thu, Feb 25, 10:55 AM · Analytics-Radar, Editing-team, Product-Analytics, User-DannyS712, Platform Engineering, MediaWiki-Page-editing
daniel added a comment to T274638: Devise a smart deprecation process for hooks passing User or Title objects.

This problem is pretty similar to T251588: EditPage save hooks pass an entire `EditPage` object

Thu, Feb 25, 10:54 AM · Platform Engineering, MediaWiki-Core-Hooks, Technical-Debt, Dependency injection
daniel edited projects for T157670: Periodically run refreshLinks.php on production sites., added: tech-decision-forum; removed Platform Engineering.
Thu, Feb 25, 9:49 AM · tech-decision-forum, MediaWiki-Parser, MediaWiki-Page-editing, Parsing-Team--ARCHIVED
daniel moved T275749: Survey tool to see which extension uses which hooks from Untriaged to Tech Debt Jam on the Platform Engineering Roadmap Decision Making board.
Thu, Feb 25, 9:46 AM · Platform Engineering Roadmap Decision Making, MediaWiki-Core-Hooks
daniel created T275749: Survey tool to see which extension uses which hooks.
Thu, Feb 25, 9:46 AM · Platform Engineering Roadmap Decision Making, MediaWiki-Core-Hooks
daniel added a project to T264798: CentralAuth should not emit central cookies when creating a local session: Security-Team.

Tagging the Security-Team to chime in on priority

Thu, Feb 25, 9:33 AM · Security-Team, Platform Engineering Roadmap Decision Making, MediaWiki-extensions-CentralAuth

Wed, Feb 24

daniel removed projects from T274192: Mark Message as NonSerializable: Platform Engineering Roadmap Decision Making, Epic.

Removing from workboard, we'll track it via the parent task

Wed, Feb 24, 4:18 PM · MediaWiki-Cache
daniel added a comment to T275334: Changing user groups from $wgExtensionFunctions no longer works reliably.

Thanks for summarizing the issue @daniel. Breaking the assumption extension functions can modify config sadly means that there is no longer any way for local site administrators to alter extension provided config.

Wed, Feb 24, 11:40 AM · User-Urbanecm, MW-1.36-release, Platform Engineering, MediaWiki-User-management
daniel added a comment to T275334: Changing user groups from $wgExtensionFunctions no longer works reliably.

$wgExtensionFunctions callbacks are run late in the bootstrap sequence, when setup is complete. At that point, changing globals may no longer have any affect, since service instances may already have been created.

Wed, Feb 24, 9:49 AM · User-Urbanecm, MW-1.36-release, Platform Engineering, MediaWiki-User-management

Tue, Feb 23

daniel moved T273317: some users with access are unable to configure pending changes from Waiting for Review to Blocked on the Platform Team Workboards (MW Expedition) board.
Tue, Feb 23, 6:45 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), Regression, MediaWiki-extensions-FlaggedRevs
daniel moved T273317: some users with access are unable to configure pending changes from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Tue, Feb 23, 6:44 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), Regression, MediaWiki-extensions-FlaggedRevs
daniel triaged T275030: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName as Medium priority.
Tue, Feb 23, 6:44 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
daniel triaged T274972: Hard deprecate WatchedItem::getUser as Medium priority.
Tue, Feb 23, 6:33 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Technical-Debt, Platform Team Workboards (MW Expedition)
daniel moved T275509: Saving edits should not require a User object, a UserIdentity should be sufficient. from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Tue, Feb 23, 6:30 PM · Patch-For-Review, MediaWiki-Decoupling, MediaWiki-Page-editing, Platform Team Workboards (MW Expedition)
daniel triaged T275509: Saving edits should not require a User object, a UserIdentity should be sufficient. as Medium priority.
Tue, Feb 23, 6:30 PM · Patch-For-Review, MediaWiki-Decoupling, MediaWiki-Page-editing, Platform Team Workboards (MW Expedition)
daniel created T275531: Make RevisionRecord return a ProperPageIdentity.
Tue, Feb 23, 5:59 PM · Patch-For-Review, MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T272421: Make WikiPage a PageRecord from High to Medium.
Tue, Feb 23, 5:41 PM · MediaWiki-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T272422: Introduce PageRecord and ExistingPageRecord interfaces from High to Medium.
Tue, Feb 23, 5:41 PM · MediaWiki-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel created T275509: Saving edits should not require a User object, a UserIdentity should be sufficient..
Tue, Feb 23, 3:24 PM · Patch-For-Review, MediaWiki-Decoupling, MediaWiki-Page-editing, Platform Team Workboards (MW Expedition)
daniel added a comment to T275452: addWiki.php throws Wikimedia\Assert\PreconditionException from line 58 of /srv/mediawiki/php-1.36.0-wmf.31/includes/dao/WikiAwareEntityTrait.php: Expected User to belong to 'altwiki', but it belongs to the local wiki on writing main page.

uh, how do I even run this locally to try and debug?...

Tue, Feb 23, 3:13 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Platform Team Workboards (MW Expedition), Wiki-Setup, MediaWiki-extensions-WikimediaMaintenance
daniel added a comment to T275452: addWiki.php throws Wikimedia\Assert\PreconditionException from line 58 of /srv/mediawiki/php-1.36.0-wmf.31/includes/dao/WikiAwareEntityTrait.php: Expected User to belong to 'altwiki', but it belongs to the local wiki on writing main page.

Change 666373 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] PageUpdater: use UserIdentity where possible

https://gerrit.wikimedia.org/r/666373

Tue, Feb 23, 3:06 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Platform Team Workboards (MW Expedition), Wiki-Setup, MediaWiki-extensions-WikimediaMaintenance
daniel added a comment to T275452: addWiki.php throws Wikimedia\Assert\PreconditionException from line 58 of /srv/mediawiki/php-1.36.0-wmf.31/includes/dao/WikiAwareEntityTrait.php: Expected User to belong to 'altwiki', but it belongs to the local wiki on writing main page.

addWiki calls redefineService() to force the 'RevisionStore' service to use an explicit target DB domain (rather false for the default local database). This conflicts with the fact that User are not cross-wiki aware, and Edits can't use UserIdentity yet.

Tue, Feb 23, 3:04 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Platform Team Workboards (MW Expedition), Wiki-Setup, MediaWiki-extensions-WikimediaMaintenance

Mon, Feb 22

daniel closed T212639: Separate could do / can do / is doing permission checks in MediaWiki as Resolved.

Fixed by T231930: Introduce Authority objects to represent the user performing a given action: could do / can do / is doing is now coved by probablyCa, definitelyCan, and authorityRead/authorizeWrite.

Mon, Feb 22, 8:10 PM · MediaWiki-Authentication-and-authorization
daniel added a subtask for T218674: User::getRights() applies session rights restrictions to non-session users: T271463: Refactor PermissionManager into Authority.
Mon, Feb 22, 8:09 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-API
daniel added a parent task for T271463: Refactor PermissionManager into Authority: T218674: User::getRights() applies session rights restrictions to non-session users.
Mon, Feb 22, 8:09 PM · Platform Team Workboards (MW Expedition)
daniel added a project to T218674: User::getRights() applies session rights restrictions to non-session users: Platform Team Workboards (MW Expedition).

Fixing this has become possible with the introduction of the Authority interface. It should actually be fixed automatically as part of T271463: Refactor PermissionManager into Authority.

Mon, Feb 22, 8:09 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-API
daniel closed T212341: Action authorization has multiple code paths to different results as Invalid.

I'm closing this ticket: the relevant code paths have been unified a long time ago, and with the new Authority interface, the relationship between quick and definitive permission checks has been clarified.

Mon, Feb 22, 8:04 PM · MediaWiki-General, MediaWiki-Authentication-and-authorization
daniel added a comment to T180888: All permission checks should be able to return a custom error message.

The new Authority interface allows messages to be returned from all methods that check permissions. That resolves half of this task - the other half would be to use this information in more places.

Mon, Feb 22, 7:52 PM · MediaWiki-Authentication-and-authorization, Epic
daniel added a parent task for T231930: Introduce Authority objects to represent the user performing a given action: T180888: All permission checks should be able to return a custom error message.
Mon, Feb 22, 7:51 PM · tech-decision-forum, Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel added a subtask for T180888: All permission checks should be able to return a custom error message: T231930: Introduce Authority objects to represent the user performing a given action.
Mon, Feb 22, 7:51 PM · MediaWiki-Authentication-and-authorization, Epic
daniel added a comment to T275268: Avoid capacity issues from the image table holding the text of pdf/djvu files as part of their metadata.

Let's discuss further steps on T28741, and not hijack this task :)

Mon, Feb 22, 10:45 AM · DBA, Commons
daniel added a comment to T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).

Replying here to @Marostegui's comment on the new ticket (T275268#6847723):

Mon, Feb 22, 10:45 AM · Patch-For-Review, Platform Engineering Roadmap Decision Making, Commons, Multimedia, Schema-change, MediaWiki-File-management
daniel added a comment to T275268: Avoid capacity issues from the image table holding the text of pdf/djvu files as part of their metadata.

Just to comment that compressing the table would give some benefit, but in the long run, it won't give us much.
I think the whole approach of the image table needs to be refactored, as having a single table isn't something we can support for much longer for the reasons already mentioned on the tickets you mentioned.

Mon, Feb 22, 8:21 AM · DBA, Commons

Fri, Feb 19

daniel added a comment to T198075: Factoring page update logic out of WikiPage.

I think this was largely about creating DerivedPageDataUpdater which has been done, so the task can be resolved, but maybe @daniel has more accurate recollections.

Fri, Feb 19, 2:19 PM · Platform Team Initiatives (MCR), Multi-Content-Revisions (Tech Debt)

Thu, Feb 18

Jdforrester-WMF awarded T231930: Introduce Authority objects to represent the user performing a given action a Like token.
Thu, Feb 18, 5:11 PM · tech-decision-forum, Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel added a comment to T274618: Return actual integers when selecting integer fields from the DB.

Is there a performance penalty for getting the type info? I'd imagine that at some point we'd send an extra query to get the schema info.

Thu, Feb 18, 1:55 PM · Wikimedia-Rdbms, Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-General

Tue, Feb 16

daniel updated the task description for T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware..
Tue, Feb 16, 7:49 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)
daniel moved T231930: Introduce Authority objects to represent the user performing a given action from Research and Prototyping to Decision Record Review on the tech-decision-forum board.
Tue, Feb 16, 5:51 PM · tech-decision-forum, Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel added a comment to T262959: Special:Badtitle should not have class="new".

@daniel more plainly, this link is styled with class=new, but it does not lead to a new page creation process; that is why it shouldn't be styled as such

Tue, Feb 16, 12:25 PM · Patch-For-Review, MediaWiki-Special-pages
daniel added a watcher for Train Deployments: daniel.
Tue, Feb 16, 12:10 PM
daniel added a comment to T262959: Special:Badtitle should not have class="new".

Special:Badtitle is not really a conventional special page, it's just an adhoc error page. It makes sense to make it blue though, since it has viewable content.

Tue, Feb 16, 10:48 AM · Patch-For-Review, MediaWiki-Special-pages

Mon, Feb 15

daniel added a comment to T273972: Survey cross-wiki User object creation and replace with ActorStore.

I found three places where User::newFromRow is used to create a User on data from another wiki:

  • WikimediaMaintenance: unsuppressCrossWiki.php
  • WikimediaMaintenance: renameInvalidUsernames.php
  • Echo: BackfillUnreadWikis
Mon, Feb 15, 8:22 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel added a comment to T273972: Survey cross-wiki User object creation and replace with ActorStore.

It's hard to identify code that constructs a User object on a name or ID that doesn't belong to the local wiki. The issue that caused T260485 is such a case. Basically, DatabaseBlock tries to be agnostic about what wiki the user belongs to, but doesn't quite succeed. CentralAuthUser assumes DatabaseBlock will work with a cross-wiki DB connection. Which it kind of does at the moment, but the situation is very brittle. I filed T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware. for fixing it.

Mon, Feb 15, 8:11 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel added a comment to T273972: Survey cross-wiki User object creation and replace with ActorStore.

An obvious thing to survey are User instances created via User::newFromRow():
https://codesearch.wmcloud.org/deployed/?q=User%3A%3AnewFromRow&i=nope&files=&excludeFiles=&repos=

Mon, Feb 15, 8:08 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel updated the task description for T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware..
Mon, Feb 15, 8:07 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)
daniel placed T273972: Survey cross-wiki User object creation and replace with ActorStore up for grabs.
Mon, Feb 15, 8:05 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel triaged T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware. as High priority.
Mon, Feb 15, 8:05 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)
daniel created T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware..
Mon, Feb 15, 8:05 PM · MediaWiki-extensions-CentralAuth, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)
daniel claimed T273974: Introduce caching into ActorStore.
Mon, Feb 15, 7:51 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel claimed T273972: Survey cross-wiki User object creation and replace with ActorStore.
Mon, Feb 15, 7:42 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel claimed T274179: Deprecate and remove UserIdentity::getActorId() .
Mon, Feb 15, 6:59 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management

Thu, Feb 11

daniel added a comment to T273930: Create performer filter for Special:SecurePollLog form.

The patch is merged, can this ticket be closed?

Sure. Is there a deadline on this for some reason?

Thu, Feb 11, 10:23 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll, Platform Engineering
daniel triaged T274329: Replace LogEntry::getPerformer with ::getPerformerIdentity as High priority.
Thu, Feb 11, 11:49 AM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel triaged T274330: Merge WikiPage::getContributors with RevisionStore::getAuthorsBetwee as Medium priority.
Thu, Feb 11, 11:49 AM · Platform Team Workboards (MW Expedition)
daniel added a project to T273738: Get platform engineering team green light for Cloud NAT to wikis change: Traffic.
Thu, Feb 11, 10:27 AM · SRE, Traffic, Platform Engineering, cloud-services-team (Kanban)
daniel added a comment to T273738: Get platform engineering team green light for Cloud NAT to wikis change.

Pinging Traffic since this seems to be in their area. Not sure what PET can do here.

Thu, Feb 11, 10:26 AM · SRE, Traffic, Platform Engineering, cloud-services-team (Kanban)

Wed, Feb 10

daniel added a comment to T273808: DeferredUpdates: Deferred update 'AtomicSectionUpdate_EchoNotificationMapper::insert' failed to run..

Related to T273479: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query?

Wed, Feb 10, 8:30 PM · wikitech.wikimedia.org, cloud-services-team (Kanban), Growth-Team, Notifications, Wikimedia-production-error
daniel added a comment to T274401: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data coming from worker-abusefilter.js .

The client should check the status code (and perhaps the content-type) before attempting to parse the response body.

Wed, Feb 10, 8:29 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Wikimedia-production-error, AbuseFilter
daniel merged T274408: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query into T273479: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query.
Wed, Feb 10, 8:26 PM · Growth-Team, MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Notifications, Wikimedia-production-error
daniel merged task T274408: ForeignWikiRequest.php:135 - PHP Notice: Undefined index: query into T273479: ApiEchoUnreadNotificationPages.php PHP Notice: Undefined index: query.
Wed, Feb 10, 8:26 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Growth-Team, Notifications, Wikimedia-production-error
daniel removed a project from T253717: Add a factory service for `ManualLogEntry` objects: Platform Engineering.
Wed, Feb 10, 8:21 PM · Platform Team Workboards (External Code Reviews), Patch-For-Review, Dependency injection, User-DannyS712, MediaWiki-Logevents
daniel added a comment to T273930: Create performer filter for Special:SecurePollLog form.

The patch is merged, can this ticket be closed?

Wed, Feb 10, 8:18 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll, Platform Engineering
daniel moved T272421: Make WikiPage a PageRecord from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Wed, Feb 10, 3:50 PM · MediaWiki-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel claimed T272421: Make WikiPage a PageRecord.
Wed, Feb 10, 3:50 PM · MediaWiki-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T274317: CirrusSearch: access to WikiPage that not represents a page from PageStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Wed, Feb 10, 3:49 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel added a comment to T271644: Fatal exception undeleting a file on Commons: rev_page field must not be 0!.

Note that the patches attached so far are not expected to fix the issue.

Wed, Feb 10, 3:29 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-deletion, Wikimedia-production-error, Commons
daniel added a comment to T271644: Fatal exception undeleting a file on Commons: rev_page field must not be 0!.

This still happens during undeletion once every couple of days or so. It's not limited to commons, and it's not limited to file pages.

Wed, Feb 10, 3:23 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-deletion, Wikimedia-production-error, Commons
daniel lowered the priority of T271644: Fatal exception undeleting a file on Commons: rev_page field must not be 0! from High to Medium.

Code review did not reveal an obvious cause. Made a patch that adds assertions, to help with pinpointing the cause.

Wed, Feb 10, 3:19 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-deletion, Wikimedia-production-error, Commons
daniel added a comment to T274317: CirrusSearch: access to WikiPage that not represents a page.

Ah, this is a nasty edge case. The code has this check:

// Never. Ever. Index. Negative. Namespaces.
if ( $title->getNamespace() < 0 ) {
	return [ null, $redirects ];
}
Wed, Feb 10, 12:26 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel triaged T274317: CirrusSearch: access to WikiPage that not represents a page as High priority.
Wed, Feb 10, 12:20 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T274317: CirrusSearch: access to WikiPage that not represents a page from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Wed, Feb 10, 12:20 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T222380: Decide how to represent the identity of users from another wiki. from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Wed, Feb 10, 12:19 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel lowered the priority of T272689: Introduce UserStore from Medium to Low.
Wed, Feb 10, 12:19 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel lowered the priority of T272691: Extract UserAccount from User from Medium to Low.
Wed, Feb 10, 12:18 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel raised the priority of T273576: Hard-deprecate IDatabase parameter for UserIdentity:getActorId() from Medium to High.
Wed, Feb 10, 12:18 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel added a comment to T273974: Introduce caching into ActorStore.

Perhaps we could abstract out some of the logic from NameTableStore given that's proven to work and reuse it here.

Wed, Feb 10, 12:18 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel raised the priority of T273974: Introduce caching into ActorStore from Medium to High.
Wed, Feb 10, 12:16 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel lowered the priority of T273934: Support wgSharedTables setup in UserStore from High to Medium.
Wed, Feb 10, 12:15 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel lowered the priority of T263207: The `UserrightsPage` class is not safe to extend from High to Medium.
Wed, Feb 10, 12:15 PM · Platform Team Workboards (MW Expedition), User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, MediaWiki-extensions-CentralAuth, MediaWiki-extensions-Other
daniel moved T273290: Make RevisionStore use ActorLookup instead of User from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Wed, Feb 10, 12:11 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management