IS this resolved? Can we close it?

In T157651#5476780, @aaron wrote:

So, getting this test merged depends on redoing the wikibase schema hook application order for update.php. In CI, there seems to be a problem when it interacts with Flow hooks trying to make pages.

In T192166#5552909, @Jdforrester-WMF wrote:

I'm declaring this Resolved.

In T231588#5552445, @Pchelolo wrote:

Define route for /revision/{id}

I do not think this is a good route name as it's very not future-proof. There's so much stuff that could be returned for a revision. You might want HTML in various different format, you might want summary, images from a page, ORES score etc.

In T231588#5542283, @eprodromou wrote:

So, all slots except "main" go into a slots property that maps the slot name to an object that describes the slot? @daniel any thoughts?

Would it be possibly to use Jenkins' credential store? https://jenkins.io/doc/book/using/using-credentials/

In T91626#5551503, @Aklapper wrote:

In T91626#2627776, @Qgil wrote:

Right now we don't have a clear use case of this, but we might have it for the next round. Let's keep this task open just in case.

Declining as I do not see any use case for this in 2019.

If you have a use case, feel free to elaborate and reopen.

In T233092#5551316, @LarsWirzenius wrote:

It's usually a bad idea to embed secrets into containers. It's better if the container can get the secret when it starts, but I'm not sure if our K8s cluster is set up for that. Or if these containers are run in K8s.

In T233092#5543922, @LarsWirzenius wrote:

I continue to comment on this, while being ignorant about everything. If MW can read a secret from a file, I suggest this:

In T233092#5540581, @LarsWirzenius wrote:

If that's correct enough, I suggest it's CI's job to install the shared secret somewhere suitable on the test machine, but the job of MW developers to specify where.

In T231866#5538179, @gerritbot wrote:

Change 540163 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] [WIP] Storage: SqlBlobStore no longer needs Lanugage object

Blocked on waiting a week to see that nothing breaks on betawiki (T198559). SHould be done in the week of October 7.

Tagging Platform Engineering and pinging @CCicalese_WMF for PM review.

Ah, there is some discussion on the parent task T233987. I'll tag that for PM review.

In T233987#5537771, @eprodromou wrote:

@daniel thanks for the quick reply. Last question: if a volunteer were to submit an otherwise good patch for this, would we accept it? If not, I think we should mark this issue as "declined".

If there's an advantage architecturally, maybe @tstarling or @daniel could comment and advise

Deletion should be rewritten to convert it from a action page to a special page.

In T231866#5462557, @Catrope wrote:

If it were possible to clear the MessageBlobStore without constructing a ResourceLoader, that would solve this circular dependency problem.

Pinging @CCicalese_WMF, since this falls in the scope of the "narrowing the extension interface" initiative. We don't have a phab tag for that yet, right? Once the stable interface policy is established, we'll have to go through the core code and annotate classes and methods to indicate their stability, where it departs from the default. This would probably fall to the Platform Engineering. Could be a good intern project, though it's probably not terribly satisfying...

In T231580#5535881, @eprodromou wrote:

From the REST API design principles:

In T231580#5535888, @eprodromou wrote:

I should note that this endpoint is for explicit revision IDs, and not named relative ones like "prev", "cur", "next", "first" or "last".

Bumped to high, since this blocks T231866: Circular dependency when creating service! ContentLanguage, which we should fix for 1.34

This assumption is broken by the fact that sometimes Language.php calls into LocalisationCache before it has finished constructing the Language object:

Blocked on T228675 which needs review from the Language-Team.

followed up on the -1 now.

bumping to high, since this blocks 1.34

Remaining review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/539607

Things like inserting RC rows for example, is actually pre-send and thus requires nothing nothing beyond CP.