Page MenuHomePhabricator
Feed Advanced Search

Feb 10 2021

daniel moved T273290: Make RevisionStore use ActorLookup instead of User from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 10 2021, 12:11 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel assigned T273290: Make RevisionStore use ActorLookup instead of User to Pchelolo.
Feb 10 2021, 12:11 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel raised the priority of T272557: Convert blocks to PageIdentity from Medium to High.
Feb 10 2021, 10:27 AM · MediaWiki-Blocks, Patch-Needs-Improvement, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T272557: Convert blocks to PageIdentity from High to Medium.
Feb 10 2021, 10:26 AM · MediaWiki-Blocks, Patch-Needs-Improvement, Platform Team Workboards (MW Expedition)
daniel raised the priority of T272557: Convert blocks to PageIdentity from Medium to High.
Feb 10 2021, 10:26 AM · MediaWiki-Blocks, Patch-Needs-Improvement, Platform Team Workboards (MW Expedition)
daniel moved T195069: Factor PageStore and PageRecord out of WikiPage from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 10 2021, 10:26 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Code-Health-Objective
daniel lowered the priority of T274177: PageContentAccess service as a replacement for WikiPage::getContent from High to Medium.
Feb 10 2021, 10:26 AM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel raised the priority of T272421: Make WikiPage a PageRecord from Medium to High.
Feb 10 2021, 10:25 AM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel closed T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached as Resolved.
Feb 10 2021, 10:17 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel moved T273948: Introduce WikiAwareEntityTrait from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Feb 10 2021, 10:17 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition)
daniel triaged T273948: Introduce WikiAwareEntityTrait as High priority.
Feb 10 2021, 10:16 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition)
daniel assigned T273948: Introduce WikiAwareEntityTrait to Pchelolo.
Feb 10 2021, 10:16 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition)
daniel claimed T274274: FileImporter constructs EditPage for a special page.
Feb 10 2021, 10:16 AM · Move-Files-To-Commons, Platform Team Workboards (MW Expedition)
daniel moved T274276: LiquidThreads constructs Article on special page from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Feb 10 2021, 10:16 AM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-extensions-LiquidThreads, Platform Team Workboards (MW Expedition)
daniel claimed T274276: LiquidThreads constructs Article on special page.
Feb 10 2021, 10:15 AM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-extensions-LiquidThreads, Platform Team Workboards (MW Expedition)
daniel added a comment to T274276: LiquidThreads constructs Article on special page.

From InitialSettings.php, for reference:

'wmgUseLiquidThreads' => [
//
// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
// Do not enable this on new wikis.
// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
//
	'default' => false,
	'enwikinews' => true, // Per T23956 -- Andrew 2009-02-09
	'enwiktionary' => true, // T25417 -- ariel 2010-16-05
	'huwiki' => true, // T24909 -- Andrew 2010-09-06
	'ptwikibooks' => true, // T26143 -- Andrew 2010-08-16
	'svwikisource' => true, // T25220 -- Andrew 2010-08-28
],
Feb 10 2021, 9:35 AM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-extensions-LiquidThreads, Platform Team Workboards (MW Expedition)

Feb 9 2021

daniel moved T274274: FileImporter constructs EditPage for a special page from PageStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Feb 9 2021, 9:07 PM · Move-Files-To-Commons, Platform Team Workboards (MW Expedition)
daniel moved T231930: Introduce Authority objects to represent the user performing a given action from Inbox to Research and Prototyping on the tech-decision-forum board.
Feb 9 2021, 7:39 PM · Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel moved T274223: UserIdentityLookup needs batched access from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 9 2021, 5:44 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel triaged T274223: UserIdentityLookup needs batched access as Medium priority.
Feb 9 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T274274: FileImporter constructs EditPage for a special page from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 9 2021, 5:43 PM · Move-Files-To-Commons, Platform Team Workboards (MW Expedition)
daniel moved T274276: LiquidThreads constructs Article on special page from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 9 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-extensions-LiquidThreads, Platform Team Workboards (MW Expedition)
daniel triaged T274274: FileImporter constructs EditPage for a special page as High priority.
Feb 9 2021, 5:43 PM · Move-Files-To-Commons, Platform Team Workboards (MW Expedition)
daniel triaged T274276: LiquidThreads constructs Article on special page as High priority.
Feb 9 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-extensions-LiquidThreads, Platform Team Workboards (MW Expedition)

Feb 8 2021

daniel moved T274212: Deprecate WikiPage::hasViewableContent() from Unsorted pile to WikiPage split pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 11:00 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition)
daniel added a subtask for T239975: Complete WikiPage/Article split and deprecate Page interface: T274212: Deprecate WikiPage::hasViewableContent().
Feb 8 2021, 11:00 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Engineering Roadmap, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Platform Team Workboards (Initiatives), MediaWiki-General
daniel added a parent task for T274212: Deprecate WikiPage::hasViewableContent(): T239975: Complete WikiPage/Article split and deprecate Page interface.
Feb 8 2021, 11:00 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition)
daniel created T274212: Deprecate WikiPage::hasViewableContent().
Feb 8 2021, 11:00 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition)
daniel created T274192: Mark Message as NonSerializable.
Feb 8 2021, 9:17 PM · MediaWiki-Internationalization
daniel added a parent task for T264393: Mark user object as non-serializable: T274189: Remove usage of PHP serialization from WANObjectCache.
Feb 8 2021, 9:02 PM · Platform Engineering Roadmap Decision Making, MediaWiki-User-management
daniel added a subtask for T274189: Remove usage of PHP serialization from WANObjectCache: T264393: Mark user object as non-serializable.
Feb 8 2021, 9:02 PM · MediaWiki-Platform-Team, Epic, MediaWiki-libs-BagOStuff
daniel added a subtask for T274189: Remove usage of PHP serialization from WANObjectCache: T264389: ProofreadPageContent must not contain User object, since it cannot be serialized safely..
Feb 8 2021, 9:01 PM · MediaWiki-Platform-Team, Epic, MediaWiki-libs-BagOStuff
daniel added a parent task for T264389: ProofreadPageContent must not contain User object, since it cannot be serialized safely.: T274189: Remove usage of PHP serialization from WANObjectCache.
Feb 8 2021, 9:01 PM · Platform Engineering Roadmap Decision Making, ProofreadPage
daniel created T274190: Make value objects in AbuseFilter JSON-Serializable.
Feb 8 2021, 9:00 PM · AbuseFilter
daniel created T274189: Remove usage of PHP serialization from WANObjectCache.
Feb 8 2021, 8:56 PM · MediaWiki-Platform-Team, Epic, MediaWiki-libs-BagOStuff
daniel triaged T274180: Decouple RevisionRecord and RevisionStore from User and Title as Medium priority.
Feb 8 2021, 7:41 PM · Platform Team Workboards (MW Expedition), Epic
daniel moved T274180: Decouple RevisionRecord and RevisionStore from User and Title from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:41 PM · Platform Team Workboards (MW Expedition), Epic
daniel moved T273540: Explore what changes would be needed to re-use MW core's new JsonUnserializable and JsonCodec interfaces from PageStore pile to Unsorted pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:41 PM · Abstract Wikipedia team, Platform Team Workboards (MW Expedition)
daniel moved T273540: Explore what changes would be needed to re-use MW core's new JsonUnserializable and JsonCodec interfaces from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:41 PM · Abstract Wikipedia team, Platform Team Workboards (MW Expedition)
daniel created T274180: Decouple RevisionRecord and RevisionStore from User and Title.
Feb 8 2021, 7:41 PM · Platform Team Workboards (MW Expedition), Epic
daniel triaged T274151: Clean up Title deprecated methods as Medium priority.
Feb 8 2021, 7:38 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
daniel moved T274151: Clean up Title deprecated methods from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:38 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
daniel triaged T274067: RevisionStore::getKnownCurrentRevision should be able to work with non-local PageIdentityValue as Medium priority.
Feb 8 2021, 7:37 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel triaged T274179: Deprecate and remove UserIdentity::getActorId() as Medium priority.
Feb 8 2021, 7:37 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T274177: PageContentAccess service as a replacement for WikiPage::getContent from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:37 PM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel triaged T274177: PageContentAccess service as a replacement for WikiPage::getContent as High priority.
Feb 8 2021, 7:37 PM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel moved T274179: Deprecate and remove UserIdentity::getActorId() from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Feb 8 2021, 7:37 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel renamed T274179: Deprecate and remove UserIdentity::getActorId() from Deprecate UserIdentity::getActorId() to Deprecate and remove UserIdentity::getActorId() .
Feb 8 2021, 7:36 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel created T274179: Deprecate and remove UserIdentity::getActorId() .
Feb 8 2021, 7:35 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel created T274177: PageContentAccess service as a replacement for WikiPage::getContent.
Feb 8 2021, 7:23 PM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel added a comment to T273242: MemcachedPeclBagOStuff: Serialization of 'Closure' is not allowed.

Backport deployed for improved logging on wmf.29 (currently on test.wikipedia.org): https://gerrit.wikimedia.org/r/c/mediawiki/core/+/662065

Feb 8 2021, 1:01 PM · User-Majavah, MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-FeaturedFeeds, User-brennen, MediaWiki-libs-BagOStuff, Wikimedia-production-error

Feb 4 2021

daniel closed T141704: Unable to delete certain files due to "inconsistent state within the internal storage backends" as Declined.

No activity since 2019, nothing relevant in the logs for a year. Closing for now. Please reopen if it happens again.

Feb 4 2021, 10:41 PM · MediaWiki-File-management, Wikimedia-production-error, User-fgiunchedi, Multimedia, Commons, SRE, SRE-swift-storage
daniel updated the task description for T231930: Introduce Authority objects to represent the user performing a given action.
Feb 4 2021, 6:27 PM · Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel updated the task description for T231930: Introduce Authority objects to represent the user performing a given action.
Feb 4 2021, 6:27 PM · Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
daniel updated the task description for T273667: Survey extensions for cross-wiki RevisionStore usage.
Feb 4 2021, 12:12 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition), MediaWiki-Core-Revision-backend
daniel added a comment to T198177: Due to PHP fatal, a new version upload overwrote a file (the original is gone).

I outlined a way to avoid this data corruption here: T263301#6487019.

Feb 4 2021, 10:56 AM · Multimedia, Wikimedia-production-error, SRE-swift-storage, Commons
daniel added a comment to T263301: Old image unexpectedly overwritten by a revision several years later (after Internal server error).

Here is another report of this kind of data corruption, caused by a different error condition: T198177: Due to PHP fatal, a new version upload overwrote a file (the original is gone)

Feb 4 2021, 10:54 AM · Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Wikimedia-production-error, MediaWiki-Uploading
daniel added a comment to T215466: Remove revision_comment_temp and revision_actor_temp.

Next steps:

Feb 4 2021, 10:44 AM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Patch-For-Review, Data-Engineering-Icebox, MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Data-Persistence (work done), Platform Engineering Roadmap Decision Making, Analytics-Radar, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Initiatives (Revision Storage Schema Improvements), Technical-Debt, Epic
daniel closed T261053: REST API unnecessarily asks for CSRF tokens as Declined.

Since we are preferring OAuth for the REST API, and requiring a CSRF token for cookie-based auth is erring on the safe side and already working, let's just keep things as they are for now. If this turns out to be a probelm, we can bring back this ticket.

Feb 4 2021, 10:17 AM · Patch-For-Review, Platform Engineering, MediaWiki-REST-API

Feb 3 2021

daniel merged T273805: InvalidArgumentException: Invalid or virtual namespace -1 given - Collection extension into T273101: Accessing WikiPage that cannot exist as a page: w:Help:Books/Book creator text. [Called from WikiPage::exists].
Feb 3 2021, 10:36 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Collection, Patch-For-Review, Platform Team Workboards (MW Expedition), Wikimedia-production-error
daniel merged task T273805: InvalidArgumentException: Invalid or virtual namespace -1 given - Collection extension into T273101: Accessing WikiPage that cannot exist as a page: w:Help:Books/Book creator text. [Called from WikiPage::exists].
Feb 3 2021, 10:36 PM · Release-Engineering-Team (Logspam), Collection, Wikimedia-production-error
daniel added a comment to T273805: InvalidArgumentException: Invalid or virtual namespace -1 given - Collection extension.

Same cause as T273805, the patch was merged yesterday. Do you think it needs a backlport? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Collection/+/659074

Feb 3 2021, 10:35 PM · Release-Engineering-Team (Logspam), Collection, Wikimedia-production-error
daniel lowered the priority of T273576: Hard-deprecate IDatabase parameter for UserIdentity:getActorId() from High to Medium.
Feb 3 2021, 10:29 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel raised the priority of T272901: Standardize RevisionRecord/Store use of wikiID vs dbDomain from Medium to High.
Feb 3 2021, 10:29 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition)
daniel moved T273667: Survey extensions for cross-wiki RevisionStore usage from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 10:29 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition), MediaWiki-Core-Revision-backend
daniel moved T272422: Introduce PageRecord and ExistingPageRecord interfaces from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 10:28 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MediaWiki-Core-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T272424: Make WikiPage a ProperPageIdentity from PageStore pile to Blocked on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 10:28 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition)
daniel moved T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 10:15 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel added a comment to T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached.

Ok, I was able to reproduce this by inserting sleep(1) between the two calls to getParserOutput() in testOldRevisionUseCached(). Seems like something is a bit too eager to expire...

Feb 3 2021, 9:49 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel added a project to T262296: Authority [high effort]: Platform Engineering Roadmap.
Feb 3 2021, 7:55 PM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective
daniel moved T253078: Create ActionFactory, add dependency injection to actions from Tech Planning Review to Tracking/Watching on the Platform Engineering board.
Feb 3 2021, 7:52 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Platform Team Workboards (External Code Reviews), Platform Engineering, Dependency injection, MediaWiki-General, User-DannyS712
daniel added a comment to T253078: Create ActionFactory, add dependency injection to actions.

@eprodromou is it okay to move forward with this using ObjectFactory specs for DI? This has been in "Tech Planning Review" since May

Feb 3 2021, 7:51 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Platform Team Workboards (External Code Reviews), Platform Engineering, Dependency injection, MediaWiki-General, User-DannyS712
daniel edited projects for T261848: Simulate databases for sister sites in phpunit, added: Platform Engineering Roadmap Decision Making; removed Platform Engineering.
Feb 3 2021, 7:47 PM · Patch-Needs-Improvement, Platform Engineering Code Jam-2021, Platform Engineering Roadmap Decision Making, Code-Health, MediaWiki-Core-Tests, Testing-Roadblocks
daniel placed T262296: Authority [high effort] up for grabs.
Feb 3 2021, 5:46 PM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective
daniel raised the priority of T273284: Make RevisionRecord::getPageId() take a wiki ID from Medium to High.
Feb 3 2021, 5:45 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles from High to Medium.
Feb 3 2021, 5:44 PM · Patch-For-Review, ci-test-error, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel triaged T273667: Survey extensions for cross-wiki RevisionStore usage as High priority.
Feb 3 2021, 5:44 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition), MediaWiki-Core-Revision-backend
daniel moved T262296: Authority [high effort] from Authority pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 5:44 PM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective
daniel raised the priority of T273576: Hard-deprecate IDatabase parameter for UserIdentity:getActorId() from Medium to High.
Feb 3 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Feb 3 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests

Feb 2 2021

daniel edited projects for T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
Feb 2 2021, 8:25 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel added a comment to T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached.

Hm, the error message indicates that something is dropped from the fake parser cache used by the tests. Which shouldn't be possible, since it's backed by a HashBagOStuff. Unless a very low expiry time is set, and the test is running very slowly. But the expiry time should be one hour, I can't imagine it running that slowly...

Feb 2 2021, 8:24 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel created T273667: Survey extensions for cross-wiki RevisionStore usage.
Feb 2 2021, 8:07 PM · MediaWiki-extensions-General, Platform Team Workboards (MW Expedition), MediaWiki-Core-Revision-backend
daniel added a comment to T273622: Deprecation warning: Expected RevisionRecord to belong to ....

so for a RevisionRecord belonging to a non-local wiki, calling getId() without arguments will now trigger a call to wfDeprecatedMsg(). But wfDeprecatedMsg() is apparently enough to make unit tests fail, and also cause warnings to be displayed in the page output, so I assume it counts as hard deprecation. Shouldn’t there have been a period of soft deprecation in between?

Feb 2 2021, 8:02 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Wikimedia-production-error, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Patch-For-Review, Platform Engineering, [DEPRECATED] wdwb-tech (legacy-backlog), Wikidata
dancy awarded T273101: Accessing WikiPage that cannot exist as a page: w:Help:Books/Book creator text. [Called from WikiPage::exists] a Hungry Hippo token.
Feb 2 2021, 4:55 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Collection, Patch-For-Review, Platform Team Workboards (MW Expedition), Wikimedia-production-error
daniel added a comment to T273261: Premature access to service container.

I'm confused - does this happen in production? Or does it make tests fail on the extension repos? If so, which tests?

Feb 2 2021, 4:40 PM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, User-Kizule, GoogleLogin, ci-test-error, User-ArielGlenn, Platform Team Workboards (Clinic Duty Team), MediaWiki-General
daniel added a comment to T271081: Flaky tests ParserOutputAccessTest::testOldRevisionCacheSplit and ::testOldRevisionUseCached.

The fact that's it's flaky at this rate shows there's logic problem with the test or the code it's testing. Since there's no fix upto now I don't see any harm in halting it, it can simply be reenabled anytime the issue is fixed. But leaving it hoping the issue to simply go away is wasting people's time.

Feb 2 2021, 4:04 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Patch-For-Review, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests
daniel added a comment to T272635: LinkBatch::addResultToCache: encountered invalid title.

I suspect that this is caused by an empty (or otherwise invalid) user name in the revision history somewhere. I wrote a fix for a similar issue last week, see T232451: ParameterAssertionException: "Bad value for parameter $title: invalid name" (affects actions info, history, diff).

Feb 2 2021, 3:35 PM · Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), User-brennen, MediaWiki-MergeHistory, Wikimedia-production-error
daniel added a comment to T273242: MemcachedPeclBagOStuff: Serialization of 'Closure' is not allowed.

Could perhaps be caused by this: T264391: FeaturedFeedChannel must not contain a User object, since it cannot be serialized safely.

Feb 2 2021, 3:19 PM · User-Majavah, MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-FeaturedFeeds, User-brennen, MediaWiki-libs-BagOStuff, Wikimedia-production-error
daniel added a comment to T273101: Accessing WikiPage that cannot exist as a page: w:Help:Books/Book creator text. [Called from WikiPage::exists].

@Urbanecm Thank you!

Feb 2 2021, 1:59 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Collection, Patch-For-Review, Platform Team Workboards (MW Expedition), Wikimedia-production-error

Feb 1 2021

daniel moved T270430: Introduce ActorStore service from Later (future inbox) to Develop (Now) on the Platform Engineering Roadmap board.
Feb 1 2021, 11:19 AM · Epic, MediaWiki-User-management
daniel moved T195069: Factor PageStore and PageRecord out of WikiPage from Next to Develop (Now) on the Platform Engineering Roadmap board.
Feb 1 2021, 11:18 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Code-Health-Objective

Jan 29 2021

daniel edited projects for T253834: Turn properties into protected Getters in LanguageConverter based hierarchy, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (S&F Workboard).
Jan 29 2021, 2:43 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel moved T272422: Introduce PageRecord and ExistingPageRecord interfaces from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Jan 29 2021, 2:37 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MediaWiki-Core-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel added a subtask for T273290: Make RevisionStore use ActorLookup instead of User: T273288: Create an ActorLookup service.
Jan 29 2021, 2:36 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel added a parent task for T273288: Create an ActorLookup service: T273290: Make RevisionStore use ActorLookup instead of User.
Jan 29 2021, 2:36 PM · Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel triaged T273290: Make RevisionStore use ActorLookup instead of User as High priority.
Jan 29 2021, 2:35 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T273290: Make RevisionStore use ActorLookup instead of User from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Jan 29 2021, 2:35 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel created T273290: Make RevisionStore use ActorLookup instead of User.
Jan 29 2021, 2:34 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel reassigned T222212: RevisionStore must not expose user IDs from a foreign wiki from daniel to CCicalese_WMF.
Jan 29 2021, 2:32 PM · Platform Team Workboards (MW Expedition), Multi-Content-Revisions (Reactive)