Page MenuHomePhabricator
Feed Advanced Search

Today

Jdlrobson added a comment to T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.

This problem has already been solved. Can we fix the misuse of mw-body-content instead introducing a confusingly similar an entirely new and mw-content-body class and thus make skin developers learning curve greater?

Wed, Apr 21, 9:27 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson added a comment to T280593: MobileFrontend transforms interact with protection editnotices on View source page.

I believe that issue is separate and already tracked in T215271

Wed, Apr 21, 9:21 PM · MobileFrontend (Tracking), Wikimedia-Site-requests
Jdlrobson added a comment to T280593: MobileFrontend transforms interact with protection editnotices on View source page.

Transforms apply to all pages. We have no concept of page specific transforms at the current time. We have a configuration option MFMobileFormatterOptions so I suppose we could. There are plans to limit transforms on talk pages (T280051) so perhaps that would allow us build on that.

Wed, Apr 21, 8:11 PM · MobileFrontend (Tracking), Wikimedia-Site-requests
Jdlrobson moved T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had from Phase 4 - Standardize ResourceLoaderSkinModules styling rules to Phase out legacy ResourceLoaderSkinModule feature from Wikimedia-deployed skins on the MediaWiki-Core-Skin-Architecture board.
Wed, Apr 21, 7:14 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson moved T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts from Phase 4 - Standardize ResourceLoaderSkinModules styling rules to Phase out legacy ResourceLoaderSkinModule feature from Wikimedia-deployed skins on the MediaWiki-Core-Skin-Architecture board.
Wed, Apr 21, 7:14 PM · MW-1.37-release, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Performance-Team (Radar), MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-Interface
Jdlrobson moved T111833: Convert wgRightsUrl/wgRightsText into a better way to handle multiple Licenses from Backlog to >= 1.37 on the MediaWiki-Core-Skin-Architecture board.
Wed, Apr 21, 7:14 PM · MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, Software-Licensing, MediaWiki-General
Jdlrobson moved T280766: Phase out legacy error, warning and success classes from Backlog to Phase out legacy ResourceLoaderSkinModule feature from Wikimedia-deployed skins on the MediaWiki-Core-Skin-Architecture board.
Wed, Apr 21, 7:14 PM · User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Jdlrobson updated the task description for T280766: Phase out legacy error, warning and success classes.
Wed, Apr 21, 7:12 PM · User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Jdlrobson updated the task description for T280766: Phase out legacy error, warning and success classes.
Wed, Apr 21, 7:11 PM · User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Jdlrobson added a project to T280766: Phase out legacy error, warning and success classes: User-notice.
Wed, Apr 21, 7:09 PM · User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Jdlrobson edited projects for T278656: Update SVGO to v2.x including new JS based configuration, added: MediaWiki-extensions-GuidedTour, Maps (Kartographer), Revision-Slider, Page-Previews, Two-Column-Edit-Conflict-Merge, UniversalLanguageSelector, MonoBook, Timeless, Notifications, Cite, MediaWiki-extensions-CentralNotice, MediaWiki-Interface; removed Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Core-Skin-Architecture.
Wed, Apr 21, 7:09 PM · MediaWiki-Interface, MediaWiki-extensions-CentralNotice, Cite, Notifications, Timeless, MonoBook, UniversalLanguageSelector, Two-Column-Edit-Conflict-Merge, Page-Previews, Revision-Slider, Maps (Kartographer), Growth-Team, MediaWiki-extensions-GuidedTour, Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27)
Jdlrobson added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

I honestly have no idea what the other current ones actually do and couldn't find any documentation, so I'll just stop here...

Wed, Apr 21, 6:56 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson moved T276248: Position language menu below language button from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Wed, Apr 21, 6:41 PM · Language-Team (Language-2021-April-June), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), UniversalLanguageSelector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdlrobson added a comment to T276248: Position language menu below language button .

Looking close, this was a problem because span.selector-open was being used as the $trigger inside ext.uls.launch instead of the heading... this should fix the problem.

Wed, Apr 21, 6:41 PM · Language-Team (Language-2021-April-June), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), UniversalLanguageSelector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdlrobson added a comment to T276248: Position language menu below language button .

On beta cluster, it seems the mw-interlanguage-selector class has moved from the button to h3

Wed, Apr 21, 6:17 PM · Language-Team (Language-2021-April-June), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), UniversalLanguageSelector, Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdlrobson assigned T275762: Instrument clicks to links in the Languages list in the sidebar to nray.
Wed, Apr 21, 5:36 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Vector (Language in header), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, Desktop Improvements
Jdlrobson updated the task description for T280825: Create harness for A/B test for logged in users.
Wed, Apr 21, 5:29 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson updated the task description for T280825: Create harness for A/B test for logged in users.
Wed, Apr 21, 5:27 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson closed T275807: Create harness for the language switcher A/B test, a subtask of T269093: Deploy new language switching location to test wikis and begin A/B test, as Declined.
Wed, Apr 21, 5:27 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Desktop Improvements
Jdlrobson closed T275807: Create harness for the language switcher A/B test, a subtask of T280770: Instrumentation QA for language switching , as Declined.
Wed, Apr 21, 5:27 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson closed T275807: Create harness for the language switcher A/B test as Declined.

I have opened T280825 to avoid confusion between requirements and discussion here, to preserve this discussion for prosperity.

Wed, Apr 21, 5:27 PM · Vector (Language in header), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdlrobson updated the task description for T280825: Create harness for A/B test for logged in users.
Wed, Apr 21, 5:26 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson updated the task description for T280825: Create harness for A/B test for logged in users.
Wed, Apr 21, 5:25 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson created T280825: Create harness for A/B test for logged in users.
Wed, Apr 21, 5:25 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2020-21)
Jdlrobson reassigned T275158: Vector menu items no longer align logically (+ overlapping sidebar/logo) from Jdlrobson to Edtadros.
Wed, Apr 21, 5:19 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, Vector
Jdlrobson placed T275762: Instrument clicks to links in the Languages list in the sidebar up for grabs.
Wed, Apr 21, 5:11 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Vector (Language in header), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-extensions-WikimediaEvents, Desktop Improvements
Jdlrobson added a comment to T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes.

The patch to review is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681488 - happy to walk you through it.

Wed, Apr 21, 5:09 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, Readers-Web-Backlog (Kanbanana-FY-2020-21), patch-welcome, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Jdlrobson reassigned T278880: Keyboard navigation broken for "Search for pages containing" if exact match exists from cjming to Edtadros.
Wed, Apr 21, 5:05 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Accessibility, Desktop Improvements, WVUI
Jdlrobson placed T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes up for grabs.
Wed, Apr 21, 5:03 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, Readers-Web-Backlog (Kanbanana-FY-2020-21), patch-welcome, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Jdlrobson reopened T111833: Convert wgRightsUrl/wgRightsText into a better way to handle multiple Licenses as "Open".
Wed, Apr 21, 4:51 PM · MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, Software-Licensing, MediaWiki-General
Jdlrobson added a comment to T279714: Add checkbox and radio components to WVUI.

Sounds good. Thanks!

Wed, Apr 21, 4:48 PM · WVUI, Vue.js Migration
Jdlrobson updated the task description for T262846: Errors in checkLoggedIn script.
Wed, Apr 21, 4:44 PM · JavaScript, Wikimedia-production-error, MediaWiki-extensions-CentralAuth
Jdlrobson added a comment to T262846: Errors in checkLoggedIn script.

Yes I am pretty sure these are due to HTML error pages being treated as JS. I have witnessed this happen on one occasion.

Wed, Apr 21, 4:44 PM · JavaScript, Wikimedia-production-error, MediaWiki-extensions-CentralAuth
Jdlrobson edited projects for T280593: MobileFrontend transforms interact with protection editnotices on View source page, added: Wikimedia-Site-requests, MobileFrontend (Tracking); removed MinervaNeue, MobileFrontend.

The problem here is that mbox- class is used in other places and last time I checked not very friendly to mobile phones. I don't know how widely used these are on Russian Wikipedia, but wikis should feel free to re-define what content gets stripped via a site configuration change to wgMFRemovableClasses. No changes to MobileFrontend or Minerva are needed here.

Wed, Apr 21, 4:49 AM · MobileFrontend (Tracking), Wikimedia-Site-requests
Jdlrobson closed T280259: Special:Book interface does not clear itself before footer as Resolved.
Wed, Apr 21, 3:54 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements

Yesterday

Jdlrobson moved T206462: Transition Gruntfile.js tasks to NPM scripts (Popups, MinervaNeue) from Needs More Work to Doing on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 11:12 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, patch-welcome, Technical-Debt, Page-Previews, MinervaNeue
Jdlrobson removed a project from T279693: .plainlinks doesn’t work with Timeless: Readers-Web-Backlog (Kanbanana-FY-2020-21).
Tue, Apr 20, 11:11 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson moved T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

I'm revisiting the links inside elements based on the regression in T279693.

Tue, Apr 20, 11:11 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, Readers-Web-Backlog (Kanbanana-FY-2020-21), patch-welcome, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Jdlrobson added a parent task for T279693: .plainlinks doesn’t work with Timeless: T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes.
Tue, Apr 20, 11:10 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson added a subtask for T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes: T279693: .plainlinks doesn’t work with Timeless.
Tue, Apr 20, 11:10 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, Readers-Web-Backlog (Kanbanana-FY-2020-21), patch-welcome, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Jdlrobson closed T270027: Installer stylesheet fails to load on 1.36/master as Resolved.

Thanks everyone. I can confirm this is finally working and backported.

Tue, Apr 20, 11:10 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Regression, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Installer
Jdlrobson closed T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` as Resolved.

@Volker_E have broken out the acceptance criteria

[] Remove all extra visual properties aside of pure box layout properties
[] Replace outdated PNG icon with current standard icon and consider SVG
Tue, Apr 20, 11:09 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson updated the task description for T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.
Tue, Apr 20, 11:07 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson added a comment to T280259: Special:Book interface does not clear itself before footer.

I'll QA this one and resolve.
Basically need to check that https://en.wikipedia.beta.wmflabs.org/wiki/Special:Book unbreaks.

Tue, Apr 20, 11:06 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson claimed T280259: Special:Book interface does not clear itself before footer.

Sorry Edward for the accidentally assignment :)

Tue, Apr 20, 11:06 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson moved T279693: .plainlinks doesn’t work with Timeless from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 11:05 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson assigned T280259: Special:Book interface does not clear itself before footer to Edtadros.
Tue, Apr 20, 10:51 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson moved T280259: Special:Book interface does not clear itself before footer from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 10:51 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson added a comment to T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts.

Make it actually backward compatible per T280723, as a meta package for the split components, so that skins that were happy with it as-was don't immediately break? Because this isn't just affecting deployed Wikimedia skins, this is also breaking almost all other skins as well.

Tue, Apr 20, 10:35 PM · MW-1.37-release, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Performance-Team (Radar), MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-Interface
Jdlrobson closed T278898: The .editOptions styles should not be shipped as part of ResourceLoaderSkinModule as Resolved.

https://meta.wikimedia.org/wiki/Tech/News/2021/16

Tue, Apr 20, 10:26 PM · User-notice, Technical-Debt, patch-welcome, MediaWiki-Core-Skin-Architecture
Jdlrobson moved T279693: .plainlinks doesn’t work with Timeless from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.
Tue, Apr 20, 10:25 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson moved T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.
Tue, Apr 20, 10:25 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson added a project to T279693: .plainlinks doesn’t work with Timeless: MediaWiki-Core-Skin-Architecture.
Tue, Apr 20, 10:18 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson added a project to T279693: .plainlinks doesn’t work with Timeless: Readers-Web-Backlog (Kanbanana-FY-2020-21).
Tue, Apr 20, 10:18 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Jdlrobson added a comment to T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had.

Several styles previously found in 'interface' or 'elements' or 'content' or something (I'm not really sure which, as I've never really used any of these to begin with) are now in legacy. This includes the toc-style catlist box and thumbnail icons that now override any skin-specific icons (T280292).

Tue, Apr 20, 10:02 PM · MediaWiki-Core-Skin-Architecture
Jdlrobson moved T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector from Backlog to Cleanup skins post 1.36 on the MediaWiki-Core-Skin-Architecture board.
Tue, Apr 20, 9:55 PM · MediaWiki-Core-Skin-Architecture, Wikidata, Wikidata-Campsite, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Vector, Readers-Web-Backlog, wdwb-tech, Technical-Debt, QuickSurveys, MediaWiki-extensions-LiquidThreads, Wikibase, MW-1.37-release
Jdlrobson removed a project from T256511: Remove SkinTemplateToolboxEnd hook: MediaWiki-extensions-LanguageSelector.
Tue, Apr 20, 9:44 PM · MW-1.37-release, MediaWiki-extensions-Duplicator, Patch-For-Review, MediaWiki-skins-Foreground, WPtouch, MediaWiki-skins-p2wiki, MediaWiki-skins-Erudite, Truglass, Metrolook, Gamepress, DuskToDawn, Dusk, DeskMessMirrored, Bouquet, Apex, WikiArticleFeeds, BlueSpice, MediaWiki-extensions-CreateRedirect, MediaWiki-Core-Skin-Architecture
Jdlrobson awarded T105736: Placeholder task for skins work a Like token.
Tue, Apr 20, 9:43 PM · Reading-Admin
Jdlrobson placed T280259: Special:Book interface does not clear itself before footer up for grabs.
Tue, Apr 20, 9:43 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson added a project to T280259: Special:Book interface does not clear itself before footer: MW-1.36-release.
Tue, Apr 20, 9:43 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson moved T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 9:42 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson updated subscribers of T280051: Make mobilefrontend talk overlay disableable.

Allowing the disabling of the talk overlay CSS and JavaScript seems like a straightforward first step here that will help you make progress.

Tue, Apr 20, 9:25 PM · MinervaNeue, Editing-team (FY2020-21 Kanban Board), Readers-Web-Backlog, DiscussionTools
Jdlrobson added a project to T280728: Widget not found on search pages: JavaScript.
Tue, Apr 20, 7:51 PM · JavaScript, MediaWiki-Search, Discovery, Discovery-Search, Wikimedia-production-error
Jdlrobson created T280728: Widget not found on search pages.
Tue, Apr 20, 7:51 PM · JavaScript, MediaWiki-Search, Discovery, Discovery-Search, Wikimedia-production-error
Jdlrobson closed T277331: Widget not found error on pages I don't have permission to access as Resolved.

Sounds good. I'll open new bugs.

Tue, Apr 20, 7:50 PM · MediaWiki-User-preferences, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Readers-Web-Backlog (Tracking), MediaWiki-extensions-GlobalPreferences, Community-Tech, MediaWiki-Interface (actions), Wikimedia-production-error, MassMessage
Jdlrobson added a comment to T280609: Deprecate BaseTemplate::getClear in 1.37.

...what? Why is that any better? How is this not just breaking things for the sake of breaking things?

Tue, Apr 20, 7:44 PM · Anisa, GreyStuff, BlueSky, HasSomeColours, MonoBook, Splash, WoOgLeShades, Timeless, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson assigned T255913: Document tagline and icon options of $wgLogos by putting them in the installer to ovasileva.
Tue, Apr 20, 7:02 PM · MW-1.37-release, Readers-Web-Backlog, MediaWiki-Installer, MediaWiki-Documentation, MediaWiki-Configuration
Jdlrobson moved T279382: VirtualPageView should use EventLogging api to send virtual page view events from Incoming to Tracking on the Readers-Web-Backlog board.
Tue, Apr 20, 6:58 PM · Readers-Web-Backlog (Tracking), Product-Data-Infrastructure, Analytics, Event-Platform, Better Use Of Data
Jdlrobson reassigned T280051: Make mobilefrontend talk overlay disableable from DLynch to ovasileva.
Tue, Apr 20, 6:58 PM · MinervaNeue, Editing-team (FY2020-21 Kanban Board), Readers-Web-Backlog, DiscussionTools
Jdlrobson reassigned T275807: Create harness for the language switcher A/B test from nray to ovasileva.

we met today to talk about this and we are going to decline it. Assigning Olga to summarize,

Tue, Apr 20, 6:33 PM · Vector (Language in header), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements
Jdlrobson raised the priority of T280428: @noflip is not working in toc related LESS file from Medium to High.

Bumping priority then and tagging appropriately. Thanks!

Tue, Apr 20, 6:28 PM · Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Jdlrobson added a comment to T279714: Add checkbox and radio components to WVUI.

When we add these new components, could I suggest that we take the opportunity to think about how the packaging would work and how we want to make use of asycnrhonous components. In particular I'd like to ensure these are not packaged in the critical path, perhaps in a wvui.forms npm module?

Tue, Apr 20, 5:56 PM · WVUI, Vue.js Migration
Jdlrobson closed T105736: Placeholder task for skins work as Resolved.

For those who have access the subject is [reading-wmf] Future work idea: skin system and in the e-mail @bd808 describes a skin system and points to us doing T483 (which is now done) with replies from myself and @Tgr .

Tue, Apr 20, 5:50 PM · Reading-Admin
Jdlrobson moved T280526: Deploy new language switching functionality to logged-in users from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 5:47 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Desktop Improvements
Jdlrobson added a comment to T280428: @noflip is not working in toc related LESS file.

@Huji I presume this bug is significant enough to require backporting to the 1.36 release since it breaks RTL display of a prominent UI element. Is this a good presumption to make?

Tue, Apr 20, 5:41 PM · Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Jdlrobson updated the task description for T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.
Tue, Apr 20, 5:31 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson added a comment to T276561: User links: Logged-in user links menu treatment without icons (for anonymous users no change).

@cjming I did a POC a long time ago https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/656518 that may be of some help as you dive into this one.

Tue, Apr 20, 5:18 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), RW-Feature-DI-User-Menu, Desktop Improvements
Jdlrobson claimed T270027: Installer stylesheet fails to load on 1.36/master.
Tue, Apr 20, 5:05 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Regression, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Installer
Jdlrobson placed T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` up for grabs.
Tue, Apr 20, 5:04 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson removed projects from T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead: Splash, GreyStuff, Gamepress, DuskToDawn, Dusk, Bouquet.
Tue, Apr 20, 5:00 PM · MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, WoOgLeShades, MediaWiki-skins-Tempo, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, DeskMessMirrored, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Jdlrobson moved T278576: Remove non-critical path interface styles out of legacy feature into more appropriate homes from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 4:17 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, Readers-Web-Backlog (Kanbanana-FY-2020-21), patch-welcome, MW-1.36-release, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Jdlrobson claimed T269093: Deploy new language switching location to test wikis and begin A/B test.

Stalled on the A/B test task T275807. Assigning to myself while analysis is not possible.

Tue, Apr 20, 4:05 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Wikimedia-Site-requests, Desktop Improvements
Jdlrobson moved T260338: Notification popup (mw.notify) position incorrectly in Vector 2 from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 4:04 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, Regression, Desktop Improvements
Jdlrobson edited projects for T271441: ResourceLoaderSkinModule features are not backwards compatible, added: MW-1.37-release; removed MW-1.36-release.

Seems like this would benefit from discussion. Can always backport at later date.

Tue, Apr 20, 2:38 PM · MW-1.37-release, Patch-For-Review, Performance-Team (Radar), MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), MediaWiki-ResourceLoader, MediaWiki-Core-Skin-Architecture
Jdlrobson edited projects for T270796: Message boxes classes should carry `mw-`, added: MW-1.37-release; removed MW-1.36-release.
Tue, Apr 20, 2:37 PM · MW-1.37-release, Readers-Web-Backlog, User-notice, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Tech-Ambassadors, MediaWiki-Installer, MediaWiki-General, CSS
Jdlrobson edited projects for T255913: Document tagline and icon options of $wgLogos by putting them in the installer, added: MW-1.37-release; removed MW-1.36-release.
Tue, Apr 20, 2:35 PM · MW-1.37-release, Readers-Web-Backlog, MediaWiki-Installer, MediaWiki-Documentation, MediaWiki-Configuration
Jdlrobson added a project to T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector: MediaWiki-Core-Skin-Architecture.
Tue, Apr 20, 2:34 PM · MediaWiki-Core-Skin-Architecture, Wikidata, Wikidata-Campsite, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Vector, Readers-Web-Backlog, wdwb-tech, Technical-Debt, QuickSurveys, MediaWiki-extensions-LiquidThreads, Wikibase, MW-1.37-release
Jdlrobson removed a project from T279880: [Wikibase] Remove usage of 1.37 deprecated CSS class 'mw-ajax-loader': Readers-Web-Backlog.
Tue, Apr 20, 2:34 PM · Wikidata, wdwb-tech, Technical-Debt, Wikibase, MW-1.37-release
Jdlrobson created T280614: Remove SkinTemplate::makeArticleUrlDetails.
Tue, Apr 20, 12:45 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson created T280613: Remove Skin::getRevisionId, Skin::isRevisionCurrent.
Tue, Apr 20, 12:43 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson created T280612: Remove Skin::makeNSUrl.
Tue, Apr 20, 12:42 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson created T280611: Remove Skin::generateDebugHTML.
Tue, Apr 20, 12:41 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson moved T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead from Backlog to Cleanup skins post 1.36 on the MediaWiki-Core-Skin-Architecture board.
Tue, Apr 20, 12:40 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, WoOgLeShades, MediaWiki-skins-Tempo, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, DeskMessMirrored, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Jdlrobson created T280610: Remove setupSkinUserCss and doSetupSkinUserCss methods.
Tue, Apr 20, 12:40 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture
Jdlrobson updated the task description for T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead.
Tue, Apr 20, 12:32 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, WoOgLeShades, MediaWiki-skins-Tempo, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, DeskMessMirrored, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Jdlrobson added projects to T278266: BaseTemplate::getFooterIcons is deprecated, use $this->get('footericons') instead: MediaWiki-Core-Skin-Architecture, MW-1.37-release.
Tue, Apr 20, 12:32 AM · MW-1.37-release, MediaWiki-Core-Skin-Architecture, Patch-For-Review, MediaWiki-skins-GuMaxDD, WoOgLeShades, MediaWiki-skins-Tempo, Metrolook, MediaWiki-skins-Strapping, HasSomeColours, DeskMessMirrored, BlueSky, Apex, Anisa, MediaWiki-skins-Amethyst
Jdlrobson assigned T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` to Jdrewniak.

If Jan can review the last patch I think we're good to call this done!

Tue, Apr 20, 12:30 AM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson placed T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` up for grabs.
Tue, Apr 20, 12:30 AM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), good first task, MediaWiki-Core-Skin-Architecture, MW-1.35-notes, MW-1.36-release, Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Installer, UI-Standardization
Jdlrobson moved T280259: Special:Book interface does not clear itself before footer from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Tue, Apr 20, 12:29 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), Collection, Desktop Improvements
Jdlrobson moved T279390: Use of BaseTemplate::getToolbox was deprecated in MediaWiki 1.35. will be removed in 1.37 from Backlog to Cleanup skins post 1.36 on the MediaWiki-Core-Skin-Architecture board.
Tue, Apr 20, 12:28 AM · MediaWiki-Core-Skin-Architecture, MW-1.37-release, Patch-For-Review, WPtouch, Truglass, MediaWiki-skins-p2wiki, MediaWiki-skins-GuMaxDD, Dusk, DeskMessMirrored