@Spaceman5, while your desire to fix this bug is appreciated, I already have a patch for this task, and intend to solve the bug myself soon.
Mar 11 2017
Sep 29 2016
Sep 12 2016
One reason this patch didn't go through was due to lack of test coverage. Could I have some assistance with that, please? What metrics do I use, and which tools? Should I be integrating something like Coveralls for my GitHub repository to ensure this?
Jul 7 2016
I just wanted to post an update of proceedings here. Google has reviewed my case, and ruled against overturning the decision provided. Hence, the decision stays the way it is right now. Despite not agreeing with the decision, I am now left with no choice but to accept it.
Jun 29 2016
GSoC mid-term evaluation is done and currently out of our hands. We have heard @darthbhyrava's reasons, we have heard @jayvdb's reasons, and with the information available I recommend you to ask the GSoC programs administrators for their evaluation of the situation. This is your best guarantee of receiving a fair and neutral evaluation. We will follow GSoC program's resolution without discussion.
@darthbhyrava, needless to say you are welcome to continue participating in this or any other Wikimedia project on a volunteer capacity, at your own path and free from the requirements that we set in GSoC projects.
I hope we can find the best solution to the current situation. GSoC is supposed to be fun for students and mentors and I am very sorry to see that you both are going through a lot more trouble and stress than needed.
I would also like to take the opportunity to publicly state that even if the evaluation stays this way after I am done appealing to the Org Admins here, and the Google independent engineers later on, I would still like to complete the deliverables I had promised in my proposal. As stated in my last blog post here, I have learnt a lot over the course of this project, and despite the personal experience being very unpleasant, I enjoyed the professional learning curve.
@Qgil, I understand your decision to trust the veteran mentors for my project, and I agree with the fact that they are experts in their areas, and that they are experienced. I have personally seen evidence of their expertise over the course of the project, and respect them for that. However, I urge you to consider this case in isolation, and to look at the details and counter-arguments that I have provided.
Jun 28 2016
@polybuildr , I wont be debating the decision in public, as that is messy for all concerned, can't alter the outcome at this stage, and is contrary to the GSOC rules.
Its stated clearly that the MVP should be in merged state before the mid-term deadline, and being there at the both end of GSoC, I need to agree with @jayvdb that it is the duty of the student to find alternatives and get their code mergeable somehow.
Jun 27 2016
@jayvdb @Legoktm @QuimGil @polybuildr - please respond. Pass or fail, I'd like to clear up the fact that I had done what was required of me, and was yet failed when it came down to personal judgement.
I strongly disagree with this evaluation.
Jun 26 2016
Jun 24 2016
Jun 23 2016
@jayvdb - an updated patch has been put up for this. It is throwing an error because I cannot seem to execute either isinstance(var, basestring) or isinstance(var, unicode) without pyflakes throwing up errors. I need to get pyflakes throwing the same error locally, I'll fix it.
Jun 22 2016
Jun 21 2016
In your first example, limit=2 should only return two topics. I've confirmed that many topics are returned, seemingly unending, except of course that it eventually fails withTraceback (most recent call last): File "<console>", line 1, in <module> File "pywikibot/flow.py", line 137, in topics topic = Topic.from_topiclist_data(self, root, data) File "pywikibot/flow.py", line 210, in from_topiclist_data topic._root = Post.fromJSON(topic, root_uuid, topiclist_data) File "pywikibot/flow.py", line 355, in fromJSON post = cls(page, post_uuid) File "pywikibot/flow.py", line 330, in __init__ raise NoPage(page, 'Topic must exist: %s') NoPage: Topic must exist: [[test:Topic:Sel4ipu6maqlbm0d]]
Werent you going to raise a bug about that?
Jun 20 2016
The requirement for reproducibility was to extract the most recently updated post, not the newest one. However, while adding the parameter sort_by='updated' for flow.topics, it is throwing up errors, hence for now, I have persisted with the default sort_by='newest'
Jun 19 2016
What exceptions are being ignored on line 57?
As I mentioned in the meeting, total=1 in the second half is a bug. Just using assertNotEquals does not verify that the thanks was successful. Another user could have done a thanks . You need to check that your test user did the thanks.
Jun 17 2016
Please see legoktm's take on determining thanks_enabled:
Jun 16 2016
Jun 15 2016
Jun 14 2016
Jun 13 2016
CBP is over successfully, hence closing this task.
Jun 12 2016
The paste for thanks_tests: P3233
Here's the paste: P3232
The corrected design to be added to scripts/thanks.py: