Page MenuHomePhabricator
Feed Advanced Search

Today

Michael claimed T237524: Create Error vector in store root layer and enum of possible error reasons.
Tue, Nov 19, 11:54 AM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael moved T237523: Create Interface for Service about user being allowed to edit entity from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.
Tue, Nov 19, 11:51 AM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata

Yesterday

Michael claimed T237523: Create Interface for Service about user being allowed to edit entity.
Mon, Nov 18, 2:58 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael moved T237523: Create Interface for Service about user being allowed to edit entity from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Mon, Nov 18, 2:58 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael moved T234060: Exhibit native behavior on key+click on bridge link from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.
Mon, Nov 18, 12:39 PM · User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael claimed T234060: Exhibit native behavior on key+click on bridge link.
Mon, Nov 18, 12:15 PM · User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael created T238533: Proper aria attributes when opening the bridge.
Mon, Nov 18, 11:32 AM · Wikidata, Accessibility, Wikidata-Bridge
Michael moved T237368: Track bridge opening performance from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.
Mon, Nov 18, 11:19 AM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata

Sun, Nov 17

Michael created T238496: Links to edit Senses and Forms can't be reached with the keyboard .
Sun, Nov 17, 2:56 PM · Lexicographical data, Wikidata, Accessibility

Fri, Nov 15

Michael moved T237368: Track bridge opening performance from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Fri, Nov 15, 2:27 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael claimed T237368: Track bridge opening performance.
Fri, Nov 15, 11:53 AM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata

Thu, Nov 14

Michael moved T237368: Track bridge opening performance from Backlog to Ready to pick up on the Wikidata-Bridge board.
Thu, Nov 14, 12:57 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata

Wed, Nov 13

Michael moved T233397: Viewing existing references in the Bridge from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Wed, Nov 13, 2:55 PM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T232468: Illustrate loading from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Wed, Nov 13, 2:55 PM · Wikidata-Bridge-Sprint-9, Wikidata

Tue, Nov 12

Michael moved T237023: Create references (section) component from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.
Tue, Nov 12, 5:01 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T237023: Create references (section) component from Peer Review to Doing on the Wikidata-Bridge-Sprint-9 board.
Tue, Nov 12, 1:28 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T237023: Create references (section) component from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.
Tue, Nov 12, 12:24 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T237023: Create references (section) component from Doing to Peer Review on the Wikidata-Bridge-Sprint-9 board.
Tue, Nov 12, 10:32 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata

Mon, Nov 11

Michael moved T237023: Create references (section) component from Doing to To do on the Wikidata-Bridge-Sprint-8 board.
Mon, Nov 11, 1:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T237023: Create references (section) component from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
Mon, Nov 11, 1:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael claimed T237023: Create references (section) component.
Mon, Nov 11, 1:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Michael, Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata

Wed, Nov 6

Michael triaged T232577: Wikidata Bridge random browser test failure “Errors-Init-Value-Switch shows the current targetValue” (Failed to wait for wikibase.client.data-bridge.app to be ready after 2000 ms) as Normal priority.

Thank you for the links! I made Jenkins remember this log (thanks @Lucas_Werkmeister_WMDE for showing me how), and I'm prioritizing this higher, so we spend some time soon-ish in investigating what is going on.

Wed, Nov 6, 5:37 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Bridge-Sprint-9, Readers-Web-Backlog (Tracking), Wikimedia-production-error (Shared Build Failure), Wikidata
Michael created T237536: Wire up Permission Error Component in Error Component.
Wed, Nov 6, 2:54 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael added a comment to T235154: show error when editor can't edit the statement because of permission errors on the repository.

Partial breakdown for now. We will have to break it down further.

Wed, Nov 6, 12:10 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael updated the task description for T237523: Create Interface for Service about user being allowed to edit entity.
Wed, Nov 6, 12:09 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237528: Create permission error component.
Wed, Nov 6, 12:08 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237527: Add notice component.
Wed, Nov 6, 12:08 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237526: create messages according to mocks.
Wed, Nov 6, 12:08 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237525: modify Message plugin in order to be able to use parameters.
Wed, Nov 6, 12:08 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237524: Create Error vector in store root layer and enum of possible error reasons.
Wed, Nov 6, 12:08 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237523: Create Interface for Service about user being allowed to edit entity.
Wed, Nov 6, 12:08 PM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237522: Investigate options to get block and protection info from remote repository.
Wed, Nov 6, 12:08 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237513: implement loading bar timing in App.
Wed, Nov 6, 10:54 AM · Patch-For-Review, Wikidata-Bridge-Sprint-9, Wikidata
Michael created T237511: Add loading bar component from termbox.
Wed, Nov 6, 10:41 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Wikidata-Bridge-Sprint-9, Wikidata
Michael moved T235152: don't show bridge edit pens when editor can't edit the article from To do to Doing on the Wikidata-Bridge-Sprint-8 board.
Wed, Nov 6, 9:33 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Bridge-Sprint-8, Wikidata

Tue, Nov 5

Michael closed T236234: Implement PropertyDatatypeRepository via ForeignApi, a subtask of T231204: track Bridge openings by property datatype, as Resolved.
Tue, Nov 5, 12:57 PM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael closed T236234: Implement PropertyDatatypeRepository via ForeignApi as Resolved.
Tue, Nov 5, 12:57 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Michael, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T237024: Create reference (the single one) component from Doing to Peer Review on the Wikidata-Bridge-Sprint-8 board.
Tue, Nov 5, 12:56 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Bridge-Sprint-9, User-Michael, Wikidata-Bridge-Sprint-8, Wikidata
Michael removed a project from T237375: Add Wikidata support for szywiki: Wikidata-Bridge.

This is unrelated to Wikidata Bridge, which is a feature still in early development.

Tue, Nov 5, 11:30 AM · Wikidata-Campsite, Wikidata
Michael added a comment to T232577: Wikidata Bridge random browser test failure “Errors-Init-Value-Switch shows the current targetValue” (Failed to wait for wikibase.client.data-bridge.app to be ready after 2000 ms).

@Jdlrobson I looked through recent MobileFrontend patches, but couldn't find a failure related to this task. Could you point us to a patch where it occurred?

Tue, Nov 5, 11:00 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Bridge-Sprint-9, Readers-Web-Backlog (Tracking), Wikimedia-production-error (Shared Build Failure), Wikidata
Michael created T237368: Track bridge opening performance.
Tue, Nov 5, 10:57 AM · Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-9, Wikidata

Mon, Nov 4

Michael added a comment to T235852: Enable ResourceLoader module storage on Firefox 69+.

Yeah, I later noticed that this config option seemed to be only active by default in the 69 beta, not in the actual release and wanted to investigate further, but didn't get around to it so far.
At least now we have enough time to get the implementation right without "loosing time" to Wikipedia being less performative than it could be on Firefox.

Mon, Nov 4, 6:51 PM · User-Michael, Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team, JavaScript
Michael claimed T237024: Create reference (the single one) component.
Mon, Nov 4, 1:38 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Bridge-Sprint-9, User-Michael, Wikidata-Bridge-Sprint-8, Wikidata

Fri, Nov 1

Michael moved T231204: track Bridge openings by property datatype from To do to Doing on the Wikidata-Bridge-Sprint-8 board.
Fri, Nov 1, 2:47 PM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata

Wed, Oct 30

Michael added a comment to T236147: [stalled] close icon is too bold.

Added a quick implementation of the requested change. Though the specifics might depend on the decisions to the questions raised by Pablo.

Wed, Oct 30, 1:31 PM · Wikidata-Bridge-Sprint-9, Patch-For-Review, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T236234: Implement PropertyDatatypeRepository via ForeignApi from Doing to Peer Review on the Wikidata-Bridge-Sprint-8 board.
Wed, Oct 30, 10:29 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Michael, Wikidata-Bridge-Sprint-8, Wikidata

Thu, Oct 24

Michael added a comment to T235152: don't show bridge edit pens when editor can't edit the article.

So the idea is to only show the edit pens when the bridge is ready? That might actually work quite well 🤔

Thu, Oct 24, 10:25 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Bridge-Sprint-8, Wikidata
Michael claimed T236234: Implement PropertyDatatypeRepository via ForeignApi.
Thu, Oct 24, 10:23 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Michael, Wikidata-Bridge-Sprint-8, Wikidata
Michael moved T236234: Implement PropertyDatatypeRepository via ForeignApi from To do to Doing on the Wikidata-Bridge-Sprint-8 board.
Thu, Oct 24, 10:23 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Michael, Wikidata-Bridge-Sprint-8, Wikidata

Wed, Oct 23

Michael added a comment to T236235: Implement and set up tracker in init module.

I would suggest counter.MediaWiki.wikibase.client.databridge.datatype.string, for consistency with some other things tracked in Wikibase. (Note that the MediaWiki part is added automatically when logging from PHP, but in JS we have to add it ourselves.)

Wed, Oct 23, 2:24 PM · Wikidata-Bridge-Sprint-8, Wikidata
Michael added a comment to T236235: Implement and set up tracker in init module.

Maybe the topic could be something like counter.Wikibase.DataBridge.datatype.string ?

Wed, Oct 23, 12:53 PM · Wikidata-Bridge-Sprint-8, Wikidata
Michael added a comment to T236235: Implement and set up tracker in init module.

Just a question regarding 3rd parties, which are not using Graphite. Do we make Graphite as a dependency now, or we wanna try to make this feature some how not effective if it's (Graphite) not enabled/available?

Wed, Oct 23, 12:49 PM · Wikidata-Bridge-Sprint-8, Wikidata

Tue, Oct 22

Michael added a comment to T233305: delayed kicking in of Bridge.

So far we only have a suggestion for a change in technology but no measurable success criteria.

Tue, Oct 22, 3:41 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T235056: Make app change button attributes depending on dirty state of store from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Tue, Oct 22, 2:51 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Bridge-Sprint-8, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael claimed T235056: Make app change button attributes depending on dirty state of store.
Tue, Oct 22, 12:08 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Bridge-Sprint-8, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael added a comment to T235624: close button size is not correct.

@Charlie_WMDE I think this is ready to be verified on beta: https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge

Tue, Oct 22, 12:08 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata, Wikidata-Bridge
Michael added a comment to T235055: Create progressive disabled version of save button.

@Lucas_Werkmeister_WMDE @Michael
According to the inspector the button seems to have a height of 36.7px. would that automatically adjust itself to 40px when placed in the header? Because that's the height it would need to have in the end.

Tue, Oct 22, 10:03 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata

Oct 18 2019

Michael added a comment to T235852: Enable ResourceLoader module storage on Firefox 69+.

Even though the bug mentioned above indicates that the new LocalStorage should be available in Firefox 69, I would feel better if we were able to actually verify that.
However, I'm not sure how to do so. Any ideas?

Oct 18 2019, 12:28 PM · User-Michael, Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team, JavaScript
Michael created T235852: Enable ResourceLoader module storage on Firefox 69+.
Oct 18 2019, 12:07 PM · User-Michael, Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team, JavaScript
Michael moved T235840: Create button component(s) from 🗃️ Incoming to 👁️ watching on the User-Michael board.
Oct 18 2019, 11:30 AM · Wikidata, User-Michael
Michael moved T235824: Share vuejs components between projects from 🗃️ Incoming to 👁️ watching on the User-Michael board.
Oct 18 2019, 11:30 AM · Epic, Wikidata, User-Michael, Wikidata-Trailblazing-Exploration
Michael added a comment to T235840: Create button component(s).
tl;dr: In my opinion, we need two button components, and we should start with both of them from the beginning.
Oct 18 2019, 11:29 AM · Wikidata, User-Michael
Michael created T235840: Create button component(s).
Oct 18 2019, 10:20 AM · Wikidata, User-Michael
Michael created T235836: Extract StringDataValue component.
Oct 18 2019, 9:52 AM · Wikidata
Michael updated the task description for T235835: Consider tool to showcase the components.
Oct 18 2019, 9:47 AM · Wikidata
Michael added a comment to T235835: Consider tool to showcase the components.

From my initial thoughts it seems to make sense to start with storybook in the same repository for now. That should represent the state of the components at the tip of the master branch and facilitate communication from developers to UX.

Oct 18 2019, 9:45 AM · Wikidata
Michael created T235835: Consider tool to showcase the components.
Oct 18 2019, 9:38 AM · Wikidata
Michael created T235834: Create new ooui-ish vuejs component library repository and share first component.
Oct 18 2019, 9:28 AM · Wikidata
Michael created T235824: Share vuejs components between projects.
Oct 18 2019, 9:08 AM · Epic, Wikidata, User-Michael, Wikidata-Trailblazing-Exploration

Oct 17 2019

Michael added a comment to T66721: mw.loader.store should not occupy all of localStorage.

This issue seems to be resolved in Firefox 69 and apparently the quota is now per origin. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1064466#c18

Oct 17 2019, 12:58 PM · MW-1.27-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
Michael updated subscribers of T235055: Create progressive disabled version of save button.

Thank you, @Lucas_Werkmeister_WMDE, for making a current version of the storybook available again :)

Oct 17 2019, 12:40 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235055: Create progressive disabled version of save button from Peer Review to Verification on the Wikidata-Bridge-Sprint-7 board.
Oct 17 2019, 12:38 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata

Oct 16 2019

Michael moved T235055: Create progressive disabled version of save button from Verification to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 16 2019, 4:44 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael reopened T235055: Create progressive disabled version of save button, a subtask of T230342: enable/disable save button depending on Bridge state, as Open.
Oct 16 2019, 4:43 PM · Wikidata-Bridge-Sprint-8, Wikidata-Bridge-Sprint-7, Wikidata
Michael reopened T235055: Create progressive disabled version of save button as "Open".

Shouldn’t this go into the Verification column for UX to review the button?

Oct 16 2019, 4:43 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael closed T235055: Create progressive disabled version of save button, a subtask of T230342: enable/disable save button depending on Bridge state, as Resolved.
Oct 16 2019, 3:28 PM · Wikidata-Bridge-Sprint-8, Wikidata-Bridge-Sprint-7, Wikidata
Michael closed T235055: Create progressive disabled version of save button as Resolved.
Oct 16 2019, 3:28 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael added a comment to T232468: Illustrate loading.

@Michael you have a very good point, thank you for voicing it. After talking to the UX-colleagues I think it's the best idea to stick to the 1second rule, but make sure that we always show the loading indicator for at least 0.5 seconds.
the idea is to always add 0.2 seconds fade in and fade out at the beginning and end of the animation, which would ensure we always get 0.5 seconds in the worst case (worst case being the 0.1 seconds).
Is that technically possible?

Oct 16 2019, 3:12 PM · Wikidata-Bridge-Sprint-9, Wikidata
Michael added a comment to T233305: delayed kicking in of Bridge.

I couldn’t figure out how to make it part of the app module, but extracting the dispatcher into a separate module reduces the size of the init module substantially:

[...]
diff --git a/client/resources/Resources.php b/client/resources/Resources.php
index 9c9a0e0f2..085d2bccd 100644
--- a/client/resources/Resources.php
+++ b/client/resources/Resources.php
@@ -66,6 +66,24 @@
 			}
 		],
+		'wikibase.client.data-bridge.dispatcher' => [
+			'factory' => function () {
+				$clientSettings = WikibaseClient::getDefaultInstance()->getSettings();
+				return new ResourceLoaderFileModule(
+					[
+						'scripts' => [
+							'dispatcher.common.js'
+						],
+						'targets' => $clientSettings->getSetting( 'dataBridgeEnabled' ) ?
+							[ 'desktop', 'mobile' ] :
+							[],
+						'remoteExtPath' => 'Wikibase/client/data-bridge/dist',
+					],
+					__DIR__ . '/../data-bridge/dist'
+				);
+			},
+		],
+
 		'wikibase.client.data-bridge.app' => [
 			'factory' => function () {
 				$clientSettings = WikibaseClient::getDefaultInstance()->getSettings();

[...]

Oct 16 2019, 2:44 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T235055: Create progressive disabled version of save button from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.
Oct 16 2019, 12:11 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235055: Create progressive disabled version of save button from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 16 2019, 12:11 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael added a comment to T235055: Create progressive disabled version of save button.

While working on this ticket a bug in @vue/test-utils was noticed and reported: https://github.com/vuejs/vue-test-utils/issues/1321
This bug could lead to falsely green tickets.

Oct 16 2019, 10:35 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata

Oct 15 2019

Michael claimed T235055: Create progressive disabled version of save button.
Oct 15 2019, 4:41 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T229241: restrict length of string value input from To do to Doing on the Wikidata-Bridge-Sprint-7 board.
Oct 15 2019, 2:31 PM · Wikidata-Bridge-Sprint-7, Wikidata
Michael added a comment to T235152: don't show bridge edit pens when editor can't edit the article.

I think this would be more efficient and better for the user (no flash of unhidden edit buttons before we get around to hiding them).

Oct 15 2019, 1:10 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Bridge-Sprint-8, Wikidata
Michael added a comment to T233305: delayed kicking in of Bridge.

I’m still very tempted to rewrite it in plain JS and serve that as a regular old ResourceLoader module – according to find src/mediawiki/ -type f -name '*.ts' -exec cat {} + | wc -l it’s some 300 lines of TypeScript, that’s not the end of the world –

Correction: the init module also includes some files from src/data-access and a few others, so ca. 700 lines seems to be closer to the real number. (But that’s also including some interfaces and enums.)

Oct 15 2019, 11:02 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata

Oct 10 2019

Michael moved T235035: Define RepoConfigRepository interface from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 10 2019, 1:50 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235039: Add maxlength attribute to ResizingTextField from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.
Oct 10 2019, 1:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235035: Define RepoConfigRepository interface from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
Oct 10 2019, 1:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael claimed T235035: Define RepoConfigRepository interface.
Oct 10 2019, 1:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235035: Define RepoConfigRepository interface from To do to Doing on the Wikidata-Bridge-Sprint-7 board.
Oct 10 2019, 1:29 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235039: Add maxlength attribute to ResizingTextField from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 10 2019, 1:23 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T235039: Add maxlength attribute to ResizingTextField from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
Oct 10 2019, 12:09 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Michael claimed T235039: Add maxlength attribute to ResizingTextField.
Oct 10 2019, 12:09 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata

Oct 9 2019

Michael added a comment to T228857: Investigate common.js bundle content/size.

I spent what felt like (and maybe even was) hours on this only to be hit at the head with the realization that npm/node for some unfathomable reason caches the contents of .browserlistrc and babel.config.js. This cache can be deleted with
$ rm -rf node_modules/.cache

Oct 9 2019, 3:19 PM · Wikidata, Wikidata-Bridge
Michael moved T233305: delayed kicking in of Bridge from To do to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 9 2019, 8:45 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T227758: [investigate] purging strategy from To do to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 9 2019, 8:45 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T231209: investigation about permissions and protection from To do to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Oct 9 2019, 8:45 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata

Oct 8 2019

Michael added a comment to T232468: Illustrate loading.

From the description:

@Charlie_WMDE also mentioned the idea to approach this in a more general fashion, e.g. always showing the loading indicator if a transaction which is known to by asynchronous (e.g. the "saving") takes longer than 1 second.

Oct 8 2019, 11:50 AM · Wikidata-Bridge-Sprint-9, Wikidata
Michael updated the task description for T228066: Error States of Data-Bridge [Tracking].
Oct 8 2019, 11:14 AM · Wikidata, Wikidata-Bridge