Page MenuHomePhabricator
Feed Advanced Search

Oct 8 2019

Michael added a comment to T227758: [investigate] purging strategy.

I think the forcelinkupdate option is just a very confusing name for a fuller purge (I’ll investigate if we need it), but apart from that, yes.

Oct 8 2019, 11:10 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael added a comment to T227758: [investigate] purging strategy.

So the recommended workflow is:

Oct 8 2019, 10:57 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael added a comment to T234897: Bad value for parameter $oldContent: must be a TextContent|null.

What is this phatality? I can’t find any information about it on Wikitech or MediaWiki.org.

Oct 8 2019, 10:30 AM · Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael added a comment to T234897: Bad value for parameter $oldContent: must be a TextContent|null.

That's a duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null (minus the pentesting aspect, which I would not be worried about).

Oct 8 2019, 10:25 AM · Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael updated subscribers of T234897: Bad value for parameter $oldContent: must be a TextContent|null.
Oct 8 2019, 10:02 AM · Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael created T234897: Bad value for parameter $oldContent: must be a TextContent|null.
Oct 8 2019, 10:01 AM · Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael closed T234428: close.svg is not cached in the browser as Invalid.

Seems to depend on local server or mediawiki config.

Oct 8 2019, 9:42 AM · Wikidata, Wikidata-Bridge

Oct 7 2019

Michael renamed T234829: MissingTypeException when trying to set claim via the API from [XZtCTQpAIDUAAK1x2poAAADL] /w/api.php Deserializers\Exceptions\MissingTypeException from line 89 of /vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php: to Exception when trying to set claim via the API.
Oct 7 2019, 3:17 PM · Regression, Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael created T234829: MissingTypeException when trying to set claim via the API.
Oct 7 2019, 3:16 PM · Regression, Wikidata, Wikidata-Campsite, Wikimedia-production-error
Michael moved T224834: test data for demo system from Doing to Verification on the Wikidata-Bridge-Sprint-6 board.
Oct 7 2019, 2:52 PM · User-Michael, Wikidata-Bridge-Sprint-6, Wikidata
Michael awarded Blog Post: Introducing Phatality a Love token.
Oct 7 2019, 1:31 PM · Phabricator
Michael added a comment to T224834: test data for demo system.

Tentative first version: Showcase, Template, Item.

Oct 7 2019, 11:43 AM · User-Michael, Wikidata-Bridge-Sprint-6, Wikidata
Michael claimed T224834: test data for demo system.
Oct 7 2019, 9:09 AM · User-Michael, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T224834: test data for demo system from To do to Doing on the Wikidata-Bridge-Sprint-6 board.
Oct 7 2019, 9:09 AM · User-Michael, Wikidata-Bridge-Sprint-6, Wikidata
Michael closed T233796: browser test canceling, a subtask of T231282: cancel modal, as Resolved.
Oct 7 2019, 9:07 AM · Wikidata-Bridge-Sprint-6, Wikidata
Michael closed T233796: browser test canceling as Resolved.

All patches got merged. Somehow the Gerrit bot got confused and forgot to report that for the patch that adds the selenium tests for pressing escape.

Oct 7 2019, 9:07 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), User-Michael, Wikidata-Bridge-Sprint-6, Wikidata

Oct 2 2019

Michael added a comment to T231209: investigation about permissions and protection.

Thank you for the investigation!

Oct 2 2019, 12:06 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael created T234428: close.svg is not cached in the browser.
Oct 2 2019, 11:41 AM · Wikidata, Wikidata-Bridge
Michael moved T233796: browser test canceling from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.
Oct 2 2019, 11:13 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), User-Michael, Wikidata-Bridge-Sprint-6, Wikidata
Michael claimed T233796: browser test canceling.
Oct 2 2019, 9:55 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), User-Michael, Wikidata-Bridge-Sprint-6, Wikidata

Oct 1 2019

Michael updated the task description for T234316: upgrade to upcoming wdio-mediawiki version.
Oct 1 2019, 11:01 AM · Wikidata, Wikidata-Bridge
Michael changed the status of T234316: upgrade to upcoming wdio-mediawiki version from Open to Stalled.
Oct 1 2019, 11:00 AM · Wikidata, Wikidata-Bridge
Michael created T234316: upgrade to upcoming wdio-mediawiki version.
Oct 1 2019, 11:00 AM · Wikidata, Wikidata-Bridge
Michael added a comment to T231887: investigation for ensuring editing with the same credentials.

So, remaining action item – handle assert failures better?

Oct 1 2019, 9:59 AM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael updated the task description for T228066: Step 1: Error States of Data-Bridge [Tracking].
Oct 1 2019, 9:54 AM · Wikidata, Wikidata-Bridge

Sep 26 2019

Michael added a comment to T231887: investigation for ensuring editing with the same credentials.

[...] basically, we add assert='user' or assertuser=mw.config.get('wgUserName') (not sure which) to the wbeditentity request if the user is logged in locally; rely on CentralAuth to do the right thing™; and if the assert fails, ask the user to log in and try again?

Sep 26 2019, 3:38 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T233830: App "isExisting" after close (by save) from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.
Sep 26 2019, 3:29 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), User-Michael, Wikidata-Bridge-Sprint-6
Michael closed T232999: Make ProcessDialog use different message keys depending on wgEditSubmitButtonLabelPublish setting as Resolved.
Sep 26 2019, 10:15 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Wikidata-Bridge-Sprint-6, Wikidata-Bridge-Sprint-5, Wikidata
Michael closed T232999: Make ProcessDialog use different message keys depending on wgEditSubmitButtonLabelPublish setting, a subtask of T228260: obey wgEditSubmitButtonLabelPublish setting in Wikidata Bridge, as Resolved.
Sep 26 2019, 10:15 AM · Wikidata-Bridge-Sprint-6, Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T228260: obey wgEditSubmitButtonLabelPublish setting in Wikidata Bridge from Doing to Verification on the Wikidata-Bridge-Sprint-6 board.
Sep 26 2019, 10:15 AM · Wikidata-Bridge-Sprint-6, Wikidata-Bridge-Sprint-5, Wikidata
Michael closed T232998: Pass wgEditSubmitButtonLabelPublish variable from bridge config (init) to ProcessDialog component as Resolved.
Sep 26 2019, 10:15 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Wikidata-Bridge-Sprint-6, Wikidata-Bridge-Sprint-5, Wikidata
Michael closed T232998: Pass wgEditSubmitButtonLabelPublish variable from bridge config (init) to ProcessDialog component, a subtask of T228260: obey wgEditSubmitButtonLabelPublish setting in Wikidata Bridge, as Resolved.
Sep 26 2019, 10:15 AM · Wikidata-Bridge-Sprint-6, Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T233830: App "isExisting" after close (by save) from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
Sep 26 2019, 9:45 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), User-Michael, Wikidata-Bridge-Sprint-6
Michael moved T231887: investigation for ensuring editing with the same credentials from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.
Sep 26 2019, 9:45 AM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael claimed T233830: App "isExisting" after close (by save).
Sep 26 2019, 9:45 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), User-Michael, Wikidata-Bridge-Sprint-6

Sep 25 2019

Michael added a comment to T231887: investigation for ensuring editing with the same credentials.

I have a couple questions regarding this:
-> Do we make central auth as a dependency of DataBridge (especially regarding 3rd parties)? If yes we should somewhere doc (as well as ULS), or?

Using central auth in 3rd party installations seems to be generally discouraged, because it is complex to set up and maintain. For the purpose of this MVP I would assume that client and repo have in principle access to the same users.

Sep 25 2019, 1:23 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael added a comment to T231887: investigation for ensuring editing with the same credentials.

After playing around with the creation of new users that have never been to wikidata, it seems that the startup API requests to wikidata are enough to create the user there.

Sep 25 2019, 1:09 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata

Sep 24 2019

Michael updated the task description for T233397: Viewing existing references in the Bridge.
Sep 24 2019, 9:29 AM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael updated the task description for T233397: Viewing existing references in the Bridge.
Sep 24 2019, 9:26 AM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael updated the task description for T233397: Viewing existing references in the Bridge.
Sep 24 2019, 9:22 AM · Wikidata-Bridge-Sprint-9, Wikidata-Bridge-Sprint-8, Wikidata
Michael updated the task description for T233305: delayed kicking in of Bridge.
Sep 24 2019, 9:10 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael added a comment to T233305: delayed kicking in of Bridge.

Story time notes:

Sep 24 2019, 9:09 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Michael moved T229241: restrict length of string value input from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.
Sep 24 2019, 8:58 AM · Wikidata-Bridge-Sprint-7, Wikidata

Sep 23 2019

Michael moved T233599: Translate save button from Peer Review to Verification on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 2:37 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T231887: investigation for ensuring editing with the same credentials from Doing to Peer Review on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 2:37 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael added a comment to T231887: investigation for ensuring editing with the same credentials.

While the situation may happen as described in T231209 and T202028, that the user is only logged into the Wikipedia site with the bridge app, but not into Wikidata, that doesn't seem to be a problem as the login-check is made against central auth and not wikidata itself. Hence the edit is still made on wikidata as the logged-in user without actually being logged-in in wikidata on the browser.

Sep 23 2019, 2:32 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael added a comment to T202028: Central auth fails when using "site isolation" in Google Chrome and Chromium or "first-party isolation" in Firefox.

I just tried it out (while looking into T231887) and this is weirdly asymmetric.

Sep 23 2019, 1:57 PM · Browser-Support-Firefox, Browser-Support-Google-Chrome, Security, MediaWiki-extensions-CentralAuth
Michael moved T231887: investigation for ensuring editing with the same credentials from To do to Doing on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 12:59 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael claimed T231887: investigation for ensuring editing with the same credentials.
Sep 23 2019, 12:59 PM · Wikidata-Bridge-Sprint-6, User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T231708: Add browser test for client edit from Doing to Peer Review on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 10:13 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael moved T232588: Test tags via browser test from Doing to Peer Review on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 10:13 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T232994: Translate "Data Bridge" string in ProcessDialog component from Peer Review to Verification on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 10:13 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, Wikidata
Michael moved T233326: mend ProcessDialogHeader to match visual style of figma/OOUI from Peer Review to Verification on the Wikidata-Bridge-Sprint-5 board.
Sep 23 2019, 9:59 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5

Sep 20 2019

Michael updated the task description for T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Sep 20 2019, 2:52 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikidata, Wikimedia-production-error
Michael created T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Sep 20 2019, 2:49 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikidata, Wikimedia-production-error
Michael added a comment to T232468: Illustrate loading.

For reference: Termbox has something that is at least similar to what we want: https://tools-static.wmflabs.org/wikibase-termbox-storybook/?path=/story/indeterminateprogressbar--default

Sep 20 2019, 1:46 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Bridge-Sprint-10, Wikidata-Bridge-Sprint-11, Wikidata-Bridge-Sprint-9, Wikidata
Michael added a comment to T233395: more precise edit summaries for Bridge edits.

Story writing remark: This may need an investigation as to why we are currently not getting more specific edit summaries. Shouldn't there be a diff happening on the server side?

Sep 20 2019, 1:43 PM · Wikidata, Wikidata-Bridge

Sep 19 2019

Michael claimed T232588: Test tags via browser test.
Sep 19 2019, 3:29 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), User-Michael, Wikidata-Bridge-Sprint-5, Wikidata
Michael created T233314: Disable/Prevent Browser Cache of Ajax-request to Special:EntityData.
Sep 19 2019, 1:31 PM · Wikidata, Wikidata-Bridge

Sep 18 2019

Michael moved T231708: Add browser test for client edit from Doing to To do on the Wikidata-Bridge-Sprint-3 board.
Sep 18 2019, 4:27 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael claimed T231708: Add browser test for client edit.
Sep 18 2019, 4:20 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

@Charlie_WMDE Another topic that came up is the question of which effect pressing the space bar should have, if the button is an overloaded or a pure link.
This is not needed for the current use-case, but it is likely to come up in the future. (An example of the button being a pure link would be the primary progressive "Login-Button" in the Termbox anon edit warning.)

Sep 18 2019, 1:35 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata

Sep 17 2019

Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

@Charlie_WMDE
Two UX related things that came up during working on this:

Sep 17 2019, 10:10 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata
Michael removed a watcher for Shape Expressions: Michael.
Sep 17 2019, 9:19 AM
Michael added a watcher for Wikidata-Bridge: Michael.
Sep 17 2019, 9:18 AM

Sep 13 2019

Michael moved T227003: Add an edit tag parameter and tag the edits made via data bridge with "Data Bridge" from To do to Doing on the Wikidata-Bridge-Sprint-5 board.
Sep 13 2019, 2:09 PM · Wikidata-Bridge-Sprint-5, Wikidata
Michael renamed T232834: Ensure IE11 CSS prefixes are correctly added from Ensure IE11 CSS prefixes are correctly adde to Ensure IE11 CSS prefixes are correctly added.
Sep 13 2019, 12:48 PM · Wikidata-Bridge
Michael created T232834: Ensure IE11 CSS prefixes are correctly added.
Sep 13 2019, 12:47 PM · Wikidata-Bridge

Sep 12 2019

Michael moved T231473: Wire up repository for entity label with services from Peer Review to Done on the Wikidata-Bridge-Sprint-5 board.
Sep 12 2019, 10:00 AM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata

Sep 11 2019

Michael moved T229582: Ensure responsiveness from Peer Review to Verification on the Wikidata-Bridge-Sprint-5 board.
Sep 11 2019, 1:36 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael moved T231473: Wire up repository for entity label with services from Doing to Peer Review on the Wikidata-Bridge-Sprint-5 board.
Sep 11 2019, 1:35 PM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael moved T231473: Wire up repository for entity label with services from To do to Doing on the Wikidata-Bridge-Sprint-5 board.
Sep 11 2019, 1:35 PM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael moved T231473: Wire up repository for entity label with services from Doing to To do on the Wikidata-Bridge-Sprint-4 board.
Sep 11 2019, 1:35 PM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael claimed T231473: Wire up repository for entity label with services.
Sep 11 2019, 12:48 PM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

Hanna however was kind enough to point a key difference between the "primaryprogressive" button as used in termbox and the one we can observe in the bridge spec and the related OOUI demo for "process dialog": the "primaryprogressive" itself exhibits rounded corners (border-radius: 2px) but these are removed from the element when used as a part of a header ("processDialog actionWidget" in OOUI terminology) as intended in bridge.
We now have clarity on the requirements' side but face a bit of a technological challenge. OOUI implements this by implementing a selector specific to this case (button inside dialog). For our vue components we, so far, followed the BEM approach and the component's appearance are organized in so-called modifications ("primaryprogressive" is an example of this) and we usually refrain from influencing these modifications' styles from the outside but rather create a new component modification. Parents typically call for one concrete modification of a component. So how do we tackle this?

Sep 11 2019, 9:50 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata

Sep 3 2019

Michael claimed T230895: Problem: the ooui dialog has a padding that we want/need _inside_ of our app, not around it.

I adjusted the variables in _variables.scss in two ways:

  1. I renamed $base-font-size-desired to $container-relative-font-size as that is what it is and that makes its purpose in the calculations clear: to undo the change in font-size coming from container by dividing by $container-relative-font-size
  2. I kept the explizit px units for the calculation as I find them to helpful in understanding the calculations. I assume they are not in the common.less because Less handles units in calculations strangely. (This is an update from my previous position that it is better to remove thos px units.)
Sep 3 2019, 12:31 PM · User-Michael, Wikidata-Bridge-Sprint-4, Wikidata, Wikidata-Bridge-Sprint-3
Michael edited parent tasks for T231833: standardize language codes to standard ones for HTML, added: T227759: Show label for Property in Wikidata Bridge modal; removed: T226999: Save Wikidata edit when submitting client edit modal.
Sep 3 2019, 10:00 AM · Wikidata-Bridge-Sprint-5, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael removed a subtask for T226999: Save Wikidata edit when submitting client edit modal: T231833: standardize language codes to standard ones for HTML.
Sep 3 2019, 10:00 AM · Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael added a subtask for T227759: Show label for Property in Wikidata Bridge modal: T231833: standardize language codes to standard ones for HTML.
Sep 3 2019, 10:00 AM · Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael closed T230335: Create SavingEntityRepository, a subtask of T226999: Save Wikidata edit when submitting client edit modal, as Resolved.
Sep 3 2019, 9:44 AM · Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael closed T230335: Create SavingEntityRepository as Resolved.
Sep 3 2019, 9:44 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael updated the task description for T230336: Create entity save action.
Sep 3 2019, 9:40 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata
Michael renamed T231473: Wire up repository for entity label with services from Add repository for entity label to services to Wire up repository for entity label with services.
Sep 3 2019, 8:51 AM · User-Michael, Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata
Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

Side note: OOUI has two general classes for buttons. In both, a tag name is configurable, but ButtonWidget is for general, client-handled buttons (<span> by default),

My understanding was that ButtonWidget uses an <a tabindex="0"> as the clickable element, wrapped in a <span> for styling purposes. But I think it is quite possible that I missed something or misunderstood some functionality. How would I change the tag name?

Sep 3 2019, 7:16 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata

Sep 2 2019

Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

I think the implication for UX/product would be that the permutation-option allows for quicker button creation in the future (which is good since we'll definitely need more buttons and different kinds of buttons) and from my perspective that also means, i can look at the finished product quicker. The other thing that comes to mind is that we don't have to maintain the "same" buttons in two places which makes things easier as well, and I don't need to specify which of the "same" type of button i mean.

Sep 2 2019, 11:32 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata
Michael moved T231465: Create a repository for entity label in specific language from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
Sep 2 2019, 11:11 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), User-Michael, Wikidata-Bridge-Sprint-4, Wikidata
Michael moved T230328: Add "Header" component from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.
Sep 2 2019, 11:11 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata
Michael claimed T231465: Create a repository for entity label in specific language.
Sep 2 2019, 11:11 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), User-Michael, Wikidata-Bridge-Sprint-4, Wikidata
Michael moved T230328: Add "Header" component from Doing to Peer Review on the Wikidata-Bridge-Sprint-4 board.
Sep 2 2019, 9:04 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata

Aug 30 2019

Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

Maybe my post above was a bit too concise, so here is a longer version of my reasoning. Also, some update.

Aug 30 2019, 9:28 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata

Aug 29 2019

Michael added a comment to T230895: Problem: the ooui dialog has a padding that we want/need _inside_ of our app, not around it.
Aug 29 2019, 1:19 PM · User-Michael, Wikidata-Bridge-Sprint-4, Wikidata, Wikidata-Bridge-Sprint-3

Aug 28 2019

Michael moved T230328: Add "Header" component from Peer Review to Doing on the Wikidata-Bridge-Sprint-4 board.
Aug 28 2019, 4:00 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata
Michael moved T230328: Add "Header" component from Doing to Peer Review on the Wikidata-Bridge-Sprint-4 board.
Aug 28 2019, 4:00 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata
Michael added a comment to T230326: Reuse EventEmittingButton from termbox.

As written above, I think trying to generalize the Termbox EventEmittingButton to be used everywhere in Bridge is an approach that is flawed in its premises. This creates an overly complex component that does multiple jobs (Link and pure Button) and tries to conform to multiple conflicting styles (Termbox and Bridge/OOUI).

Aug 28 2019, 1:55 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata
Michael added a comment to T227759: Show label for Property in Wikidata Bridge modal.
NOTE: Duplicate storybook stories for right-to-left languages
Aug 28 2019, 8:23 AM · Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata

Aug 27 2019

Michael updated subscribers of T229241: restrict length of string value input.

@Addshore For this story (and possibly also upcoming ones) we need access to repo configuration from a client wiki. As researched by @Lucas_Werkmeister_WMDE above, we don't seem to currently have a way to get that information. Therefore, we may need to create a new public API endpoint.

Aug 27 2019, 12:56 PM · Wikidata-Bridge-Sprint-7, Wikidata
Michael moved T228986: Talk with component library internal stakeholders from 💬 waiting on other's work or feedback to 👁️ watching on the User-Michael board.
Aug 27 2019, 12:42 PM · Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-2, Wikidata
Michael placed T228986: Talk with component library internal stakeholders up for grabs.
Aug 27 2019, 12:42 PM · Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-2, Wikidata

Aug 26 2019

Michael moved T231074: Selenium tests will fail on gate&submit from To do to Peer Review on the Wikidata-Bridge-Sprint-3 board.
Aug 26 2019, 4:39 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3
Michael moved T230326: Reuse EventEmittingButton from termbox from ✅ my work done to 👁️ watching on the User-Michael board.
Aug 26 2019, 3:58 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikidata-Bridge-Sprint-5, User-Alaa, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, User-Michael, Wikidata