Page MenuHomePhabricator
Feed Advanced Search

Jun 18 2019

Pablo-WMDE created T226010: Add bridge init js via ResourceLoader.
Jun 18 2019, 11:25 AM · User-Michael, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225935: Implement Feature Flag for Mediawiki, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:23 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), User-Michael, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225930: Implement Link Counter, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:22 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Michael, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T224832: Connect template parameter to corresponding Wikidata property, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:22 AM · Wikidata-Bridge-Sprint-1, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225953: 5.- Storybook, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:21 AM · Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225952: 4.- Linting, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:21 AM · Patch-For-Review, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225950: 3.- Jest unit test, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:19 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225949: 2.- Vue + ts compilation (log "hello wikidata bridge") on docker, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:18 AM · User-Michael, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE updated the task description for T225949: 2.- Vue + ts compilation (log "hello wikidata bridge") on docker.
Jun 18 2019, 11:18 AM · User-Michael, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE edited projects for T225948: 1.- Research Webpack + RL, added: Wikidata-Bridge-Sprint-0; removed Wikidata-Bridge.
Jun 18 2019, 11:15 AM · Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE updated the task description for T225948: 1.- Research Webpack + RL.
Jun 18 2019, 9:23 AM · Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE set the image for Wikidata-Bridge to F29600908: profile.
Jun 18 2019, 9:10 AM
Pablo-WMDE edited Description on Wikidata-Bridge.
Jun 18 2019, 9:09 AM
Pablo-WMDE updated the task description for T225814: m.wikidata: login status not detected.
Jun 18 2019, 8:26 AM · User-Pablo-WMDE, MobileFrontend (Tracking), MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager, Wikidata Mobile, Wikidata-Termbox, Wikidata
Pablo-WMDE updated the task description for T225952: 4.- Linting.
Jun 18 2019, 8:17 AM · Patch-For-Review, Wikidata-Bridge-Sprint-0, Wikidata

Jun 17 2019

Pablo-WMDE added a comment to T225950: 3.- Jest unit test.

According to the blubber documentation, a blubber file is expected to have", at minimum, two variants (1) test and (2) production"

Jun 17 2019, 4:20 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE updated the task description for T224832: Connect template parameter to corresponding Wikidata property.
Jun 17 2019, 2:12 PM · Wikidata-Bridge-Sprint-1, Wikidata-Bridge-Sprint-0, Wikidata
Pablo-WMDE added a project to T224833: first client edit for simple typo: Epic.
Jun 17 2019, 12:59 PM · Epic, Wikidata, Wikidata-Bridge

Jun 15 2019

Pablo-WMDE added a comment to T218081: Log failed node -> mediawiki requests.

With this deployed (T225858) to beta we can now witness verbose information in the logs, e.g. a crafted mismatch of entity id to revision id:
https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2019.06.15/wikibase-termbox?id=AWtaAdp6AbPxH_Ymzz-o&_g=()

Jun 15 2019, 7:28 AM · Wikidata-Termbox-Iteration-19, Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T225858: beta SSR: not updated after repo change.
Jun 15 2019, 7:26 AM · Wikidata-Termbox-Iteration-18, Wikidata-Termbox-Iteration-17

Jun 14 2019

Pablo-WMDE added a project to T225814: m.wikidata: login status not detected: MediaWiki-extensions-CentralAuth.

Would be great to get word from the MediaWiki-extensions-CentralAuth people if they have a suspicion where this problem originates from.

Jun 14 2019, 4:55 PM · User-Pablo-WMDE, MobileFrontend (Tracking), MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager, Wikidata Mobile, Wikidata-Termbox, Wikidata
Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

While researching this we filed T225814.
I would be happy if we could close this story despite this (unrelated) incident. Verification of the AC of this story should be possible by logging in through the login page of the mobile beta site.

Jun 14 2019, 1:00 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE created T225814: m.wikidata: login status not detected.
Jun 14 2019, 12:55 PM · User-Pablo-WMDE, MobileFrontend (Tracking), MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager, Wikidata Mobile, Wikidata-Termbox, Wikidata
Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

@Hanna_Petruschat_WMDE was kind enough to showcase this to me, click path is a follows

  1. open mobile item page (trough useformat=mobile query not m. subdomain), e.g. https://wikidata.beta.wmflabs.org/w/index.php?title=Q11&useformat=mobile
  2. click "edit pen"
  3. click "log in" in the overlay
  4. login page in desktop layout opens
  5. logging in with correct credentials
  6. item page (same item as before) in desktop layout opens
  7. scroll to bottom, click the "Mobile view" link
  8. item page (same item as before) in mobile layout opens (trough m. subdomain)
  9. warning is shown "Central login - You are centrally logged in. Reload the page to apply your user settings."
    • the page behaves as if not logged in
    • reloading does not resolve this - message re-appears, page behaves as not logged in
Jun 14 2019, 9:12 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

Jun 13 2019

Pablo-WMDE moved T224976: Browser test persistence from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.
Jun 13 2019, 3:23 PM · Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

@Lea_WMDE It would be interesting to see under which circumstances this (the "Central logi" overlay) happens for you - I can't really reproduce this. Even if it does not sound like it could be our fault it should still be reproducible.

Jun 13 2019, 3:21 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

Jun 12 2019

Pablo-WMDE updated the task description for T225616: Run FundraisingFrontend PHP code in a container.
Jun 12 2019, 12:39 PM · WMDE-Fundraising-CFR, Epic, WMDE-FUN-Team, WMDE-Fundraising-Tech

Jun 11 2019

Pablo-WMDE claimed T225507: Create delegating preference repository.
Jun 11 2019, 2:31 PM · Wikidata-Termbox-Iteration-18, Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE moved T225507: Create delegating preference repository from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.
Jun 11 2019, 2:31 PM · Wikidata-Termbox-Iteration-18, Wikidata-Termbox-Iteration-17, Wikidata

Jun 6 2019

Pablo-WMDE moved T224976: Browser test persistence from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.
Jun 6 2019, 1:29 PM · Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE added a comment to T221835: Add CC0 License overlay popup on termbox editing.

@Lea_WMDE @Hanna_Petruschat_WMDE I believe it does not explicitly mention it - is the focus/tab order to be in line with what we did for the IP warning? T223542

Jun 6 2019, 10:42 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE added a comment to T221833: Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice.

We are still working on some browser tests, but this is already showing on beta.
/cc @Lea_WMDE @Hanna_Petruschat_WMDE

Jun 6 2019, 8:26 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata

Jun 5 2019

Pablo-WMDE added a comment to T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase.

Reminded me of T195402

Jun 5 2019, 4:00 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), JavaScript, Wikidata
Pablo-WMDE moved T223987: Use user preference value to avoid "You are not logged in" overlay from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.
Jun 5 2019, 3:11 PM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

This is on beta with all sub tasks now.
Of course, the checkbox (T221833) is not there yet.

Jun 5 2019, 2:37 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE closed T223542: Focus modal CTAs instead of publish button, a subtask of T221831: Add "You are not logged in" overlay popup on termbox editing, as Resolved.
Jun 5 2019, 2:35 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE closed T223542: Focus modal CTAs instead of publish button as Resolved.
Jun 5 2019, 2:35 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE created T225080: "Set HEALTHCHECK_QUERY to NaN".
Jun 5 2019, 10:42 AM · Wikidata, Wikidata-Termbox-Iteration-18, Patch-For-Review, Wikidata-Termbox-Iteration-17

Jun 4 2019

Pablo-WMDE awarded T179229: Decide whether we want the package-lock.json to commit or ignore a 100 token.
Jun 4 2019, 5:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Platform Team Legacy (Designing), Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General
Pablo-WMDE claimed T224976: Browser test persistence.
Jun 4 2019, 11:22 AM · Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE moved T224976: Browser test persistence from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.
Jun 4 2019, 11:21 AM · Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE created T224976: Browser test persistence.
Jun 4 2019, 11:21 AM · Wikidata-Termbox-Iteration-17, Wikidata
Pablo-WMDE moved T223985: Use checkbox in AnonEditWarning from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.
Jun 4 2019, 11:14 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE updated the task description for T222780: Disallow duplicate information in Termbox.
Jun 4 2019, 10:42 AM · Wikidata, Wikidata-Termbox

Jun 3 2019

Pablo-WMDE moved T223985: Use checkbox in AnonEditWarning from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.
Jun 3 2019, 3:54 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE moved T218979: NPM Audit: get fixed braces version in direct deps from Must do (but stalled) to Should haves (V 1.1) on the Wikidata-Termbox board.
Jun 3 2019, 3:21 PM · Wikidata, Wikidata-Termbox
Pablo-WMDE added a comment to T218979: NPM Audit: get fixed braces version in direct deps.

Still the case as of today.
Given this is something we have to and will do at some point, but not a blocker to production (never was), there is little value of preserving an outdated column for it - moving.

Jun 3 2019, 3:20 PM · Wikidata, Wikidata-Termbox

May 29 2019

Pablo-WMDE updated the task description for T222890: Show progress/activity if a save request is still being processed.
May 29 2019, 3:45 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikibase-Termbox-Iteration-20, Wikidata
Pablo-WMDE moved T224548: Make (yellow) warning background wider than rest of content from Peer Review to Done on the Wikidata-Termbox-Iteration-16 board.
May 29 2019, 3:25 PM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE moved T224548: Make (yellow) warning background wider than rest of content from Doing to Peer Review on the Wikidata-Termbox-Iteration-16 board.
May 29 2019, 3:25 PM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T224548: Make (yellow) warning background wider than rest of content.
May 29 2019, 9:34 AM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T224547: Consider integration of browser tests into termbox CI.
May 29 2019, 9:13 AM · Wikidata, Wikidata-Termbox
Pablo-WMDE moved T222875: Set up browser tests from Peer Review to Done on the Wikidata-Termbox-Iteration-16 board.
May 29 2019, 9:10 AM · Wikidata-Termbox-Iteration-16, Patch-For-Review, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE created T224540: Polish checkbox.
May 29 2019, 7:38 AM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata

May 28 2019

Pablo-WMDE claimed T223985: Use checkbox in AnonEditWarning.
May 28 2019, 4:51 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE moved T223985: Use checkbox in AnonEditWarning from To Do to Doing on the Wikidata-Termbox-Iteration-16 board.
May 28 2019, 4:51 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE moved T223542: Focus modal CTAs instead of publish button from Doing to Peer Review on the Wikidata-Termbox-Iteration-16 board.
May 28 2019, 4:48 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

Updated the description

May 28 2019, 1:58 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE updated the task description for T223542: Focus modal CTAs instead of publish button.
May 28 2019, 1:57 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE claimed T223542: Focus modal CTAs instead of publish button.
May 28 2019, 9:24 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T223542: Focus modal CTAs instead of publish button from Test (Product Review) to Doing on the Wikidata-Termbox-Iteration-16 board.
May 28 2019, 9:24 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 27 2019

Pablo-WMDE moved T223982: Create custom checkbox component from Peer Review to Done on the Wikidata-Termbox-Iteration-16 board.
May 27 2019, 12:45 PM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE moved T223966: Add Host: www.wikidata.org to requests in production from Peer Review to Done on the Wikidata-Termbox-Iteration-16 board.
May 27 2019, 12:27 PM · Wikidata-Termbox-Iteration-16

May 24 2019

Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

I'm not quite sure what to do about this. I created a patch to reflect the changes requested but am uncertain if I should hand it in to the other devs to review or if there will be more input about the questions stated above.

May 24 2019, 11:23 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 23 2019

Pablo-WMDE updated the task description for T223982: Create custom checkbox component.
May 23 2019, 8:12 AM · Wikidata-Termbox-Iteration-16, Wikidata

May 22 2019

Pablo-WMDE added a comment to T221831: Add "You are not logged in" overlay popup on termbox editing.

I looked into your change requests - thanks for the very precise instructions. There are a few questions, though.

May 22 2019, 5:31 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Patch-For-Review, Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 21 2019

Pablo-WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

This is now on beta: https://wikidata.beta.wmflabs.org/w/index.php?title=Item:Q11&useformat=mobile
Despite being a subtask of T221831 I put it into product review as it was created / arrived there after the fact.

May 21 2019, 12:41 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T223542: Focus modal CTAs instead of publish button from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-16 board.
May 21 2019, 12:38 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE updated the task description for T223986: Create user preference repository.
May 21 2019, 11:59 AM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE renamed T223985: Use checkbox in AnonEditWarning from Persist preference to Use checkbox in AnonEditWarning.
May 21 2019, 11:35 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE renamed T223987: Use user preference value to avoid "You are not logged in" overlay from Create user preference value to avoid "You are not logged in" overlay to Use user preference value to avoid "You are not logged in" overlay.
May 21 2019, 11:34 AM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T223987: Use user preference value to avoid "You are not logged in" overlay.
May 21 2019, 11:31 AM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T223986: Create user preference repository.
May 21 2019, 11:30 AM · Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T223985: Use checkbox in AnonEditWarning.
May 21 2019, 11:29 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Termbox-Iteration-17, Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE updated the task description for T223982: Create custom checkbox component.
May 21 2019, 11:23 AM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE updated the task description for T223982: Create custom checkbox component.
May 21 2019, 11:21 AM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE created T223982: Create custom checkbox component.
May 21 2019, 11:15 AM · Wikidata-Termbox-Iteration-16, Wikidata
Pablo-WMDE updated the task description for T222963: Add x-amples to openapi depending on ENV.
May 21 2019, 11:08 AM · Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15
Pablo-WMDE updated the task description for T222963: Add x-amples to openapi depending on ENV.
May 21 2019, 11:07 AM · Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15
Pablo-WMDE updated the task description for T223966: Add Host: www.wikidata.org to requests in production.
May 21 2019, 10:46 AM · Wikidata-Termbox-Iteration-16
Pablo-WMDE moved T218086: Ability to disable user-specific SSR from Peer Review to Done on the Wikidata-Termbox-Iteration-16 board.
May 21 2019, 10:33 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 20 2019

Pablo-WMDE updated subscribers of T223875: Focus primary language label after closing IP warning overlay.

This was created in the wake of T223542 to allow for discussion before we invest time.

May 20 2019, 10:06 AM · Wikidata, Wikidata-Termbox
Pablo-WMDE created T223875: Focus primary language label after closing IP warning overlay.
May 20 2019, 9:09 AM · Wikidata, Wikidata-Termbox
Pablo-WMDE updated the task description for T223542: Focus modal CTAs instead of publish button.
May 20 2019, 9:09 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

@Hanna_Petruschat_WMDE We can certainly do that (at +/- identical effort). The proposal was based on the idea of "returning to a state as if the overlay did not happen", i.e. returning control to the user where we interrupted her. Without the overlay the "publish" button would be focused, hence the proposal. Please mend as you see fit!

May 20 2019, 8:01 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE added a comment to T223542: Focus modal CTAs instead of publish button.

@Hanna_Petruschat_WMDE I had another brain wave - please verify that the latter part also makes sense.

May 20 2019, 7:29 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE updated the task description for T223542: Focus modal CTAs instead of publish button.
May 20 2019, 7:28 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata

May 17 2019

Pablo-WMDE updated the task description for T223542: Focus modal CTAs instead of publish button.
May 17 2019, 12:08 PM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T222698: Implement IP warning overlay from Peer Review to Done on the Wikidata-Termbox-Iteration-15 board.
May 17 2019, 10:34 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T222696: Show overlay when entering edit mode from Peer Review to Done on the Wikidata-Termbox-Iteration-15 board.
May 17 2019, 10:34 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T223437: Make work at 320px width from Peer Review to Done on the Wikidata-Termbox-Iteration-15 board.
May 17 2019, 10:33 AM · Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE created T223542: Focus modal CTAs instead of publish button.
May 17 2019, 10:32 AM · Wikidata-Termbox-Iteration-17, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-16, Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T223437: Make work at 320px width from Doing to Peer Review on the Wikidata-Termbox-Iteration-15 board.
May 17 2019, 8:42 AM · Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T222696: Show overlay when entering edit mode from Doing to Peer Review on the Wikidata-Termbox-Iteration-15 board.
May 17 2019, 8:21 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE updated subscribers of T222696: Show overlay when entering edit mode.
  • did some touches in https://gerrit.wikimedia.org/r/510534
  • tried in integration
    Bildschirmfoto von 2019-05-17 10-08-40.png (1×1 px, 235 KB)
  • observed (mind you, this is not on beta, yet - want to give us time to react to challenges before it arrives there to further speed up the iterations on beta)
    • would probably be the right thing to move the focus to the first button in the overlay when it opens (as you can see in the screenshot, the save button has focus [where previously "edit" was], which is the opposite of what we want, allowing you to save the [unaltered] entity through the overlay and being stuck with the overlay => T223542: Focus modal CTAs instead of publish button
    • not ideal that in my (firefox) browser the login & dismiss buttons for e.g. German copy wrap to separate lines which is handled gracefully (Hanna agrees on that) but against spec. As copy is variably long this will always have to be accounted for, but maybe we can change something to have it occur for fewer languages (e.g. font size, ...) @Lea_WMDE @Hanna_Petruschat_WMDE
    • warning should work on screens less wide, too => T223437: Make work at 320px width
May 17 2019, 8:21 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Termbox-Iteration-15, Wikidata

May 16 2019

Pablo-WMDE claimed T223437: Make work at 320px width.
May 16 2019, 2:57 PM · Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE moved T223437: Make work at 320px width from To Do to Doing on the Wikidata-Termbox-Iteration-15 board.
May 16 2019, 2:56 PM · Wikidata-Termbox-Iteration-15, Wikidata
Pablo-WMDE added a comment to T223452: Restyle "more languages" & "all languages" sections.

This may or may not cannibalize T205608: Floating button to collapse „All entered languages“

May 16 2019, 1:49 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikidata, Wikidata-Termbox
Pablo-WMDE created T223452: Restyle "more languages" & "all languages" sections.
May 16 2019, 1:47 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikidata, Wikidata-Termbox
Pablo-WMDE renamed T209496: "In more languages" toggle state persistence from "In more languages" toggle state to "In more languages" toggle state persistence.
May 16 2019, 1:45 PM · Wikidata-Termbox, Wikidata