Merged! Thank you for your work, @Rockingpenny4!

Merged

In T352675#9708288, @jsn.sherman wrote:

In T352675#9707823, @Samwalton9-WMF wrote:

[...]

Susana just mentioned to me that we're currently skipping edits where the username/edit has been revision deleted. It makes sense to me, actually, because if revision deletion is happening an admin has looked at the edit and is already taking moderation actions on it - if the edit should be reverted we can trust that they're also going to take that action.

[...]

Looking at the code, I think these are two slightly different checks. The precheck is seeing if there is a user identity associated with the revision, the edit summary check is seeing if there is an accessible username associated with the user identity. I don't know what the practical distinction is at the moment.

Pushed to prod! Ready for review!

GitHub PR https://github.com/WikipediaLibrary/TWLight/pull/1279 is ready for review

Merged!

@Sandro_Halank_WMDE, this should be working now!

In T354530#9679321, @Samwalton9-WMF wrote:

Unfortunately I'm getting an Internal Server Error when attempting to switch IEEE to Available (while set to Bundle).

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/1277. This is ready for review after testing on staging.

Pushed again to preprod!

In my testing, it looks like the AutoModerator bot can still revert protected and semi-protected pages when it only has the bot user right.

Pushed to preprod. I have already changed the partner to unavailable and bundle authorization.

There are kinds of protection other than admin and semi (for example Flagged Revs adds Pending Changes on some wikis) where it might still make sense for Automoderator to revert. Would it make sense or be feasible to check the bot user group permissions to see if we should be able to edit a given protected page, rather than allowing semi specifically?

I have now created a new patch that removes the sysop permission to AutoModerator and checks if a page is protected.

When an edit is deleted, the CheckRevision script errors out. A patch is incoming to address that.

When a page is moved away from the main namespace, the AutoModerator bot fails the pre-check and skips that revision.

When an admin moves a page, AutoModerator can still revert an edit.

When the page is deleted and then undeleted, the AutoModerator bot is capable of reverting edits.

When the page is deleted, we discovered that the AutoModerator script errors out. A patch is incoming to solve this issue.

When the page is protected, we discovered that the AutoModerator bot can revert an edit.

Created a new non-spike ticket

Should we create a new spike about changing hooks or should this be addressed in this ticket?

Flagged for prod!

Flagged for prod!

Flagged for prod!

We have a problem: the bot flag is stored in the recentchanges table, and at the moment we make the pre-check, I don't think the table has been updated. Let's use the user group way to check for a bot because it will be as accurate. For example, if an account is a bot account when the edit is made, it will be skipped, but if they change the account to be a non-bot, then the next time they make an edit, it will not be skipped.

Just applied the same changes to haaretz.co.il and themarker.com

New changes have been flagged for preprod @Samwalton9-WMF

New changes have been flagged for preprod @Samwalton9-WMF

We have made some changes that are flagged for preprod!

Flagged for prod!

I have pushed this to preprod again!