@Samwalton9, quick question, do these info icons show anything?
Tue, Jul 27
Mon, Jul 26
Wed, Jul 21
Tue, Jul 20
I just remembered about a feature we missed out of the design, added to the acceptance criteria:
- For all authorizations except Library Bundle, a Cross icon should be present in the top right of the tile to enable editors to return their access to this collection (as in the current site design)
Here's what that looks like right now:
Any similar design should work here.
Fri, Jul 16
Thu, Jul 15
Thu, Jul 1
Wed, Jun 30
New changes are live in the staging environment!
Tue, Jun 29
The right/left arrow should be disabled when at the respective end of the carousel (i.e. when users hit the far right end, they shouldn't be able to click a right arrow to loop back to the start). Ideally, the arrow would disappear, but simply disabling the loop-back behaviour would suffice.
@Scardenasmolinar is it possible/straightforward to make the arrow disappear at the ends? Not sure if that was hard in the package you're using or not :)
Jun 29 2021
One piece of feedback we got from the community was that our merging of 'multidisciplinary' with all other tags is confusing:
I've clicked through the tabs at the top, and it seems to me that the choices at the bottom change, but not necessarily to the choices I would expect or choices in alphabetic order. I mean, for example, I clicked on law assuming to fairly quickly find HeinOnline, but had to scroll more than five times to find it. First up was Magiran, a publisher of scientific journals; then Cairn, a publisher of social science materials; then Proquest, a general source conglomerate, before I got to the first law collection, Public International Law, which wasn't Hein. If I didn't know Hein was a major law compiler, I more than likely wouldn't find it, but it would be one of the first sources one should search for research on law materials.
The user responded positively to my suggested improvement, which would be to list collections which specifically have a particular tag first, then the multidisciplinary collections. Is that possible?
So if we had four collections, A, B, C, and D, with A and B having the 'Law' tag and C and D having the 'Multidisciplinary' tag, when a user filtered for Law, instead of current behaviour, which would randomise all 4 in any order, we'd prioritise A and B first, then show C and D.
Jun 28 2021
@aishwaryavardhana noted two issues:
- If you resize your browser screen size the carousel breaks at around 769px
- The right/left arrow should be disabled when at the respective end of the carousel (i.e. when users hit the far right end, they shouldn't be able to click a right arrow to loop back to the start). Ideally, the arrow would disappear, but simply disabling the loop-back behaviour would suffice.
Jun 8 2021
The default view shows Featured collections (collections with featured=True)
Jun 1 2021
May 28 2021
Hi @Shubh1815, can you try running the migrations manually?
May 27 2021
May 26 2021
Relevant PR has been merged https://github.com/WikipediaLibrary/TWLight/pull/713
May 25 2021
This is a translated version to Spanish. Note that some of the new strings won't be available for translation until we get this PR merged
Do you think you could do a quick translation of the homepage elements into Spanish so we can test translation?
May 24 2021
@infinite_verma Can you go to the bash of the container and run the migrations manually?
May 13 2021
May 12 2021
May 11 2021
May 10 2021
May 7 2021
PR (https://github.com/WikipediaLibrary/TWLight/pull/698) has been merged
May 6 2021
Perfect, I'll tag my new work on this task as well.
May 5 2021
After I replaced the setUp() method with setUpTestData(), the tests now ran for an average of 184.893s.
Before I replaced the setUp() method with setUpTestData(), I ran the tests in TWLight/tests.py and they ran for an average of 199.193s.
PR https://github.com/WikipediaLibrary/TWLight/pull/693 has been merged!
May 4 2021
Apr 29 2021
This has been merged.
I have reviewed this PR. @Samwalton9, shouldn't we check that user.editor.ignore_wp_blocks to be True instead of False?
Apr 28 2021
Apr 27 2021
PR has been merged
Apr 26 2021
Apr 24 2021
Apr 21 2021
Marking it as done since it's been discussed in our engineering meeting.
Apr 20 2021
This change has been merged
Because of some difficulties setting up Django 3.2, we will only upgrade to 3.1. Error: https://glitchtip-wikipedialibrary.wmflabs.org/organizations/the-wikipedia-library/issues/54
On further investigation, I think we should stop using Taggit for tags and instead use a JSON field that will store the translation keys for the tags. This JSONField can be validated via JSONSchema to check that only our chosen tags are stored.