Page MenuHomePhabricator
Feed Advanced Search

Jul 2 2019

Tgr created T227066: Integrate MW_API with MediaWiki REST API framework.
Jul 2 2019, 9:26 AM · MediaWiki-API, MediaWiki-REST-API
Tgr created P8696 (An Untitled Masterwork).
Jul 2 2019, 9:16 AM
Tgr created P8695 (An Untitled Masterwork).
Jul 2 2019, 9:15 AM

Jul 1 2019

Addshore awarded T215052: Add MediaWiki login support to Discourse a Like token.
Jul 1 2019, 8:59 PM · Space (Jul-Sep-2019), User-Tgr, Discourse
Tgr added a comment to T227019: Redirect all space.wmflabs.org traffic to HTTPS.

The HTTPS connection is terminated at the proxy server so the app server sees the traffic coming in on port 80. Presumably the proxy will set X-Forwarded-Proto so you can use something like RewriteCond %{HTTP:X-Forwarded-Proto} http instead.

Jul 1 2019, 7:09 PM · VPS-Projects, Space (Jul-Sep-2019)
Tgr moved T223247: Unit or integration test for Sample REST API Handler from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 1 2019, 4:35 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), Core Platform Team Workboards (Team 1), Patch-For-Review, MediaWiki-REST-API
Tgr moved T221170: POST /:domain/v3/transform/wikitext/to/:format/:title?/:revision? from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 1 2019, 4:35 PM · MediaWiki-REST-API
Tgr moved T221172: POST /:domain/v3/transform/:from/to/wikitext/:title?/:revision? from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 1 2019, 4:35 PM · MediaWiki-REST-API
Tgr moved T221169: GET /:domain/v3/page/:format/:title/:revision? from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jul 1 2019, 4:35 PM · MediaWiki-REST-API
Tgr added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

Dashboard: https://logstash-beta.wmflabs.org/app/kibana#/dashboard/AWukuPDnAbPxH_YmoOuJ

  • tags (which contain lots of useful information such as MediaWiki version, language, skin...) are handled extremely poorly by kibana in their current format. They should be converted into top-level properties (preferably with field names matching those in PHP errors so that Kibana visualisations / saved searches can be reused). Not sure what's the right place for that: client, EventGate, logstash filter? (The last one has its own domain language so it would be the most painful to maintain.)
  • the huge ResourceLoader URLs make stack traces visually noisy, and the culprit (name of script where the error occurred) useless. That will be fixed by source maps in some far future date but for now it would be nice to have functionname-only stack traces, and to display the function name from the top stack frame as the culprit. I see no way to do that in kibana (via the GUI at least) so again that would require some preprocessing.
Jul 1 2019, 9:16 AM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Product-Infrastructure-Team-Backlog, Wikimedia-Logstash
Tgr added a comment to T226848: Add feature to convert posts to wikitext.

Discourse uses markdown so you could try one of the existing markdown -> wikitext converters, like Pandoc.

Jul 1 2019, 8:48 AM · Space
Tgr added a comment to T209224: Analyze effect of huwiki FlaggedRevs configuration change on problematic edits and new user retention.

I checked the registration year of users with 5/25+ edits in the last 30 days to get an estimate of how much these new editors are converted into long-term productive editors (5+, 25+) but didn't see any clear trend. (The numbers are too small and noisy for a graph to be useful.)

Jul 1 2019, 8:41 AM · User-Tgr
Tgr edited projects for T226754: Video in MediaWiki:Loginprompt causes login session problems, added: Wikimedia-Video, TimedMediaHandler; removed Regression.

Probably not worth putting much effort into, now that the video player is about to be replaced.

Jul 1 2019, 7:50 AM · TimedMediaHandler, Wikimedia-Video, MediaWiki-User-login-and-signup
Tgr reopened T178154: Newsletter content pages should use "Edit" and instead of "Edit source" as "Open".

On a closer look, the patch and the task description seem to be about different issues - the patch removes the (disfunctional) View Source button, the task talks about Edit Source.

Jul 1 2019, 7:00 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MediaWiki-extensions-Newsletter
Tgr closed T178154: Newsletter content pages should use "Edit" and instead of "Edit source" as Resolved.
Jul 1 2019, 6:54 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MediaWiki-extensions-Newsletter

Jun 30 2019

Tgr updated subscribers of T226766: Avoid explicit commit references in composer.json in code meant for public consumption.

Thanks @Jamesmontalvo3 for originally reporting the issue and @MarkAHershberger for tracking down the exact trigger!

Jun 30 2019, 10:03 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr added a comment to T224377: Properly implement trace, dump, debug log support via possibly a LoggingUtils.

As for granular enabling, I'd imagine we want to use channels like 'parsoid.trace.tsp' and make the channel configuration fall back to 'parsoid.trace' if unspecified. That would require some changes to Wikimedia config, but doesn't seem too difficult.

Jun 30 2019, 9:32 AM · Parsoid-PHP
Tgr added a comment to T224377: Properly implement trace, dump, debug log support via possibly a LoggingUtils.

The main difference is that Parsoid supports lazy evaluation via closures, while MediaWiki logging doesn't (neither the abstraction layer, PSR-3, nor the specific implementation used in production, Monolog). It's easy to write a Monolog processor for evaluating closures, so that seems like the most likely path forward.

Jun 30 2019, 9:30 AM · Parsoid-PHP
Tgr added a project to T225971: Mwoauthdatastore-request-token-already-used shows html tags instead : MediaWiki-Language-converter.

It shouldn't be <a class="external" href="-{R|https://www.mediawiki.org/wiki/Help:OAuth/Errors#E009}-">E009</a>

Jun 30 2019, 8:25 AM · MediaWiki-Language-converter, MediaWiki-extensions-OAuth
Tgr added a comment to T226727: Integrate mailing lists in Wikimedia Space.

Note that deleting a thread and purging it from storage are different things. The latter will be needed here for compliance with the data retention policy.

Jun 30 2019, 8:08 AM · Space (Jan-Mar-2020), Operations, Wikimedia-Mailing-lists

Jun 29 2019

Tgr added a comment to T223900: Create ORES dataset for huwiki edits in the last two years or so.

@Halfak says the ores Python package can be used to produce it.

Jun 29 2019, 7:28 PM · artificial-intelligence, Scoring-platform-team, editquality-modeling, User-Tgr
Tgr added a comment to T223882: Re-label huwiki damaging and badfaith edits.

@Halfak can I help move this along? If you can specify the conditions and the expected format, I can produce a dataset.

Jun 29 2019, 11:46 AM · Scoring-platform-team (Current), editquality-modeling, Wikilabels, artificial-intelligence

Jun 28 2019

Tgr added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
{
  "_index": "logstash-2019.06.28",
  "_type": "clienterror",
  "_id": "AWuePijpAbPxH_Ymd-b9",
  "_score": 1,
  "_source": {
    "exception": {
      "type": "Error",
      "value": "Unknown module: jquery.wikibase.sitelinkview"
    },
    "request": {
      "headers": {
        "User-Agent": "*SNIP*"
      },
      "url": "https://wikidata.beta.wmflabs.org/wiki/Q15905"
    },
    "$schema": "/client/error/1.0.0",
    "level": "ERROR",
    "logger": "javascript",
    "project": "4",
    "message": "Unknown module: jquery.wikibase.sitelinkview",
    "type": "clienterror",
    "platform": "javascript",
    "normalized_message": "Unknown module: jquery.wikibase.sitelinkview",
    "tags": [
      "es",
      "normalized_message_untrimmed"
    ],
    "culprit": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
    "@timestamp": "2019-06-28T13:20:02.266Z",
    "stacktrace": {
      "frames": [
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "97",
          "colno": "386",
          "function": "?"
        },
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "97",
          "colno": "190",
          "function": "?"
        },
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "21",
          "colno": "126",
          "function": "load"
        },
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "9",
          "colno": "656",
          "function": "resolveStubbornly"
        },
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "9",
          "colno": "306",
          "function": "sortDependencies"
        },
        {
          "in_app": "true",
          "filename": "https://wikidata.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector",
          "lineno": "8",
          "colno": "792",
          "function": "sortDependencies"
        }
      ]
    },
    "meta": {
      "stream": "client.error"
    },
    "original_tags": [
      [
        "debug",
        "false"
      ],
      [
        "ns",
        "0"
      ],
      [
        "page_name",
        "Q15905"
      ],
      [
        "skin",
        "vector"
      ],
      [
        "action",
        "view"
      ],
      [
        "language",
        "en"
      ],
      [
        "source",
        "resolve"
      ],
      [
        "version",
        "1.34.0-alpha"
      ],
      [
        "user_groups",
        [
          "*"
        ]
      ],
      "input-clienterror-eqiad",
      "kafka",
      "truncated_by_filter_truncate"
    ],
    "@version": "1"
  },
  "fields": {
    "@timestamp": [
      1561728002266
    ]
  }
}
Jun 28 2019, 2:55 PM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Product-Infrastructure-Team-Backlog, Wikimedia-Logstash
Tgr added a comment to T226762: [Bug] GET /data/lists doesn't include "next" in an incomplete response.

See T226640: ReadingLists CI broken. Should be fixed with the next MediaWiki deploy.

Jun 28 2019, 5:54 AM · Product-Infrastructure-Team-Backlog, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Reading List Service

Jun 27 2019

Tgr added a comment to T226766: Avoid explicit commit references in composer.json in code meant for public consumption.

1.27 isn't supported ;)

Jun 27 2019, 8:04 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr added a comment to T226766: Avoid explicit commit references in composer.json in code meant for public consumption.

composer.json@1b990608 (which is currently pinned in MW 1.31) and composer.json@2018.1.2 are identical apart from dev requirements, so probably the simplest fix for 1.31 is replacing "jetbrains/phpstorm-stubs": "dev-master#1b9906084d6635456fcf3f3a01f0d7d5b99a578a" with "jetbrains/phpstorm-stubs": "2018.1.2#1b9906084d6635456fcf3f3a01f0d7d5b99a578a".

Jun 27 2019, 7:59 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr updated subscribers of T226766: Avoid explicit commit references in composer.json in code meant for public consumption.

Per codesearch Translatewiki is the only code currently affected (and that's not really publicly released software; still, heads-up, @Nikerabbit). Not sure how to check which past releases are affected.

Jun 27 2019, 7:49 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr updated the task description for T226766: Avoid explicit commit references in composer.json in code meant for public consumption.
Jun 27 2019, 7:46 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr created T226766: Avoid explicit commit references in composer.json in code meant for public consumption.
Jun 27 2019, 7:44 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
Tgr closed T226640: ReadingLists CI broken as Resolved.
Jun 27 2019, 6:56 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Product-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated subscribers of T126330: Document common low level site requests (namespace + logo changes, IP throttling expectations) for potential technical contributors and advertise those docs in tasks.

@Majavah just started working on site requests as a new volunteer, maybe they have some insight on what needs to be better documented.

Jun 27 2019, 6:30 PM · Developer-Advocacy (Jul-Sep 2019), Developer-Wishlist (2017), Wikimedia-Site-requests, Documentation
Tgr added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

Per IRC discussion, beta Logstash needs to be configured to ingest from the eqiad.client.error Kafka topic.

Jun 27 2019, 4:17 PM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Product-Infrastructure-Team-Backlog, Wikimedia-Logstash
Tgr added a watcher for Space: Tgr.
Jun 27 2019, 9:20 AM
Tgr added a comment to T226664: Allow commenting/contributing without an account on Wikimedia Space.

Presumably this refers to the founding principles, which say "almost anyone [should be able] to edit (most) articles without registration". I don't think that automatically extends to discussion spaces (most of which already require an account of some sort - e.g. you need to register an email address to participate on the mailing lists). Articles are seen as the point of entry for new contributors, so keeping the barrier to entry as low as possible helps (and you don't need any familiarity with the community or movement to spot a spelling error). If the Wikimedia Space is similarly seen as a contact surface with people completely new to the movement, keeping the barrier of entry as low as possible is important. If it's mainly seen as a communication space for people who are already in the movement, then SUL login should suffice. Those both seem like potentially valid approaches to me.

Jun 27 2019, 9:20 AM · Space (Jul-Sep-2019)

Jun 26 2019

Tgr committed rERLS151625b93bc9: Fix API continuation (authored by Tgr).
Fix API continuation
Jun 26 2019, 6:24 PM
Tgr moved T226640: ReadingLists CI broken from To Do to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.
Jun 26 2019, 6:23 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Product-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.

Tested with https://en.wikipedia.beta.wmflabs.org/wiki/User:Tgr/common.js , the errors are sent to https://eventgate-logging.wmflabs.org/v1/events and result in a 201. I don't see anything in https://logstash-beta.wmflabs.org , maybe there's some processing delay?

Jun 26 2019, 4:58 PM · observability, User-fgiunchedi, Better Use Of Data, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-herron, Product-Infrastructure-Team-Backlog, Wikimedia-Logstash
Tgr added a comment to T226640: ReadingLists CI broken.

Apparently rMWd9f688698ce0: rdbms: clean up and refactor ResultWrapper classes has changed the indexing of ResultWrapper from 1-based to 0-based, so query continuation in Reading Lists was broken for almost a month :(

Jun 26 2019, 2:54 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Product-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited projects for T226593: Fatal ApiReadingLists request: "deleteListEntry failed for unknown reason", added: Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog.
Jun 26 2019, 2:13 PM · Product-Infrastructure-Team-Backlog, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Reading List Service, Wikimedia-production-error
Tgr edited projects for T226640: ReadingLists CI broken, added: Product-Infrastructure-Team-Backlog (Kanban); removed Product-Infrastructure-Team-Backlog.
Jun 26 2019, 2:12 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Product-Infrastructure-Team-Backlog (Kanban), Reading List Service
Restricted Application added a project to T226640: ReadingLists CI broken: Product-Infrastructure-Team-Backlog.
Jun 26 2019, 2:12 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Product-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr committed rERLS269bd1db49f8: [DNM] CI test (authored by Tgr).
[DNM] CI test
Jun 26 2019, 1:04 PM
Tgr added a comment to T114384: Standardise procedures for deprecating public-facing code.

If there is a good central backlog listing the planned breaking changes accompanied by analysis of what needs fixing (which scripts call a deprecated API method, say), some guidance on how to fix it, and developer support when community volunteers get in over their head. Most technically minded community members I know of (those working on scripts and bots, say) are perfectly happy to help in this way.

Jun 26 2019, 12:48 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, WMF-Product-Development-Process, MediaWiki-API, Developer-Advocacy, User-notice
Tgr added a comment to T210651: Switch all PDF render traffic to new Proton service.

We had no issues for the last 20 days. I imagine if anything broke we would know by now.

Jun 26 2019, 12:23 PM · Core Platform Team Workboards (Done with CPT), Services (done), User-notice, Product-Infrastructure-Team-Backlog, Readers-Web-Backlog (Tracking), Proton
Restricted Application added a project to T226633: PDF renderer needs better CJK font: Product-Infrastructure-Team-Backlog.
Jun 26 2019, 12:21 PM · Operations, Patch-For-Review, Chinese-Sites, PDF-Rendering, Product-Infrastructure-Team-Backlog, Proton
Tgr added a parent task for T226631: Write user documentation for Matrix trial: T215042: Set up a hosted Matrix.org / Riot instance on modular.im.
Jun 26 2019, 11:32 AM · Documentation, Matrix
Tgr added a subtask for T215042: Set up a hosted Matrix.org / Riot instance on modular.im: T226631: Write user documentation for Matrix trial.
Jun 26 2019, 11:32 AM · Matrix, User-Tgr
Tgr created T226631: Write user documentation for Matrix trial.
Jun 26 2019, 11:32 AM · Documentation, Matrix
Tgr added a comment to T226587: Notifications count via notwikis=* doesn’t work for sessions providers other than CentralAuth.

Probably some permission check somewhere, that's not included in the grant? Can't find it at a glance, though.

Jun 26 2019, 9:30 AM · Growth-Team, MediaWiki-API, Notifications
Tgr added a comment to T226593: Fatal ApiReadingLists request: "deleteListEntry failed for unknown reason".

As for the main error, an UPDATE has no effect even though a row on which it is guaranteed to have effect has just been write-locked... no idea what could be going on there.

Jun 26 2019, 9:17 AM · Product-Infrastructure-Team-Backlog, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Reading List Service, Wikimedia-production-error
Tgr committed rERLS787480eba5a0: Fix missing column for ReadingListRepository::deleteListEntry logging (authored by Tgr).
Fix missing column for ReadingListRepository::deleteListEntry logging
Jun 26 2019, 9:14 AM
Tgr added a comment to T226593: Fatal ApiReadingLists request: "deleteListEntry failed for unknown reason".

The same requests also have the following error emitted, shortly before it reaches the fatal:

PHP Notice: Undefined property: stdClass::$rle_id
Jun 26 2019, 9:13 AM · Product-Infrastructure-Team-Backlog, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Reading List Service, Wikimedia-production-error

Jun 25 2019

D3r1ck01 awarded T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean" a Yellow Medal token.
Jun 25 2019, 6:48 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr added a comment to T226545: Loop trying to create an account in Wikimedia Space in certain cases.

Does it also happen with Javascript disabled?

Jun 25 2019, 5:56 PM · Space (Jul-Sep-2019), Discourse
Tgr added a comment to T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

That does explain it, actually. The patch replaces wfFindFile (which proxied to LocalRepo::findFile) with $localRepo->findFile (despite the name, $localRepo is RepoGroup, not LocalRepo). RepoGroup::findFile calls Repo::findFile but has an extra layer of in-process cache which LocalFileMoveBatch does not invalidate. So probably something somewhere earlier did a RepoGroup::findFile call for the move target, false got cached, and it gets loaded from the cache in the lines before DeferredUpdates::addUpdate.

Jun 25 2019, 4:49 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr added a comment to T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

Reverting rMW21e2d71560cb: Replace some uses of deprecated wfFindFile() and wfLocalFile() in full does make the error go away.

Jun 25 2019, 2:55 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr added a comment to T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

Hm, fixing that did not fix the error. (And getting it locally means it's not replag-related.) So I guess that leaves the cache in LocalFile::load (which also does not seem to be reset during move), not sure what triggered a change in behavior though.

Jun 25 2019, 2:38 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr added a comment to T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

They aren't equivalent, the first returns a repo, the second a repo group.

Jun 25 2019, 2:27 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr merged T226491: File renamed/moved on Commons but new page says "No file by this name exists" into T226473: Caching issues when moving files.
Jun 25 2019, 12:58 PM · Multimedia, MediaWiki-File-management, Commons, media-storage, MediaWiki-Cache
Tgr merged task T226491: File renamed/moved on Commons but new page says "No file by this name exists" into T226473: Caching issues when moving files.
Jun 25 2019, 12:58 PM · media-storage, Multimedia, Commons, MediaWiki-File-management
Tgr triaged T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean" as Unbreak Now! priority.

Train blockers are UBN. It's also a nuisance to Commons users per T226473: Caching issues when moving files.

Jun 25 2019, 12:57 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr added a comment to T226473: Caching issues when moving files.

Possibly caused by T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

Jun 25 2019, 12:56 PM · Multimedia, MediaWiki-File-management, Commons, media-storage, MediaWiki-Cache
Tgr added a comment to T226448: Fatal logged after renaming files: "LocalFile.php: Call to a member function purgeEverything() on boolean".

Seems a bit race-y

Jun 25 2019, 11:55 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, Commons, MediaWiki-API, MediaWiki-File-management, Wikimedia-production-error
Tgr updated subscribers of T226358: Failover x1 master: db1069 to db1120 3rd July at 06:00 UTC.
tgr@stat1006:~$ analytics-mysql enwiki --use-x1
Jun 25 2019, 10:05 AM · Product-Infrastructure-Team-Backlog, WikimediaEditorTasks, Reading List Service, ContentTranslation, MediaWiki-extensions-BounceHandler, StructuredDiscussions, MediaWiki-extensions-UrlShortener, User-notice, Cognate, Language-Team, Growth-Team, Operations, DBA

Jun 24 2019

Tgr added a comment to T226437: Audit uses of empty() and isset() and eliminate unnecessary uses.

This would be a lot easier on top of T226428: Convert stdclass-cast objects to classes wherever possible and use associative arrays elswhere as far as possible - isset/empty is usually needed because it is hard to guarantee array/stdclass fields are always set, and classes do not have that problem.

Jun 24 2019, 6:42 PM · Technical-Debt, Parsoid-PHP
Tgr added a comment to T221876: Pick one html5 source (whatwg or w3c) and update all code documentation links to point to that source.

Seems like the WHATWG is winning this one.

Jun 24 2019, 6:40 PM · Documentation, Parsoid-PHP
Tgr added a comment to T179082: Use one ownerDocument for the entire parse.

Related: T217705: RemexHTML should be able to parse HTML into an existing DOM node

Jun 24 2019, 6:37 PM · Parsoid

Jun 23 2019

Tgr triaged T226324: HHVM checks only happen on submit as High priority.

Also, even in the gate pipeline build, the syntax error was only caught in the unit tests, which suggests there is no HHVM linting whatsoever (presumably that would happen before phpunit) and if a class has no tests, syntax error aren't caught at all until reaching production. That seems bad.

Jun 23 2019, 8:50 AM · HHVM, Continuous-Integration-Config
Tgr updated the task description for T226324: HHVM checks only happen on submit.
Jun 23 2019, 8:49 AM · HHVM, Continuous-Integration-Config

Jun 22 2019

Tgr created T226324: HHVM checks only happen on submit.
Jun 22 2019, 11:13 PM · HHVM, Continuous-Integration-Config
Tgr added a comment to T226144: Fix flaky Selenium test: Rollback without confirmation should perform rollback via GET request without asking the user to confirm.

The POST equivalent seems flaky as well:
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php72-docker/1011/console

21:10:35 1) Rollback without confirmation should perform rollback via POST request without asking the user to confirm:
21:10:35 Expected rollback page to appear.
21:10:35 running chrome
21:10:35 Error: Expected rollback page to appear.
21:10:35     at elementIdText("0.1626589557410456-1") - getText.js:35:50

(patch is a no-op)

Jun 22 2019, 7:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Confirmation prompt for rollback action, Continuous-Integration-Infrastructure, Browser-Tests
Tgr added a comment to T226294: Use a separate log action for file deletion.

Not sure if this makes sense in light of T96384: Integrate file revisions with description page history.

Jun 22 2019, 3:33 PM · MediaWiki-Logging, Multimedia, MediaWiki-File-management, Commons

Jun 21 2019

Tgr added a comment to T226253: Composer\Downloader\TransportException in CI builds for multiple repositories.

See T182266: Error "TransportException 404 Not Found" in Jenkins jobs using composer for similar issues in the past. Sometimes it was due to upstream problems, sometimes not.

Jun 21 2019, 2:53 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure)
Tgr added a comment to T223835: Configure wikimedia.org to enable *:wikimedia.org Matrix user IDs.

https://wikimedia.org/.well-known/matrix/server works corrently. https://wikimedia.org/.well-known/matrix/client is loaded via AJAX and complains about the lack of CORS headers though.

Jun 21 2019, 6:32 AM · serviceops, Patch-For-Review, Traffic, DNS, Operations, Wikimedia-Apache-configuration, Matrix
Tgr added a parent task for T224068: Serve skin customizations for modular.im Matrix instance: T215042: Set up a hosted Matrix.org / Riot instance on modular.im.
Jun 21 2019, 6:31 AM · Matrix
Tgr added a subtask for T215042: Set up a hosted Matrix.org / Riot instance on modular.im: T224068: Serve skin customizations for modular.im Matrix instance.
Jun 21 2019, 6:31 AM · Matrix, User-Tgr

Jun 20 2019

Tgr added a comment to T209224: Analyze effect of huwiki FlaggedRevs configuration change on problematic edits and new user retention.

Users with 5-24 edits are up too, that's encouraging (unless that stat somehow includes anons): https://stats.wikimedia.org/v2/#/hu.wikipedia.org/contributing/editors/normal|line|all|activity_level~5..24-edits|monthly

Jun 20 2019, 7:52 PM · User-Tgr
Tgr added a comment to T209224: Analyze effect of huwiki FlaggedRevs configuration change on problematic edits and new user retention.

(Note to self because someone asked and I had to search for it: the original enabling was in 2009 June: T17568.)

Jun 20 2019, 7:50 PM · User-Tgr
Tgr awarded Blog Post: Tracking down slow event handlers with Event Timing a Yellow Medal token.
Jun 20 2019, 5:57 PM · Performance-Team
Tgr added a comment to T223835: Configure wikimedia.org to enable *:wikimedia.org Matrix user IDs.

@Tgr just to be sure, you just want the url https://wikimedia.org/.well_known to be served from a static file?

Jun 20 2019, 2:41 PM · serviceops, Patch-For-Review, Traffic, DNS, Operations, Wikimedia-Apache-configuration, Matrix
Tgr added a comment to T226084: Wikidata server slow.

There have been complaints on huwiki as well (and partial / failed page loads, presumably due to some kind of timeout; I have seen a few myself). Don't know if it's related. It has definitely started sooner than the group1 deployment, though.

Jun 20 2019, 9:20 AM · Wikidata-Campsite, Wikidata
Tgr added a comment to T226048: Sometimes pages load slowly for users routed to the Amsterdam data center (due to some factor outside of Wikimedia cluster).

Not limited to dewiki / Germnany (unsurprisingly), there have been a bunch of reports from huwiki/Hungary as well.

Jun 20 2019, 9:19 AM · User-notice, Performance-Team (Radar), Traffic, Operations, Performance
Tgr created T226162: Expose more properties to the user_properties_anon table on Wiki Replicas.
Jun 20 2019, 9:08 AM · Data-Services
Tgr added a comment to T226084: Wikidata server slow.

There have been complaints on huwiki as well (and partial / failed page loads, presumably due to some kind of timeout; I have seen a few myself). Don't know if it's related. It has definitely started sooner than the group1 deployment, though.

Jun 20 2019, 6:15 AM · Wikidata-Campsite, Wikidata

Jun 19 2019

Tgr committed R1985:42ce5586d218: Add history file, prepare for 3.0.0 release (authored by Tgr).
Add history file, prepare for 3.0.0 release
Jun 19 2019, 1:43 PM
Tgr added a comment to T225628: On CI, stop testing MediaWiki with php7.0 ahead of dropping support.

php7.0 went EOL in January 2019 and we released MediaWiki 1.32 the same month claiming to support php7.0. Most probably php7.0 should have been formally dropped at that point.

Jun 19 2019, 8:01 AM · Patch-For-Review, TechCom, Continuous-Integration-Config

Jun 18 2019

Tgr created T226043: MediaWiki REST API router should handle HEAD requests.
Jun 18 2019, 6:50 PM · MediaWiki-REST-API

Jun 17 2019

Tgr added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

Gadget support: developers of on-wiki code (templates, modules and gadgets) get little support. We have a team for supporting external tool developers, and at least one for supporting developers of production code, and third-party code of a similar fashion, but the gadget development environment is still Stone Age, with no testing, CI, code review, barely any logging. There isn't even a central platform to store the code so all wikis have to reinvent the wheels. There were several attempts to improve things but they all stalled due to lack of proper resourcing. In the meanwhile, the importance of this kind of development is hard to overstate - templates/modules are a core component of all nontrivial wiki workflows, and of the reader UI, and gadgets are probably the most used among the volunteer-maintained tools. It would be nice to see some improvements there.

Jun 17 2019, 11:18 PM · International-Developer-Events
Tgr added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

Modern release management: complex web applications these days usually try control the stack they run on, via some manner of containerization. MediaWiki in contrast tries to support a huge range of potential systems and services, and mostly fails (in theory we support five DB engines but few extensions actually work on more than two; key features like WYSIWYG editing are impossible to install on the overwhelming majority of MediaWiki installations), the software not being able to assume anything about the system degrades the default the user experience (out-of-the box search is poor, out-of-the-box logging is poor, documentation is a confusing mess of trying to explain how to perform the tasks on dozens of different systems), and we are barred from various potentially valuable technology choices like isomorphic rendering.

Jun 17 2019, 9:55 PM · International-Developer-Events
Tgr updated subscribers of T220212: Wikimedia Technical Conference 2019: Discussion .

Code review: @TJones already mentioned this, but it's probably our largest problem today. Code review for code that another team or volunteer is not actively working on tends to take months at best. There are no incentives for staff members to do code review (not even for code review of other staff, due to the restricted annual review format, much less for volunteers), while spending the same time on e.g. a side project will much more likely result in that work being celebrated. There is (at least in theory) 10% of paid engineering staff time set aside for experimentation, but 0% for supporting volunteers who write code. We use an older version of Gerrit which makes reviews of complex patches challenging to follow.

Jun 17 2019, 8:59 PM · International-Developer-Events
Tgr added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

Some more potential topics:

Jun 17 2019, 8:52 PM · International-Developer-Events
Tgr added a comment to T225963: Investigate slowness of imageinfo extended metadata (extmetadata) queries.

Also, the cache expiration is 30 days, so a request involving lots of cache misses would not be that unusual. The API should probably be modified to limit the number of uncached extmetadata lookups and force continuation when the limit is reached.

Jun 17 2019, 8:36 PM · Spike, Multimedia, CommonsMetadata, Product-Infrastructure-Team-Backlog
Tgr added a comment to T225963: Investigate slowness of imageinfo extended metadata (extmetadata) queries.

Reasons I can think of off the top of my head:

  • Some other part of the imageinfo API is slow. (extmetadata is cached via FormatMetadata::fetchExtendedMetadata() but the API call itself is not.)
  • FormatMetadata::fetchExtendedMetadata() itself is slow. It has dynamic cache invalidation (even if it is a cache hit, the ValidateExtendedMetadataCache hook gets invoked) so while unlikely it is not impossible.
  • Some broken ValidateExtendedMetadataCache hook. (A bug in this recent patch, for example.)
  • The cache (correctly) getting invalidated all the time due to frequent edits coming from SDC. (Theoretically, a change in the structured data shouldn't invalidate it, but this is pre-MCR code and not slot-aware.)
  • Some bug affecting the caching logic (e.g. File::getDescriptionTouched() broke).
Jun 17 2019, 8:33 PM · Spike, Multimedia, CommonsMetadata, Product-Infrastructure-Team-Backlog
Tgr added a comment to T127640: Re-evaluate our use of Phabricator Conpherence chat.

In the discussion about potential other tools, which options have been proposed and discussed? For example, has Zulip been investigated? Could the communication requirements which Stewards have be shared somehow/somewhere?

Jun 17 2019, 7:20 PM · Developer-Advocacy (Jul-Sep 2019), Phabricator
Tgr added a comment to T225628: On CI, stop testing MediaWiki with php7.0 ahead of dropping support.

No, that's specifically what Antoine is proposing in this task. Dropping formal MW support for PHP 7.0 is T216165.

Jun 17 2019, 7:07 PM · Patch-For-Review, TechCom, Continuous-Integration-Config

Jun 16 2019

Tgr updated the task description for T225900: Structured image metadata of File:Editors_on_huwiki_until_2019-04-01.png.png uneditable.
Jun 16 2019, 9:52 PM · Multimedia, Commons, Structured Data Engineering
Restricted Application added a project to T225900: Structured image metadata of File:Editors_on_huwiki_until_2019-04-01.png.png uneditable: Multimedia.
Jun 16 2019, 9:50 PM · Multimedia, Commons, Structured Data Engineering
Tgr added a comment to T225628: On CI, stop testing MediaWiki with php7.0 ahead of dropping support.

php 7.0 is end of life, and if we were to support it for MediaWiki 1.31, that means we get to port php 7.0 until January 2021. Or 3 years after that PHP version got EOL. At that point, I don't think those tests would be any helpful since nobody would still be running PHP 7.0. In facts, nobody should be running php 7.0 already in June 2019.

Jun 16 2019, 9:41 PM · Patch-For-Review, TechCom, Continuous-Integration-Config
Tgr added a comment to T225871: Selenium and PHPUnit: Stop execution on failure.

I would actually object to this: imagine your change has caused multiple test failures that you weren't able to predict in your dev environment (because you didn't have all extensions installed or your environment is otherwise different from our CI). You'll have to amend your PR with one fix at a time and push it just to see what explodes next.

Jun 16 2019, 6:46 PM · Continuous-Integration-Config
Tgr added a comment to T224920: Evaluate whether to create a RESTBase-backed JSON endpoint for image metadata.

If there's no significant performance penalty on the MW API for getting additional fields, I'd say it's worth just returning everything

Jun 16 2019, 5:13 PM · Core Platform Team Legacy (Designing), Services (designing), Page Content Service, Product-Infrastructure-Team-Backlog